[WIP - will pick back up after break] DM XML parsing: Fix type annotations #36914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Takes mypy errors down from 79 to 27. Nearly all remaining are
related to Enum - mypy has support for Enum functions, but it seems
like the derived classes are messing it up. Can be addressed
in a followup - this is still better.
The goal here is mostly to tighten up the type annotations and
move int -> uint for ids where possible, such that the spec
parsing is providing data with a stronger guarantee.
Testing: Tested by TestSpecParsing.py and TestSpecParsingDeviceTypes.py
Also used by tests run in CI (including above)
|
Review changes with Changed Files
|
github-actions
bot
added
tests
matter-1.4-te2-script-change
|
PR #36914: Size comparison from 3a931d6 to 991e32e Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes mypy errors down from 79 to 27. Nearly all remaining are related to Enum - mypy has support for Enum functions, but it seems like the derived classes are messing it up. Can be addressed in a followup - this is still better.
The goal here is mostly to tighten up the type annotations and move int -> uint for ids where possible, such that the spec parsing is providing data with a stronger guarantee.
Testing: Tested by TestSpecParsing.py and TestSpecParsingDeviceTypes.py
Also used by tests run in CI (including above)