Remove provisional markings on more things in Matter.framework. #36912
+777
−819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bzbarsky-apple
commented
Dec 19, 2024
•
bzbarsky-apple
commented
- Time Synchronization could not be un-marked because the SDK and spec do not match.
- Timer does not seem to exist in the spec.
- The following were already marked as introduced with a later release than the provisional marking, so the provisional annotation was just stale:
- Boolean State Configuration cluster.
- Valve Configuration and Control cluster.
- Removes provisional markings from:
- Aliro functionality on Door Lock.
- Laundry Dryer Controls cluster.
- Parts of Electrical Energy Measurement cluster that for some reason were still marked that way. Fixes the fields of MTRElectricalEnergyMeasurementClusterMeasurementAccuracyRangeStruct to not be available before the struct itself is.
- Device Energy Management cluster.
- Device Energy Management Mode cluster.
|
Review changes with |
jtung-apple
approved these changes
Dec 19, 2024
* Time Synchronization could not be un-marked because the SDK and spec do not match.
* Timer does not seem to exist in the spec.
* The following were already marked as introduced with a later
release than the provisional marking, so the provisional annotation was just
stale:
- Boolean State Configuration cluster.
- Valve Configuration and Control cluster.
* Removes provisional markings from:
- Aliro functionality on Door Lock.
- Laundry Dryer Controls cluster.
- Parts of Electrical Energy Measurement cluster that for some reason were
still marked that way. Fixes the fields of
MTRElectricalEnergyMeasurementClusterMeasurementAccuracyRangeStruct to not
be available before the struct itself is.
- Device Energy Management cluster.
- Device Energy Management Mode cluster.
bzbarsky-apple
force-pushed
the
unprovisional-more
branch
from
40426c6 to
692164b
Compare
|
PR #36912: Size comparison from 388be5b to 692164b Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
Fast-tracking platform-specific change with platform owner review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.