Feature/thermostat events xml #36909
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #36909: Size comparison from f05b65e to bde3911 Full report (5 builds for cc32xx, stm32, tizen)
|
|
PR #36909: Size comparison from f05b65e to 880c50d Full report (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
There may be more changes as the last bit of the spec PR gets finalized.
|
PR #36909: Size comparison from f05b65e to 7fa387a Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
requested changes
Dec 19, 2024
| @@ -309,6 +309,9 @@ limitations under the License. | |||
| <feature bit="8" code="PRES" name="Presets" summary="Thermostat supports setpoint presets"> | |||
| <optionalConform/> | |||
| </feature> | |||
| <feature bit="9" code="TEVT" name="Events" summary="Thermostat supports events"> | |||
| <optionalConform/> | |||
There was a problem hiding this comment.
Shouldn't this be flagged provisional in the XML somehow for now?
| <field id="0" name="PreviousRunningMode" type="ThermostatRunningModeEnum" optional="true"/> | ||
| <field id="1" name="CurrentRunningMode" type="ThermostatRunningModeEnum"/> | ||
| <mandatoryConform> | ||
| <feature name="TEVT"/> |
There was a problem hiding this comment.
This does not seem to match the spec's conformance for this event?
Comment on lines
+764
to
+765
| <field id="0" name="PreviousPresetHandle" type="octet_string" optional="true"/> | ||
| <field id="1" name="CurrentPresetHandle" type="octet_string"/> |
There was a problem hiding this comment.
These don't match the spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XML for https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/10444