Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESP32] Added new Matter Traces in esp32 platform for diagnosis #36873

Draft
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

pimpalemahesh
Copy link
Contributor

Problem:

Additional diagnostics are needed to improve the efficiency of debugging and monitoring on the ESP32 platform.

Change Overview:

Added BLE, WiFi, Heap and FreeRTOS Task snapshot related diagnostics in esp32 platform for diagnosis purpose.

Test:

Successfully retrieved the added diagnostics using the Platform Diagnostics Framework.

- Working backend with metric, trace and counter diagnostics
- Diagnostic interface implementation with ring buffer storage
- Added option ENABLE_ESP_DIAGNOSTICS_TRACE in chip KConfig
- Added required options for enabling matter diagnostic trace in project Kconfig
- Enabled diagnostic trace for temperature-measurement-app example
- Resolve buffer related issues
- Add store diagnostic call for trace_end and trace_instant
- Update scoped macro
- Remove extra namespace values, spaces and print statements
- Remove evicthead call for circular buffer after read successful
- Resolve buffer issues
- Use single buffer for store and retrieve of diagnostics
- Resolve data loss issue
…essary comments, format files, namespace changes
Copy link

semanticdiff-com bot commented Dec 17, 2024

Review changes with  SemanticDiff

Changed Files
File Status
  config/esp32/components/chip/CMakeLists.txt Unsupported file format
  config/esp32/components/chip/Kconfig Unsupported file format
  examples/temperature-measurement-app/esp32/main/Kconfig.projbuild Unsupported file format
  examples/temperature-measurement-app/esp32/main/diagnostic-logs-provider-delegate-impl.cpp Unsupported file format
  examples/temperature-measurement-app/esp32/main/include/diagnostic-logs-provider-delegate-impl.h Unsupported file format
  examples/temperature-measurement-app/esp32/main/main.cpp Unsupported file format
  scripts/tools/check_includes_config.py  0% smaller
  src/platform/ESP32/BUILD.gn Unsupported file format
  src/platform/ESP32/ConnectivityManagerImpl.h Unsupported file format
  src/platform/ESP32/ConnectivityManagerImpl_WiFi.cpp Unsupported file format
  src/platform/ESP32/ESP32Utils.cpp Unsupported file format
  src/platform/ESP32/ESP32Utils.h Unsupported file format
  src/platform/ESP32/nimble/BLEManagerImpl.cpp Unsupported file format
  src/tracing/esp32_diagnostic_trace/BUILD.gn Unsupported file format
  src/tracing/esp32_diagnostic_trace/Counter.cpp Unsupported file format
  src/tracing/esp32_diagnostic_trace/Counter.h Unsupported file format
  src/tracing/esp32_diagnostic_trace/DiagnosticStorageManager.h Unsupported file format
  src/tracing/esp32_diagnostic_trace/DiagnosticTracing.cpp Unsupported file format
  src/tracing/esp32_diagnostic_trace/DiagnosticTracing.h Unsupported file format
  src/tracing/esp32_diagnostic_trace/Diagnostics.h Unsupported file format
  src/tracing/esp32_diagnostic_trace/include/matter/tracing/macros_impl.h Unsupported file format

@CLAassistant
Copy link

CLAassistant commented Dec 17, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Dec 18, 2024

PR #36873: Size comparison from 4e44586 to da1f8b0

Full report (19 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
platform target config section 4e44586 da1f8b0 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1353616 1353786 170 0.0
RAM 104136 104136 0 0.0
bl702 lighting-app bl702+eth FLASH 651842 651960 118 0.0
RAM 25353 25353 0 0.0
bl702+wifi FLASH 829426 829548 122 0.0
RAM 14093 14093 0 0.0
bl706+mfd+rpc+littlefs FLASH 1057898 1058020 122 0.0
RAM 23933 23933 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 979272 979394 122 0.0
RAM 16596 16596 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 839828 839968 140 0.0
RAM 123672 123672 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 825368 825492 124 0.0
RAM 125560 125560 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 772244 772372 128 0.0
RAM 114036 114036 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 756440 756560 120 0.0
RAM 114236 114236 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 539753 539853 100 0.0
RAM 205776 205776 0 0.0
lock CC3235SF_LAUNCHXL FLASH 574033 574149 116 0.0
RAM 205920 205920 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 918036 918112 76 0.0
RAM 143308 143308 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 890460 890256 -204 -0.0
RAM 141495 141495 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 851924 851992 68 0.0
RAM 142220 142220 0 0.0
qpg lighting-app qpg6105+debug FLASH 664168 664288 120 0.0
RAM 105432 105432 0 0.0
lock-app qpg6105+debug FLASH 621964 622108 144 0.0
RAM 99884 99884 0 0.0
stm32 light STM32WB5MM-DK FLASH 484884 485004 120 0.0
RAM 144888 144888 0 0.0
tizen all-clusters-app arm unknown 4996 4996 0 0.0
FLASH 1734844 1734952 108 0.0
RAM 90784 90788 4 0.0
chip-tool-ubsan arm unknown 10804 10804 0 0.0
FLASH 17973406 17973686 280 0.0
RAM 7842608 7842724 116 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants