-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
binding: Add supports of self binding and enable multicast loop back by default #36855
base: master
Are you sure you want to change the base?
Conversation
PR #36855: Size comparison from cfdaf79 to cc67e7c Full report (3 builds for cc32xx, stm32)
|
PR #36855: Size comparison from cfdaf79 to b550103 Full report (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nxp, qpg, stm32, telink, tizen)
|
PR #36855: Size comparison from cfdaf79 to 80e107e Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wqx6 please add a Testing
section to your PR summary to describe how this change was tested.
Since I see no unit/integration test changes I assume this was "manual". We are trying to make manual more strict so that we do not have all PRs marked as "manual" for convenience, so please describe how you tested and also why automated testing is impossible for this.
PR #36855: Size comparison from cfdaf79 to 08403ce Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Reopen #21623
And enable multicast loopback by default to fix the follow scenario:
Light endpoint and Switch endpoint are on the same node and the two endpoints join the same group which is bound to the switch endpoint's binding cluster. When triggering the bound changed callback, the light endpoint cannot receive the multicast command.
Test
Test with light-switch example which adds an extra on-off light endpoint on endpoint 3.