Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple ember functions from general commissioning cluster #36836

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Decouple ember functions from general commissioning cluster #36836

wants to merge 4 commits into from
+101 −214

Conversation

yufengwangca
Copy link
Contributor

@yufengwangca yufengwangca commented Dec 13, 2024 •
edited
Loading

Decouple General Commissioning Cluster from ember and migrate to use CHI (CommandHandlerInterface) instead

Fix: #36757

Verified with manual pairing and CI

@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

PR #36836: Size comparison from 8ea6b8d to 41ef3ea

Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 8ea6b8d 41ef3ea change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1353340 1353664 324 0.0
RAM 104112 104128 16 0.0
bl702 lighting-app bl702+eth FLASH 651826 651718 -108 -0.0
RAM 25353 25353 0 0.0
bl702+wifi FLASH 829154 829270 116 0.0
RAM 14093 14093 0 0.0
bl706+mfd+rpc+littlefs FLASH 1057626 1057742 116 0.0
RAM 23933 23933 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 979000 979116 116 0.0
RAM 16596 16596 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 839760 840144 384 0.0
RAM 123664 123680 16 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 825308 825692 384 0.0
RAM 125552 125568 16 0.0
pump-app LP_EM_CC1354P10_6 FLASH 772096 772440 344 0.0
RAM 114020 114036 16 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 756284 756644 360 0.0
RAM 114228 114244 16 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 631050 631650 600 0.1
RAM 205824 205840 16 0.0
lock CC3235SF_LAUNCHXL FLASH 669646 670286 640 0.1
RAM 205968 205984 16 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 681505 681881 376 0.1
RAM 78724 78740 16 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 701349 701725 376 0.1
RAM 81364 81380 16 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 701349 701725 376 0.1
RAM 81364 81380 16 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 658293 658669 376 0.1
RAM 73792 73808 16 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 618065 618441 376 0.1
RAM 71708 71724 16 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 637693 638069 376 0.1
RAM 74252 74268 16 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 637693 638069 376 0.1
RAM 74252 74268 16 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 637465 637841 376 0.1
RAM 74724 74740 16 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 657173 657549 376 0.1
RAM 77268 77284 16 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 657173 657549 376 0.1
RAM 77268 77284 16 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 613925 614301 376 0.1
RAM 68812 68828 16 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 633777 634153 376 0.1
RAM 71444 71460 16 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 633777 634153 376 0.1
RAM 71444 71460 16 0.0
efr32 lock-app BRD4187C FLASH 932340 932388 48 0.0
RAM 160192 160208 16 0.0
BRD4338a FLASH 746144 746728 584 0.1
RAM 233320 233336 16 0.0
window-app BRD4187C FLASH 1024784 1025384 600 0.1
RAM 128296 128312 16 0.0
esp32 all-clusters-app c3devkit DRAM 95360 95376 16 0.0
FLASH 1543082 1543106 24 0.0
IRAM 82542 82542 0 0.0
m5stack DRAM 116312 116328 16 0.0
FLASH 1549682 1549798 116 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4720 4720 0 0.0
FLASH 2715063 2716121 1058 0.0
RAM 129800 129896 96 0.1
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 6007064 6008270 1206 0.0
RAM 523544 523640 96 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5344804 5346042 1238 0.0
RAM 242600 242696 96 0.0
bridge-app debug unknown 5440 5440 0 0.0
FLASH 4684372 4685578 1206 0.0
RAM 218416 218512 96 0.0
chip-tool debug unknown 5992 5992 0 0.0
FLASH 12847958 12847958 0 0.0
RAM 582474 582474 0 0.0
chip-tool-ipv6only arm64 unknown 21352 21352 0 0.0
FLASH 10982688 10982688 0 0.0
RAM 633392 633392 0 0.0
fabric-admin debug unknown 5816 5816 0 0.0
FLASH 11255293 11255293 0 0.0
RAM 582850 582850 0 0.0
fabric-bridge-app debug unknown 4696 4696 0 0.0
FLASH 4509948 4511030 1082 0.0
RAM 205600 205696 96 0.0
fabric-sync debug unknown 4936 4936 0 0.0
FLASH 5610053 5611141 1088 0.0
RAM 472584 472680 96 0.0
lighting-app debug+rpc+ui unknown 6104 6104 0 0.0
FLASH 5621073 5622305 1232 0.0
RAM 228792 228888 96 0.0
lock-app debug unknown 5376 5376 0 0.0
FLASH 4733612 4734850 1238 0.0
RAM 204776 204872 96 0.0
ota-provider-app debug unknown 4752 4752 0 0.0
FLASH 4359350 4360556 1206 0.0
RAM 198448 198544 96 0.0
ota-requestor-app debug unknown 4688 4688 0 0.0
FLASH 4498342 4499582 1240 0.0
RAM 203032 203128 96 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3030077 3031277 1200 0.0
RAM 160424 160520 96 0.1
thermostat-no-ble arm64 unknown 9536 9536 0 0.0
FLASH 4103472 4104624 1152 0.0
RAM 243040 243112 72 0.0
tv-app debug unknown 5704 5704 0 0.0
FLASH 5958901 5960101 1200 0.0
RAM 596016 596112 96 0.0
tv-casting-app debug unknown 5288 5288 0 0.0
FLASH 11054589 11055629 1040 0.0
RAM 692184 692312 128 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 917616 917636 20 0.0
RAM 143292 143308 16 0.0
nrf7002dk_nrf5340_cpuapp FLASH 890104 890240 136 0.0
RAM 141487 141503 16 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 851760 851784 24 0.0
RAM 142200 142216 16 0.0
nxp contact k32w0+release FLASH 585440 585400 -40 -0.0
RAM 71080 71096 16 0.0
mcxw71+release FLASH 600048 600280 232 0.0
RAM 63176 63192 16 0.0
light k32w0+release FLASH 612396 612388 -8 -0.0
RAM 70472 70488 16 0.0
k32w1+release FLASH 686576 687008 432 0.1
RAM 48808 48824 16 0.0
lock mcxw71+release FLASH 762928 763280 352 0.0
RAM 70844 70860 16 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646364 1646948 584 0.0
RAM 212104 212120 16 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1554108 1554732 624 0.0
RAM 208904 208920 16 0.0
light cy8ckit_062s2_43012 FLASH 1469436 1470020 584 0.0
RAM 200880 200896 16 0.0
lock cy8ckit_062s2_43012 FLASH 1467164 1467764 600 0.0
RAM 225240 225256 16 0.0
qpg lighting-app qpg6105+debug FLASH 664008 664064 56 0.0
RAM 105424 105440 16 0.0
lock-app qpg6105+debug FLASH 621796 621852 56 0.0
RAM 99868 99884 16 0.0
stm32 light STM32WB5MM-DK FLASH 484720 484768 48 0.0
RAM 144880 144896 16 0.0
telink bridge-app tlsr9258a FLASH 682920 682814 -106 -0.0
RAM 91208 91224 16 0.0
contact-sensor-app tlsr9528a_retention FLASH 623350 623240 -110 -0.0
RAM 31440 31456 16 0.1
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 772180 772112 -68 -0.0
RAM 49300 49316 16 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 710774 710668 -106 -0.0
RAM 73504 73520 16 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 627794 627682 -112 -0.0
RAM 142140 142156 16 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 813808 813696 -112 -0.0
RAM 99684 99700 16 0.0
tizen all-clusters-app arm unknown 4988 4988 0 0.0
FLASH 1732528 1733512 984 0.1
RAM 90744 90792 48 0.1
chip-tool-ubsan arm unknown 10804 10804 0 0.0
FLASH 17970638 17970638 0 0.0
RAM 7841352 7841352 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

PR #36836: Size comparison from 8ea6b8d to 7e9f238

Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 8ea6b8d 7e9f238 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1353340 1353672 332 0.0
RAM 104112 104128 16 0.0
bl702 lighting-app bl702+eth FLASH 651826 651726 -100 -0.0
RAM 25353 25353 0 0.0
bl702+wifi FLASH 829154 829278 124 0.0
RAM 14093 14093 0 0.0
bl706+mfd+rpc+littlefs FLASH 1057626 1057750 124 0.0
RAM 23933 23933 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 979000 979124 124 0.0
RAM 16596 16596 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 839760 840152 392 0.0
RAM 123664 123680 16 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 825308 825700 392 0.0
RAM 125552 125568 16 0.0
pump-app LP_EM_CC1354P10_6 FLASH 772096 772448 352 0.0
RAM 114020 114036 16 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 756284 756652 368 0.0
RAM 114228 114244 16 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 631050 539973 -91077 -14.4
RAM 205824 205776 -48 -0.0
lock CC3235SF_LAUNCHXL FLASH 669646 574261 -95385 -14.2
RAM 205968 205920 -48 -0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 681505 681881 376 0.1
RAM 78724 78740 16 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 701349 701725 376 0.1
RAM 81364 81380 16 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 701349 701725 376 0.1
RAM 81364 81380 16 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 658293 658669 376 0.1
RAM 73792 73808 16 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 618065 618449 384 0.1
RAM 71708 71724 16 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 637693 638077 384 0.1
RAM 74252 74268 16 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 637693 638077 384 0.1
RAM 74252 74268 16 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 637465 637849 384 0.1
RAM 74724 74740 16 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 657173 657557 384 0.1
RAM 77268 77284 16 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 657173 657557 384 0.1
RAM 77268 77284 16 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 613925 614309 384 0.1
RAM 68812 68828 16 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 633777 634161 384 0.1
RAM 71444 71460 16 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 633777 634161 384 0.1
RAM 71444 71460 16 0.0
efr32 lock-app BRD4187C FLASH 932340 932364 24 0.0
RAM 160192 160208 16 0.0
BRD4338a FLASH 746144 746864 720 0.1
RAM 233320 233336 16 0.0
window-app BRD4187C FLASH 1024784 1025536 752 0.1
RAM 128296 128312 16 0.0
esp32 all-clusters-app c3devkit DRAM 95360 95376 16 0.0
FLASH 1543082 1543098 16 0.0
IRAM 82542 82542 0 0.0
m5stack DRAM 116312 116328 16 0.0
FLASH 1549682 1549774 92 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4720 4720 0 0.0
FLASH 2715063 2716683 1620 0.1
RAM 129800 129896 96 0.1
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 6007064 6008830 1766 0.0
RAM 523544 523640 96 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5344804 5346570 1766 0.0
RAM 242600 242696 96 0.0
bridge-app debug unknown 5440 5440 0 0.0
FLASH 4684372 4686138 1766 0.0
RAM 218416 218512 96 0.0
chip-tool debug unknown 5992 5992 0 0.0
FLASH 12847958 12849310 1352 0.0
RAM 582474 582506 32 0.0
chip-tool-ipv6only arm64 unknown 21352 21352 0 0.0
FLASH 10982688 10983936 1248 0.0
RAM 633392 633424 32 0.0
fabric-admin debug unknown 5816 5816 0 0.0
FLASH 11255293 11255859 566 0.0
RAM 582850 582850 0 0.0
fabric-bridge-app debug unknown 4696 4696 0 0.0
FLASH 4509948 4511558 1610 0.0
RAM 205600 205696 96 0.0
fabric-sync debug unknown 4936 4936 0 0.0
FLASH 5610053 5611669 1616 0.0
RAM 472584 472680 96 0.0
lighting-app debug+rpc+ui unknown 6104 6104 0 0.0
FLASH 5621073 5622833 1760 0.0
RAM 228792 228888 96 0.0
lock-app debug unknown 5376 5376 0 0.0
FLASH 4733612 4735378 1766 0.0
RAM 204776 204872 96 0.0
ota-provider-app debug unknown 4752 4752 0 0.0
FLASH 4359350 4361116 1766 0.0
RAM 198448 198544 96 0.0
ota-requestor-app debug unknown 4688 4688 0 0.0
FLASH 4498342 4500110 1768 0.0
RAM 203032 203128 96 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3030077 3031837 1760 0.1
RAM 160424 160520 96 0.1
thermostat-no-ble arm64 unknown 9536 9536 0 0.0
FLASH 4103472 4105312 1840 0.0
RAM 243040 243112 72 0.0
tv-app debug unknown 5704 5704 0 0.0
FLASH 5958901 5960661 1760 0.0
RAM 596016 596112 96 0.0
tv-casting-app debug unknown 5288 5288 0 0.0
FLASH 11054589 11056189 1600 0.0
RAM 692184 692312 128 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 917616 917620 4 0.0
RAM 143292 143308 16 0.0
nrf7002dk_nrf5340_cpuapp FLASH 890104 890244 140 0.0
RAM 141487 141503 16 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 851760 851772 12 0.0
RAM 142200 142216 16 0.0
nxp contact k32w0+release FLASH 585440 585392 -48 -0.0
RAM 71080 71096 16 0.0
mcxw71+release FLASH 600048 600288 240 0.0
RAM 63176 63192 16 0.0
light k32w0+release FLASH 612396 612380 -16 -0.0
RAM 70472 70488 16 0.0
k32w1+release FLASH 686576 687016 440 0.1
RAM 48808 48824 16 0.0
lock mcxw71+release FLASH 762928 763288 360 0.0
RAM 70844 70860 16 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646364 1647068 704 0.0
RAM 212104 212120 16 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1554108 1554852 744 0.0
RAM 208904 208920 16 0.0
light cy8ckit_062s2_43012 FLASH 1469436 1470156 720 0.0
RAM 200880 200896 16 0.0
lock cy8ckit_062s2_43012 FLASH 1467164 1467900 736 0.1
RAM 225240 225256 16 0.0
qpg lighting-app qpg6105+debug FLASH 664008 664056 48 0.0
RAM 105424 105440 16 0.0
lock-app qpg6105+debug FLASH 621796 621844 48 0.0
RAM 99868 99884 16 0.0
stm32 light STM32WB5MM-DK FLASH 484720 484752 32 0.0
RAM 144880 144896 16 0.0
telink bridge-app tlsr9258a FLASH 682920 682798 -122 -0.0
RAM 91208 91224 16 0.0
contact-sensor-app tlsr9528a_retention FLASH 623350 623224 -126 -0.0
RAM 31440 31456 16 0.1
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 772180 772098 -82 -0.0
RAM 49300 49316 16 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 710774 710652 -122 -0.0
RAM 73504 73520 16 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 627794 627666 -128 -0.0
RAM 142140 142156 16 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 813808 813680 -128 -0.0
RAM 99684 99700 16 0.0
tizen all-clusters-app arm unknown 4988 4988 0 0.0
FLASH 1732528 1733928 1400 0.1
RAM 90744 90792 48 0.1
chip-tool-ubsan arm unknown 10804 10804 0 0.0
FLASH 17970638 17973406 2768 0.0
RAM 7841352 7842608 1256 0.0

tcarmelveilleux
tcarmelveilleux previously requested changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@tcarmelveilleux tcarmelveilleux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for #34065 to land to avoid conflicting it, since it's for 1.4.1

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 16, 2024 •
edited
Loading

PR #36836: Size comparison from 8ea6b8d to a16388d

Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 8ea6b8d a16388d change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1353340 1353672 332 0.0
RAM 104112 104128 16 0.0
bl702 lighting-app bl702+eth FLASH 651826 651726 -100 -0.0
RAM 25353 25353 0 0.0
bl702+wifi FLASH 829154 829278 124 0.0
RAM 14093 14093 0 0.0
bl706+mfd+rpc+littlefs FLASH 1057626 1057750 124 0.0
RAM 23933 23933 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 979000 979124 124 0.0
RAM 16596 16596 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 839760 840152 392 0.0
RAM 123664 123680 16 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 825308 825700 392 0.0
RAM 125552 125568 16 0.0
pump-app LP_EM_CC1354P10_6 FLASH 772096 772448 352 0.0
RAM 114020 114036 16 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 756284 756652 368 0.0
RAM 114228 114244 16 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 631050 539973 -91077 -14.4
RAM 205824 205776 -48 -0.0
lock CC3235SF_LAUNCHXL FLASH 669646 574261 -95385 -14.2
RAM 205968 205920 -48 -0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 681505 681881 376 0.1
RAM 78724 78740 16 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 701349 701725 376 0.1
RAM 81364 81380 16 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 701349 701725 376 0.1
RAM 81364 81380 16 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 658293 658669 376 0.1
RAM 73792 73808 16 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 618065 618449 384 0.1
RAM 71708 71724 16 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 637693 638077 384 0.1
RAM 74252 74268 16 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 637693 638077 384 0.1
RAM 74252 74268 16 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 637465 637849 384 0.1
RAM 74724 74740 16 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 657173 657557 384 0.1
RAM 77268 77284 16 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 657173 657557 384 0.1
RAM 77268 77284 16 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 613925 614309 384 0.1
RAM 68812 68828 16 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 633777 634161 384 0.1
RAM 71444 71460 16 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 633777 634161 384 0.1
RAM 71444 71460 16 0.0
efr32 lock-app BRD4187C FLASH 932340 932364 24 0.0
RAM 160192 160208 16 0.0
BRD4338a FLASH 746144 746864 720 0.1
RAM 233320 233336 16 0.0
window-app BRD4187C FLASH 1024784 1025536 752 0.1
RAM 128296 128312 16 0.0
esp32 all-clusters-app c3devkit DRAM 95360 95368 8 0.0
FLASH 1543082 1543304 222 0.0
IRAM 82542 82542 0 0.0
m5stack DRAM 116312 116320 8 0.0
FLASH 1549682 1549938 256 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4720 4720 0 0.0
FLASH 2715063 2716683 1620 0.1
RAM 129800 129896 96 0.1
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 6007064 6010030 2966 0.0
RAM 523544 523640 96 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5344804 5346570 1766 0.0
RAM 242600 242696 96 0.0
bridge-app debug unknown 5440 5440 0 0.0
FLASH 4684372 4686138 1766 0.0
RAM 218416 218512 96 0.0
chip-tool debug unknown 5992 5992 0 0.0
FLASH 12847958 12849310 1352 0.0
RAM 582474 582506 32 0.0
chip-tool-ipv6only arm64 unknown 21352 21352 0 0.0
FLASH 10982688 10983936 1248 0.0
RAM 633392 633424 32 0.0
fabric-admin debug unknown 5816 5816 0 0.0
FLASH 11255293 11255859 566 0.0
RAM 582850 582850 0 0.0
fabric-bridge-app debug unknown 4696 4696 0 0.0
FLASH 4509948 4511558 1610 0.0
RAM 205600 205696 96 0.0
fabric-sync debug unknown 4936 4936 0 0.0
FLASH 5610053 5611589 1536 0.0
RAM 472584 472680 96 0.0
lighting-app debug+rpc+ui unknown 6104 6104 0 0.0
FLASH 5621073 5622833 1760 0.0
RAM 228792 228888 96 0.0
lock-app debug unknown 5376 5376 0 0.0
FLASH 4733612 4735378 1766 0.0
RAM 204776 204872 96 0.0
ota-provider-app debug unknown 4752 4752 0 0.0
FLASH 4359350 4361116 1766 0.0
RAM 198448 198544 96 0.0
ota-requestor-app debug unknown 4688 4688 0 0.0
FLASH 4498342 4500110 1768 0.0
RAM 203032 203128 96 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3030077 3033949 3872 0.1
RAM 160424 160520 96 0.1
thermostat-no-ble arm64 unknown 9536 9536 0 0.0
FLASH 4103472 4105312 1840 0.0
RAM 243040 243112 72 0.0
tv-app debug unknown 5704 5704 0 0.0
FLASH 5958901 5960661 1760 0.0
RAM 596016 596112 96 0.0
tv-casting-app debug unknown 5288 5288 0 0.0
FLASH 11054589 11056189 1600 0.0
RAM 692184 692312 128 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 917616 917876 260 0.0
RAM 143292 143304 12 0.0
nrf7002dk_nrf5340_cpuapp FLASH 890104 890500 396 0.0
RAM 141487 141499 12 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 851760 851772 12 0.0
RAM 142200 142216 16 0.0
nxp contact k32w0+release FLASH 585440 585392 -48 -0.0
RAM 71080 71096 16 0.0
mcxw71+release FLASH 600048 600288 240 0.0
RAM 63176 63192 16 0.0
light k32w0+release FLASH 612396 612380 -16 -0.0
RAM 70472 70488 16 0.0
k32w1+release FLASH 686576 687016 440 0.1
RAM 48808 48824 16 0.0
lock mcxw71+release FLASH 762928 763288 360 0.0
RAM 70844 70860 16 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646364 1647404 1040 0.1
RAM 212104 212112 8 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1554108 1554852 744 0.0
RAM 208904 208920 16 0.0
light cy8ckit_062s2_43012 FLASH 1469436 1470156 720 0.0
RAM 200880 200896 16 0.0
lock cy8ckit_062s2_43012 FLASH 1467164 1467900 736 0.1
RAM 225240 225256 16 0.0
qpg lighting-app qpg6105+debug FLASH 664008 664056 48 0.0
RAM 105424 105440 16 0.0
lock-app qpg6105+debug FLASH 621796 621844 48 0.0
RAM 99868 99884 16 0.0
stm32 light STM32WB5MM-DK FLASH 484720 484752 32 0.0
RAM 144880 144896 16 0.0
telink bridge-app tlsr9258a FLASH 682920 682798 -122 -0.0
RAM 91208 91224 16 0.0
contact-sensor-app tlsr9528a_retention FLASH 623350 623224 -126 -0.0
RAM 31440 31456 16 0.1
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 772180 772098 -82 -0.0
RAM 49300 49316 16 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 710774 710652 -122 -0.0
RAM 73504 73520 16 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 627794 627666 -128 -0.0
RAM 142140 142156 16 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 813808 813680 -128 -0.0
RAM 99684 99700 16 0.0
tizen all-clusters-app arm unknown 4988 4988 0 0.0
FLASH 1732528 1735416 2888 0.2
RAM 90744 90784 40 0.0
chip-tool-ubsan arm unknown 10804 10804 0 0.0
FLASH 17970638 17973406 2768 0.0
RAM 7841352 7842608 1256 0.0

@andy31415 andy31415 dismissed tcarmelveilleux’s stale review December 17, 2024 14:15

Other PR has been merged, we can update this PR now.

@mergify mergify bot added the conflict label Dec 17, 2024
@mergify mergify bot removed the conflict label Dec 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 17, 2024 •
edited
Loading

PR #36836: Size comparison from 4ae6882 to e16195e

Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 4ae6882 e16195e change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1353616 1354232 616 0.0
RAM 104136 104152 16 0.0
bl702 lighting-app bl702+eth FLASH 651842 652212 370 0.1
RAM 25353 25353 0 0.0
bl702+wifi FLASH 829426 829768 342 0.0
RAM 14093 14093 0 0.0
bl706+mfd+rpc+littlefs FLASH 1057898 1058240 342 0.0
RAM 23933 23933 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 979272 979358 86 0.0
RAM 16596 16596 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 839836 840552 716 0.1
RAM 123672 123688 16 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 825368 826092 724 0.1
RAM 125560 125576 16 0.0
pump-app LP_EM_CC1354P10_6 FLASH 772244 772908 664 0.1
RAM 114036 114052 16 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 756440 757104 664 0.1
RAM 114236 114252 16 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 539753 540445 692 0.1
RAM 205776 205792 16 0.0
lock CC3235SF_LAUNCHXL FLASH 574033 574765 732 0.1
RAM 205920 205936 16 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 681681 682329 648 0.1
RAM 78732 78748 16 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 701525 702173 648 0.1
RAM 81372 81388 16 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 701525 702173 648 0.1
RAM 81372 81388 16 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 658469 659109 640 0.1
RAM 73800 73816 16 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 618217 618945 728 0.1
RAM 71724 71740 16 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 637853 638573 720 0.1
RAM 74268 74284 16 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 637853 638573 720 0.1
RAM 74268 74284 16 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 637625 638345 720 0.1
RAM 74732 74748 16 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 657341 658061 720 0.1
RAM 77276 77292 16 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 657341 658061 720 0.1
RAM 77276 77292 16 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614085 614805 720 0.1
RAM 68820 68836 16 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 633945 634657 712 0.1
RAM 71452 71468 16 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 633945 634657 712 0.1
RAM 71452 71468 16 0.0
efr32 lock-app BRD4187C FLASH 932492 932772 280 0.0
RAM 160204 160220 16 0.0
BRD4338a FLASH 746472 747456 984 0.1
RAM 233332 233348 16 0.0
window-app BRD4187C FLASH 1025128 1026112 984 0.1
RAM 128308 128324 16 0.0
esp32 all-clusters-app c3devkit DRAM 95376 95392 16 0.0
FLASH 1543446 1543768 322 0.0
IRAM 82542 82542 0 0.0
m5stack DRAM 116320 116336 16 0.0
FLASH 1550038 1550394 356 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4720 4720 0 0.0
FLASH 2716107 2718499 2392 0.1
RAM 129896 130024 128 0.1
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 6009416 6013622 4206 0.1
RAM 523640 523736 96 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5345924 5350098 4174 0.1
RAM 242696 242824 128 0.1
bridge-app debug unknown 5440 5440 0 0.0
FLASH 4685460 4689666 4206 0.1
RAM 218512 218624 112 0.1
chip-tool debug unknown 5992 5992 0 0.0
FLASH 12849310 12849428 118 0.0
RAM 582506 582506 0 0.0
chip-tool-ipv6only arm64 unknown 21352 21352 0 0.0
FLASH 10983936 10984032 96 0.0
RAM 633424 633432 8 0.0
fabric-admin debug unknown 5816 5816 0 0.0
FLASH 11255859 11255977 118 0.0
RAM 582850 582850 0 0.0
fabric-bridge-app debug unknown 4696 4696 0 0.0
FLASH 4510992 4515042 4050 0.1
RAM 205696 205792 96 0.0
fabric-sync debug unknown 4936 4936 0 0.0
FLASH 5611061 5615077 4016 0.1
RAM 472680 472792 112 0.0
lighting-app debug+rpc+ui unknown 6104 6104 0 0.0
FLASH 5622193 5626369 4176 0.1
RAM 228888 228984 96 0.0
lock-app debug unknown 5376 5376 0 0.0
FLASH 4734732 4738906 4174 0.1
RAM 204872 204968 96 0.0
ota-provider-app debug unknown 4752 4752 0 0.0
FLASH 4360438 4364612 4174 0.1
RAM 198544 198656 112 0.1
ota-requestor-app debug unknown 4688 4688 0 0.0
FLASH 4499462 4503638 4176 0.1
RAM 203128 203240 112 0.1
shell debug unknown 4248 4248 0 0.0
FLASH 3033341 3035869 2528 0.1
RAM 160520 160648 128 0.1
thermostat-no-ble arm64 unknown 9552 9552 0 0.0
FLASH 4104720 4107968 3248 0.1
RAM 243160 243264 104 0.0
tv-app debug unknown 5704 5704 0 0.0
FLASH 5959989 5964213 4224 0.1
RAM 596112 596224 112 0.0
tv-casting-app debug unknown 5288 5288 0 0.0
FLASH 11055693 11059725 4032 0.0
RAM 692328 692456 128 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 918052 918232 180 0.0
RAM 143308 143324 16 0.0
nrf7002dk_nrf5340_cpuapp FLASH 890476 890560 84 0.0
RAM 141495 141511 16 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 851932 852044 112 0.0
RAM 142220 142236 16 0.0
nxp contact k32w0+release FLASH 585472 585704 232 0.0
RAM 71088 71104 16 0.0
mcxw71+release FLASH 600184 600776 592 0.1
RAM 63184 63200 16 0.0
light k32w0+release FLASH 612476 612628 152 0.0
RAM 70480 70496 16 0.0
k32w1+release FLASH 686736 687424 688 0.1
RAM 48816 48832 16 0.0
lock mcxw71+release FLASH 763072 763768 696 0.1
RAM 70852 70868 16 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1647012 1648004 992 0.1
RAM 212104 212120 16 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1554444 1555452 1008 0.1
RAM 208920 208936 16 0.0
light cy8ckit_062s2_43012 FLASH 1469772 1470740 968 0.1
RAM 200888 200904 16 0.0
lock cy8ckit_062s2_43012 FLASH 1467492 1468476 984 0.1
RAM 225248 225264 16 0.0
qpg lighting-app qpg6105+debug FLASH 664168 664440 272 0.0
RAM 105432 105448 16 0.0
lock-app qpg6105+debug FLASH 621964 622260 296 0.0
RAM 99884 99900 16 0.0
stm32 light STM32WB5MM-DK FLASH 484892 485156 264 0.1
RAM 144888 144904 16 0.0
telink bridge-app tlsr9258a FLASH 683080 683246 166 0.0
RAM 91224 91240 16 0.0
contact-sensor-app tlsr9528a_retention FLASH 623494 623656 162 0.0
RAM 31456 31472 16 0.1
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 772312 772518 206 0.0
RAM 49316 49332 16 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 710934 711100 166 0.0
RAM 73520 73536 16 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 627950 628110 160 0.0
RAM 142156 142172 16 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 813968 814128 160 0.0
RAM 99700 99716 16 0.0
tizen all-clusters-app arm unknown 4996 4996 0 0.0
FLASH 1734868 1736608 1740 0.1
RAM 90784 90836 52 0.1
chip-tool-ubsan arm unknown 10804 10804 0 0.0
FLASH 17973406 17973686 280 0.0
RAM 7842608 7842724 116 0.0

bzbarsky-apple
bzbarsky-apple reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this expected to lead to several hundred bytes of Flash increase on constrained platforms? If not, what can we do to reduce that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple requested changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
app review - pending scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cluster Decoupling: general-commissioning-server
3 participants
@yufengwangca @tcarmelveilleux @bzbarsky-apple