Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If an XPC client doesn't care about a nodeID (hasn't made it), don't create one #36586

Merged
merged 2 commits into from
Nov 21, 2024
Merged

If an XPC client doesn't care about a nodeID (hasn't made it), don't create one #36586

merged 2 commits into from
Nov 21, 2024
+9 −3

Conversation

woody-apple
Copy link
Contributor

If we create an MTRDevice here, it immediately will dealloc, which will cause a loop of registrations.

@woody-apple woody-apple requested a review from a team as a code owner November 21, 2024 05:57
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

PR #36586: Size comparison from 334b1d9 to af5acb8

Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 334b1d9 af5acb8 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1350314 1350314 0 0.0
RAM 104088 104088 0 0.0
bl702 lighting-app bl702+eth FLASH 649926 649926 0 0.0
RAM 25329 25329 0 0.0
bl702+wifi FLASH 827254 827254 0 0.0
RAM 14069 14069 0 0.0
bl706+mfd+rpc+littlefs FLASH 1055448 1055448 0 0.0
RAM 23917 23917 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 977078 977078 0 0.0
RAM 16556 16556 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 838240 838240 0 0.0
RAM 123640 123640 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 824180 824180 0 0.0
RAM 125520 125520 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770888 770888 0 0.0
RAM 113988 113988 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755092 755092 0 0.0
RAM 114204 114204 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 629294 629294 0 0.0
RAM 205792 205792 0 0.0
lock CC3235SF_LAUNCHXL FLASH 667874 667874 0 0.0
RAM 205936 205936 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679857 679857 0 0.0
RAM 78692 78692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699709 699709 0 0.0
RAM 81332 81332 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699709 699709 0 0.0
RAM 81332 81332 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656637 656637 0 0.0
RAM 73760 73760 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616721 616721 0 0.0
RAM 71652 71652 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 636357 636357 0 0.0
RAM 74196 74196 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 636357 636357 0 0.0
RAM 74196 74196 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 636185 636185 0 0.0
RAM 74700 74700 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655901 655901 0 0.0
RAM 77244 77244 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655901 655901 0 0.0
RAM 77244 77244 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 612677 612677 0 0.0
RAM 68780 68780 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 632529 632529 0 0.0
RAM 71420 71420 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 632529 632529 0 0.0
RAM 71420 71420 0 0.0
efr32 lock-app BRD4187C FLASH 927948 927948 0 0.0
RAM 160168 160168 0 0.0
BRD4338a FLASH 744312 744304 -8 -0.0
RAM 233296 233296 0 0.0
window-app BRD4187C FLASH 1019432 1019424 -8 -0.0
RAM 128268 128268 0 0.0
esp32 all-clusters-app c3devkit DRAM 95344 95344 0 0.0
FLASH 1541622 1541622 0 0.0
IRAM 82542 82542 0 0.0
m5stack DRAM 116256 116256 0 0.0
FLASH 1548702 1548702 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4712 4712 0 0.0
FLASH 2706449 2706449 0 0.0
RAM 129736 129736 0 0.0
all-clusters-app debug unknown 5552 5552 0 0.0
FLASH 5997550 5997550 0 0.0
RAM 523464 523464 0 0.0
all-clusters-minimal-app debug unknown 5448 5448 0 0.0
FLASH 5335804 5335804 0 0.0
RAM 242520 242520 0 0.0
bridge-app debug unknown 5432 5432 0 0.0
FLASH 4675522 4675522 0 0.0
RAM 218464 218464 0 0.0
chip-tool debug unknown 5984 5984 0 0.0
FLASH 12834316 12834316 0 0.0
RAM 582226 582226 0 0.0
chip-tool-ipv6only arm64 unknown 21304 21304 0 0.0
FLASH 10969472 10969472 0 0.0
RAM 633160 633160 0 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11243259 11243259 0 0.0
RAM 582610 582610 0 0.0
fabric-bridge-app debug unknown 4688 4688 0 0.0
FLASH 4499792 4499792 0 0.0
RAM 205424 205424 0 0.0
fabric-sync debug unknown 4896 4896 0 0.0
FLASH 5596357 5596357 0 0.0
RAM 472424 472424 0 0.0
lighting-app debug+rpc+ui unknown 6096 6096 0 0.0
FLASH 5611473 5611473 0 0.0
RAM 228616 228616 0 0.0
lock-app debug unknown 5368 5368 0 0.0
FLASH 4724878 4724878 0 0.0
RAM 204632 204632 0 0.0
ota-provider-app debug unknown 4744 4744 0 0.0
FLASH 4350396 4350396 0 0.0
RAM 198304 198304 0 0.0
ota-requestor-app debug unknown 4680 4680 0 0.0
FLASH 4488830 4488830 0 0.0
RAM 202888 202888 0 0.0
shell debug unknown 4240 4240 0 0.0
FLASH 3020717 3020717 0 0.0
RAM 160368 160368 0 0.0
thermostat-no-ble arm64 unknown 9512 9512 0 0.0
FLASH 4096272 4096272 0 0.0
RAM 243008 243008 0 0.0
tv-app debug unknown 5664 5664 0 0.0
FLASH 5948069 5948069 0 0.0
RAM 595952 595952 0 0.0
tv-casting-app debug unknown 5232 5232 0 0.0
FLASH 11040237 11040237 0 0.0
RAM 691960 691960 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 916244 916244 0 0.0
RAM 143292 143292 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 888432 888432 0 0.0
RAM 141479 141479 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 850444 850444 0 0.0
RAM 142200 142200 0 0.0
nxp contact k32w0+release FLASH 584344 584344 0 0.0
RAM 71056 71056 0 0.0
mcxw71+release FLASH 598872 598872 0 0.0
RAM 63152 63152 0 0.0
light k32w0+release FLASH 611284 611284 0 0.0
RAM 70448 70448 0 0.0
k32w1+release FLASH 685384 685384 0 0.0
RAM 48776 48776 0 0.0
lock mcxw71+release FLASH 748896 748896 0 0.0
RAM 67308 67308 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1644236 1644236 0 0.0
RAM 212072 212072 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1552212 1552212 0 0.0
RAM 208872 208872 0 0.0
light cy8ckit_062s2_43012 FLASH 1467252 1467252 0 0.0
RAM 200856 200856 0 0.0
lock cy8ckit_062s2_43012 FLASH 1465428 1465428 0 0.0
RAM 225216 225216 0 0.0
qpg lighting-app qpg6105+debug FLASH 662520 662520 0 0.0
RAM 105384 105384 0 0.0
lock-app qpg6105+debug FLASH 620628 620628 0 0.0
RAM 99844 99844 0 0.0
stm32 light STM32WB5MM-DK FLASH 483332 483332 0 0.0
RAM 144848 144848 0 0.0
telink bridge-app tlsr9258a FLASH 681594 681594 0 0.0
RAM 91200 91200 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622030 622030 0 0.0
RAM 31432 31432 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 762886 762886 0 0.0
RAM 50208 50208 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709164 709164 0 0.0
RAM 73460 73460 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625872 625872 0 0.0
RAM 142132 142132 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811780 811780 0 0.0
RAM 99676 99676 0 0.0
tizen all-clusters-app arm unknown 4972 4972 0 0.0
FLASH 1726800 1726800 0 0.0
RAM 90652 90652 0 0.0
chip-tool-ubsan arm unknown 10780 10780 0 0.0
FLASH 17946894 17946894 0 0.0
RAM 7830432 7830432 0 0.0

@woody-apple
Copy link
Contributor Author

Verbal approval, force merging given urgency here and Darwin tests passed.

@woody-apple woody-apple merged commit 709841e into project-chip:master Nov 21, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
darwin fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woody-apple @restyled-commits