[Fabric-Sync] Implement pair-device command #36508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
yufengwangca
changed the title
|
PR #36508: Size comparison from 1bdcb74 to 3888c77 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pidarped
reviewed
Nov 15, 2024
tehampson
reviewed
Nov 15, 2024
tehampson
reviewed
Nov 18, 2024
Co-authored-by: Terence Hampson <[email protected]>
|
PR #36508: Size comparison from 1bdcb74 to 6d60c4a Increases above 0.2%:
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tehampson
approved these changes
Nov 19, 2024
pidarped
approved these changes
Nov 19, 2024
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Nov 25, 2024
* [Fabric-Sync] Port pair-device command from fabric-admin * Update examples/fabric-sync/shell/ShellCommands.cpp Co-authored-by: Terence Hampson <[email protected]> --------- Co-authored-by: Terence Hampson <[email protected]>
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* [Fabric-Sync] Port pair-device command from fabric-admin * Update examples/fabric-sync/shell/ShellCommands.cpp Co-authored-by: Terence Hampson <[email protected]> --------- Co-authored-by: Terence Hampson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have 'pairing onnetwork' command in fabric-sync since it is not inherited from chip-tool, basically we need to implement all commands we need to do fabric-sync.
This command allow to pair a simulated matter device started on the same machine, then we don't need to use a separate matter device to test fabric-sync, just like what we did in the cert test.