[Chef] Add heat pump device type #36457
Merged
+7,148
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
|
PR #36457: Size comparison from 882b76e to a24e0d0 Full report (3 builds for cc32xx, stm32)
|
Add new lines
|
PR #36457: Size comparison from 882b76e to cf9db78 Full report (3 builds for cc32xx, stm32)
|
Add new lines
|
PR #36457: Size comparison from 882b76e to 20331c0 Full report (24 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink, tizen)
|
PowerSource Feature = WIRED
|
PR #36457: Size comparison from 882b76e to 5910c24 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Add Device Energy Management in EP1
cluster DiagnosticLogs
|
PR #36457: Size comparison from dfd3749 to ba0f9d9 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36457: Size comparison from 2c11741 to 031a109 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Dec 13, 2024
There was a problem hiding this comment.
@lboue please add a Testing section that describes how this was tested. This seems to realistically be "manual" since you described how you built and started the app. We are trying to make the manual testing bar somewhat higher to avoid all PRs being marked manual as a convenience. So we need:
- justification why automated testing is impossible (I would put here that we have many chef examples and building them all is impractical time-wise so we cannot automatically test chef in github CI)
- description of what tests/commands you ran to prove that this new device you added works as a spec-compliand heat pump. Does it pass Device conformance tests? Did you run manual read/writes/invokes on it?
|
PR #36457: Size comparison from 4e44586 to e227f39 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Dec 17, 2024
|
@lboue for future tests of chef devies, it would be useful if we could also verify device conformance on them as part of testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
[Chef] Add heat pump device type.
Specification
This refers to the specification file
24-27351-005_Matter-1.4-Device-Library-Specification.pdfpage 161device_type data_model: HeatPump.xml
Testing
Build
Start
Read temperature value on EP2 (Temperature Sensor)
Read temperature value on EP3 (Temperature Sensor)