[ameba] Ameba SNTP and observer support #36382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pankore
commented
Nov 6, 2024
pankore
commented
- SNTP Support for src/platform/Ameba/SystemTimeSupport.cpp
- Add Ameba Observer for air-purifier-app, all-clusters-minimal-app, chef-app, light-switch-app, lighting-app, and ota-requestor-app examples
|
Review changes with |
|
PR #36382: Size comparison from 2a7106f to 35c0cca Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
Waiting #36383 to be merged first |
|
PR #36382: Size comparison from e338404 to c6dc883 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pankore
force-pushed
the
ameba-sntp-and-observer
branch
from
c6dc883
to
fc46445
Compare
|
PR #36382: Size comparison from e338404 to fc46445 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36382: Size comparison from e338404 to 6f622f7 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pankore
force-pushed
the
ameba-sntp-and-observer
branch
from
6f622f7
to
565109a
Compare
|
PR #36382: Size comparison from 5ace630 to 565109a Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Nov 11, 2024
pankore
force-pushed
the
ameba-sntp-and-observer
branch
from
565109a
to
53756b1
Compare
|
PR #36382: Size comparison from 6848d04 to 53756b1 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Nov 13, 2024
andy31415
reviewed
Nov 13, 2024
andy31415
reviewed
Nov 13, 2024
…un restyle-diff.sh
…d updated Ameba cmake
…NABLE_AMEBA_SNTP == 1) to #if CONFIG_ENABLE_AMEBA_SNTP
pankore
force-pushed
the
ameba-sntp-and-observer
branch
from
7f79f79
to
d8edc52
Compare
|
PR #36382: Size comparison from 39e83c9 to d8edc52 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36382: Size comparison from 61121b8 to a42cca9 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Nov 25, 2024
* [ameba] Support Time Syncronization Using SNTP * [ameba] Synchronize RTC with SNTP * [ameba] Add CONFIG_ENABLE_AMEBA_SNTP to config/ameba/chip.cmake and run restyle-diff.sh * [ameba] Add Ameba Observer for Ameba Examples * [Ameba] Fix build with all-clusters-minimal-app and SystemTimeSupport.cpp * [Ameba] Update Docker Version to 91 * [Ameba] moved AmebaObserver.h to examples/platform/ameba/observer/ and updated Ameba cmake * [Ameba] simplified #if defined(CONFIG_ENABLE_AMEBA_SNTP) && (CONFIG_ENABLE_AMEBA_SNTP == 1) to #if CONFIG_ENABLE_AMEBA_SNTP --------- Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.