Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move concurrentSubscriptionPool property to MTRDeviceController_Concrete. #36328

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Move concurrentSubscriptionPool property to MTRDeviceController_Concrete. #36328

merged 1 commit into from
Oct 31, 2024

Conversation

bzbarsky-apple
Copy link
Contributor

The non-concrete case does not directly create subscriptions, so has no need of a pool for them.

@bzbarsky-apple
Move concurrentSubscriptionPool property to MTRDeviceController_Concr…
e6e9fad 
…ete.

The non-concrete case does not directly create subscriptions, so has no need of
a pool for them.
@bzbarsky-apple bzbarsky-apple requested a review from a team as a code owner October 31, 2024 20:58
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@bzbarsky-apple
Copy link
Contributor Author

Fast-tracking platform-specific fix with platform owner review.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 31, 2024 •
edited
Loading

PR #36328: Size comparison from d93f3f6 to e6e9fad

Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section d93f3f6 e6e9fad change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1351454 1351454 0 0.0
RAM 104080 104080 0 0.0
bl702 lighting-app bl702+eth FLASH 649058 649058 0 0.0
RAM 25321 25321 0 0.0
bl702+wifi FLASH 826638 826638 0 0.0
RAM 14053 14053 0 0.0
bl706+mfd+rpc+littlefs FLASH 1056298 1056298 0 0.0
RAM 23901 23901 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 976464 976464 0 0.0
RAM 16556 16556 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 837924 837924 0 0.0
RAM 123628 123628 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823696 823696 0 0.0
RAM 125516 125516 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770436 770436 0 0.0
RAM 113984 113984 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 754640 754640 0 0.0
RAM 114192 114192 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 627382 627382 0 0.0
RAM 205780 205780 0 0.0
lock CC3235SF_LAUNCHXL FLASH 667126 667126 0 0.0
RAM 205932 205932 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679585 679585 0 0.0
RAM 78684 78684 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699437 699437 0 0.0
RAM 81324 81324 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699437 699437 0 0.0
RAM 81324 81324 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656373 656373 0 0.0
RAM 73752 73752 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616289 616289 0 0.0
RAM 71644 71644 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635917 635917 0 0.0
RAM 74188 74188 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635917 635917 0 0.0
RAM 74188 74188 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635753 635753 0 0.0
RAM 74692 74692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655469 655469 0 0.0
RAM 77236 77236 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655469 655469 0 0.0
RAM 77236 77236 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611157 611157 0 0.0
RAM 68772 68772 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631009 631009 0 0.0
RAM 71412 71412 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631009 631009 0 0.0
RAM 71412 71412 0 0.0
efr32 lock-app BRD4187C FLASH 928556 928556 0 0.0
RAM 160164 160164 0 0.0
BRD4338a FLASH 743288 743288 0 0.0
RAM 233272 233272 0 0.0
window-app BRD4187C FLASH 1018552 1018552 0 0.0
RAM 128260 128260 0 0.0
esp32 all-clusters-app c3devkit DRAM 95328 95328 0 0.0
FLASH 1539912 1539912 0 0.0
IRAM 82542 82542 0 0.0
m5stack DRAM 116256 116256 0 0.0
FLASH 1549102 1549102 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2730639 2730639 0 0.0
RAM 129616 129616 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6018748 6018748 0 0.0
RAM 523872 523872 0 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5355990 5355990 0 0.0
RAM 242448 242448 0 0.0
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4699494 4699494 0 0.0
RAM 218400 218400 0 0.0
chip-tool debug unknown 5960 5960 0 0.0
FLASH 12900268 12900268 0 0.0
RAM 584466 584466 0 0.0
chip-tool-ipv6only arm64 unknown 21416 21416 0 0.0
FLASH 11028352 11028352 0 0.0
RAM 635400 635400 0 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 11307799 11307799 0 0.0
RAM 584922 584922 0 0.0
fabric-bridge-app debug unknown 4632 4632 0 0.0
FLASH 4526546 4526546 0 0.0
RAM 205368 205368 0 0.0
fabric-sync debug unknown 4840 4840 0 0.0
FLASH 5238645 5238645 0 0.0
RAM 465432 465432 0 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5636353 5636353 0 0.0
RAM 228520 228520 0 0.0
lock-app debug unknown 5344 5344 0 0.0
FLASH 4747914 4747914 0 0.0
RAM 204520 204520 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4374674 4374674 0 0.0
RAM 198240 198240 0 0.0
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4512914 4512914 0 0.0
RAM 202808 202808 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3046061 3046061 0 0.0
RAM 160336 160336 0 0.0
thermostat-no-ble arm64 unknown 9456 9456 0 0.0
FLASH 4116152 4116152 0 0.0
RAM 242936 242936 0 0.0
tv-app debug unknown 5624 5624 0 0.0
FLASH 5970933 5970933 0 0.0
RAM 596304 596304 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 11107629 11107629 0 0.0
RAM 694552 694552 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914996 914996 0 0.0
RAM 143281 143281 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 887572 887572 0 0.0
RAM 141468 141468 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 849060 849060 0 0.0
RAM 142189 142189 0 0.0
nxp contact k32w0+release FLASH 584112 584112 0 0.0
RAM 71044 71044 0 0.0
mcxw71+release FLASH 598648 598648 0 0.0
RAM 63144 63144 0 0.0
light k32w0+release FLASH 611156 611156 0 0.0
RAM 70436 70436 0 0.0
k32w1+release FLASH 684944 684944 0 0.0
RAM 48776 48776 0 0.0
lock mcxw71+release FLASH 748480 748480 0 0.0
RAM 67300 67300 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1642828 1642828 0 0.0
RAM 212056 212056 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1550356 1550356 0 0.0
RAM 208856 208856 0 0.0
light cy8ckit_062s2_43012 FLASH 1466956 1466956 0 0.0
RAM 200840 200840 0 0.0
lock cy8ckit_062s2_43012 FLASH 1464684 1464684 0 0.0
RAM 225200 225200 0 0.0
qpg lighting-app qpg6105+debug FLASH 662232 662232 0 0.0
RAM 105380 105380 0 0.0
lock-app qpg6105+debug FLASH 620196 620196 0 0.0
RAM 99832 99832 0 0.0
stm32 light STM32WB5MM-DK FLASH 483056 483056 0 0.0
RAM 144844 144844 0 0.0
telink bridge-app tlsr9258a FLASH 684252 684252 0 0.0
RAM 91528 91528 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622362 622362 0 0.0
RAM 50464 50464 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 710278 710278 0 0.0
RAM 73804 73804 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 628468 628468 0 0.0
RAM 145384 145384 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 814816 814816 0 0.0
RAM 100004 100004 0 0.0
tizen all-clusters-app arm unknown 4932 4932 0 0.0
FLASH 1721588 1721588 0 0.0
RAM 90608 90608 0 0.0
chip-tool-ubsan arm unknown 10820 10820 0 0.0
FLASH 18006486 18006486 0 0.0
RAM 7857312 7857312 0 0.0

@mergify mergify bot merged commit e5ae065 into project-chip:master Oct 31, 2024
67 checks passed
@bzbarsky-apple bzbarsky-apple deleted the controller-move-subscription-queue branch November 1, 2024 00:10
yyzhong-g pushed a commit to yyzhong-g/connectedhomeip that referenced this pull request Dec 12, 2024
@bzbarsky-apple @yyzhong-g
Move concurrentSubscriptionPool property to MTRDeviceController_Concr…
7734b8a 
…ete. (project-chip#36328)

The non-concrete case does not directly create subscriptions, so has no need of
a pool for them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtung-apple jtung-apple jtung-apple approved these changes

Assignees
No one assigned
Labels
darwin fast track
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bzbarsky-apple @jtung-apple