Remove one more direct ember coupling in reporting engine (using of CheckEventSupportStatus from ember-compatibility) #35873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
PR #35873: Size comparison from 20200ee to dc0b8d1 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tehampson
approved these changes
Oct 2, 2024
tcarmelveilleux
approved these changes
Oct 2, 2024
…fault implementation
|
PR #35873: Size comparison from 20200ee to 38503f6 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35873: Size comparison from cbacbe3 to 9d38425 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35873: Size comparison from c565622 to b29bc7f Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
arkq
approved these changes
Oct 3, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…heckEventSupportStatus from ember-compatibility) (project-chip#35873) * Update event support checks * Fix an include * Restyled by clang-format * Fix typo * Restyled by clang-format * Added a EndpointExists call to the datamodel provider along with a default implementation * Remove missing config use after merge with master * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Reporting engine use datamodel::provider to determine if a event path is valid or not. I named it 'path valid' since event support status should go away in large part once we fully remove the event list attribute support from our source code.
Note
#35874 is a PR to remove eventlist support completely from the server side
(client-side we still code-generate and we may need to iterate on that). As a result, this
PR does not handle event list attribute iteration in the implementation.