Don't hardcode TBRM endpoint number in TC-TBRM-2.4 #35784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
github-actions
bot
added
app
tests
matter-1.4-te2-script-change
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91 and
fessehaeve
pullapprove
bot
requested review from
vivien-apple,
tima-q,
wiba-nordic,
tobiasgraf,
woody-apple,
turon,
younghak-hwang and
yufengwangca
|
PR #35784: Size comparison from 90b0fd2 to dab1efb Full report (3 builds for cc32xx, stm32)
|
ksperling-apple
force-pushed
the
tc-35726
branch
from
dab1efb to
c7153e3
Compare
|
PR #35784: Size comparison from 90b0fd2 to c7153e3 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
marchemi
approved these changes
Sep 26, 2024
Prefix Ecm-related test constants to avoid potential conflict with 'payload' test parameter. Use a setup payload that does not have a vendor ID baked in, and use a passcode and discriminator that differ from the default values for good measure.
ksperling-apple
force-pushed
the
tc-35726
branch
from
d929b20 to
902ce8d
Compare
|
PR #35784: Size comparison from 90b0fd2 to 902ce8d Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
arkq
approved these changes
Sep 26, 2024
andy31415
approved these changes
Sep 26, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* Don't hardcode TBRM endpoint number in TC-TBRM-2.4 Fixes project-chip#35726 * Fix Open Commissioning Window parameters Prefix Ecm-related test constants to avoid potential conflict with 'payload' test parameter. Use a setup payload that does not have a vendor ID baked in, and use a passcode and discriminator that differ from the default values for good measure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35726