Use LambdaBridge to safely invoke functions in GLib Matter context #35777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
Alami-Amine
force-pushed
the
AA/LambdaBridgeGLib
branch
from
bbdad4b to
0ba09e4
Compare
|
PR #35777: Size comparison from 6f93ec2 to 09e28f5 Full report (13 builds for cc13x4_26x4, cc32xx, nrfconnect, nxp, stm32)
|
andy31415
reviewed
Sep 25, 2024
|
PR #35777: Size comparison from e8554de to 38d3ed7 Increases above 0.2%:
Full report (45 builds for cyw30739, efr32, esp32, linux, nxp, psoc6, stm32)
|
Alami-Amine
force-pushed
the
AA/LambdaBridgeGLib
branch
from
6437a59 to
af70f8a
Compare
|
PR #35777: Size comparison from 648f088 to af70f8a Increases above 0.2%:
Full report (86 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Alami-Amine
changed the title
|
PR #35777: Size comparison from 648f088 to 4601183 Full report (47 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, nrfconnect, nxp, psoc6, qpg, stm32)
|
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan and
bzbarsky-apple
pullapprove
bot
requested review from
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #35777: Size comparison from 648f088 to db933d5 Increases above 0.2%:
Full report (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, nrfconnect, nxp, psoc6, qpg, stm32)
|
|
PR #35777: Size comparison from 648f088 to 25bc05c Increases above 0.2%:
Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35777: Size comparison from 648f088 to 4940638 Increases above 0.2%:
Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Sep 26, 2024
arkq
approved these changes
Sep 27, 2024
This was referenced Sep 27, 2024
DavidKorczynski
pushed a commit
to google/oss-fuzz
that referenced
this pull request
Sep 30, 2024
- Reactivating UndefinedBehaviorSanitizer after having fixed UBSan issue: project-chip/connectedhomeip#35777 - MemorySanitizer can not be activated due to false positives showing for `glib`. Apparently all dependencies including glib will need to be re-compiled with MSan to avoid these false-positives.
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…roject-chip#35777) * using LambdaBridge to cast function pointer * adding support for Lambda that returns a CHIP_ERROR to LambdaBridge * pass an out pointer to capture function return result * Tizen Platform: Using LambdaBridge to safely invoke functions in GLib Matter context * Update to not modify lambdabridge * Potentiall cleaner code * Update code to make it compile * Update tizen code too * Tizen platform fix * Duplicating Changes to NuttX platform * Tizen Platform Fix --------- Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
"-fno-sanitize=vptr,function"in the config.functiondetects "Indirect call of a function through a function pointer of the wrong type", which is considered undefined behaviour by C99 and C++ standards.CHIP_ERROR(*)(T*)toCHIP_ERROR(*)(void*):Fix
Fix involves using
LambdaBridgeto safely cast and call the invoked function in the GLib Matter Context.the Lambda that is passed to
GLibMatterContextInvokeSync()will be stored and passed as a LambdaBridge to theg_main_context_invoke_fullfor execution.Fix was Added to Linux, Tizen and NuttX platforms.