remove a call of emberAfContainsAttribute when using the data model provider interface
#35746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…interface is enabled
|
Review changes with SemanticDiff. |
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtov-sfy,
jtung-apple and
kiel-apple
|
PR #35746: Size comparison from d3b645e to daba1c7 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…ible manner, the data model needs resetting
|
PR #35746: Size comparison from d3b645e to e42c21f Full report (8 builds for nxp, qpg, stm32, tizen)
|
|
PR #35746: Size comparison from e9d7b2f to d05a535 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Sep 25, 2024
andy31415
commented
Sep 25, 2024
|
PR #35746: Size comparison from e9d7b2f to 54a3c3a Full report (10 builds for nrfconnect, nxp, qpg)
|
|
PR #35746: Size comparison from e8554de to 62cb3db Full report (25 builds for cyw30739, esp32, linux, nxp, psoc6, stm32)
|
|
PR #35746: Size comparison from e8554de to 54489b2 Full report (45 builds for cyw30739, efr32, esp32, linux, nxp, psoc6, stm32)
|
tcarmelveilleux
approved these changes
Sep 26, 2024
|
PR #35746: Size comparison from e8554de to 1a658e1 Full report (45 builds for cyw30739, efr32, esp32, linux, nxp, psoc6, stm32)
|
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
… provider interface (project-chip#35746) * Remove a direct ember call from InteractionModelEngine if data model interface is enabled * Enforce identical DM vs ember logic * Fix up unit tests: because dynamic endpoints are reset in an incompatible manner, the data model needs resetting * Include fixes * Restyled by clang-format * Update src/app/codegen-data-model-provider/CodegenDataModelProvider.h * Comment update to kick CI again * make it more readable based on code review feedback * Restyle --------- Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues decoupling the interaction model engine from direct ember calls.