Rmp log source destination for txrx messages #35672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
PR #35672: Size comparison from afb1a33 to 024a88a Full report (80 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Sep 19, 2024
vivien-apple
force-pushed
the
RMP_LogSourceDestinationForTXRXMessages
branch
from
024a88a to
0e03fcf
Compare
vivien-apple
force-pushed
the
RMP_LogSourceDestinationForTXRXMessages
branch
from
0e03fcf to
7949da9
Compare
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs and
jmartinez-silabs
pullapprove
bot
requested review from
mkardous-silabs,
nivi-apple,
p0fi,
plauric,
rcasallas-silabs,
ReneJosefsen,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tima-q,
tobiasgraf,
wiba-nordic,
woody-apple and
younghak-hwang
|
PR #35672: Size comparison from 8f7d74d to 7949da9 Full report (41 builds for bl602, bl702, bl702l, cyw30739, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
vivien-apple
force-pushed
the
RMP_LogSourceDestinationForTXRXMessages
branch
from
7949da9 to
6c042b7
Compare
vivien-apple
force-pushed
the
RMP_LogSourceDestinationForTXRXMessages
branch
from
6c042b7 to
e915be6
Compare
|
PR #35672: Size comparison from b31673f to e915be6 Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Sep 20, 2024
nivi-apple
pushed a commit
to nivi-apple/connectedhomeip
that referenced
this pull request
Sep 24, 2024
* [Logging] Add destination to RX logs * [Logging] Add source to TX logs * Update the readme about RX/TX logs formatting
nivi-apple
pushed a commit
to nivi-apple/connectedhomeip
that referenced
this pull request
Sep 24, 2024
* [Logging] Add destination to RX logs * [Logging] Add source to TX logs * Update the readme about RX/TX logs formatting
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* [Logging] Add destination to RX logs * [Logging] Add source to TX logs * Update the readme about RX/TX logs formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This is not always easy to correlate logs with the ephemeral initiator node it used by the commissioner.
This PR updates the
Msg RXandMsg TXlogs for messages.Add destination to 'RX' messages -> when a message is received by the commissioner from 00000000 we can identify which ephemeral initiator node id it refers to (destination)
Add source to 'TX' messages -> when a message is emitted by the commissioner to the accessory we can identify which ephemeral initiator node id it is using (source)