Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve some MTRDeviceController logging. #35609

Merged

Conversation

bzbarsky-apple
Copy link
Contributor

More things should include context about which controller is involved.

More things should include context about which controller is involved.
Copy link

Review changes with SemanticDiff.

Copy link

github-actions bot commented Sep 16, 2024

PR #35609: Size comparison from 010ad94 to 858070c

Full report (26 builds for efr32, esp32, nxp, telink)
platform target config section 010ad94 858070c change % change
efr32 lighting-app BRD4187C FLASH 932468 932468 0 0.0
RAM 135056 135056 0 0.0
lock-app BRD2605a FLASH 739960 739952 -8 -0.0
RAM 231212 231212 0 0.0
BRD4338a FLASH 740608 740600 -8 -0.0
RAM 231244 231244 0 0.0
window-app BRD4187C FLASH 1015544 1015536 -8 -0.0
RAM 126996 126996 0 0.0
esp32 all-clusters-app c3devkit DRAM 94152 94152 0 0.0
FLASH 1539526 1539526 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115096 115096 0 0.0
FLASH 1549846 1549846 0 0.0
IRAM 117039 117039 0 0.0
nxp contact mcxw71+release FLASH 593024 593024 0 0.0
RAM 62552 62552 0 0.0
light mcxw71+release FLASH 679528 679528 0 0.0
RAM 48176 48176 0 0.0
lock mcxw71+release FLASH 701832 701832 0 0.0
RAM 66708 66708 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 621708 621708 0 0.0
RAM 50964 50964 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 688210 688210 0 0.0
RAM 148388 148388 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 779892 779892 0 0.0
RAM 110756 110756 0 0.0
bridge-app tlsr9258a FLASH 680728 680728 0 0.0
RAM 91620 91620 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621472 621472 0 0.0
RAM 50916 50916 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707404 707404 0 0.0
RAM 74256 74256 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 624626 624626 0 0.0
RAM 144292 144292 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 810034 810034 0 0.0
RAM 99424 99424 0 0.0
lock-app-dfu tlsr9528a FLASH 655224 655224 0 0.0
RAM 66976 66976 0 0.0
ota-requestor-app tlsr9258a FLASH 696704 696704 0 0.0
RAM 91212 91212 0 0.0
pump-app-usb tlsr9518adk80d FLASH 633060 633060 0 0.0
RAM 55792 55792 0 0.0
pump-controller-app tlsr9518adk80d FLASH 610250 610250 0 0.0
RAM 53036 53036 0 0.0
shell tlsr9518adk80d FLASH 467176 467176 0 0.0
RAM 68668 68668 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628436 628436 0 0.0
RAM 52636 52636 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652386 652386 0 0.0
RAM 56584 56584 0 0.0
thermostat tlsr9518adk80d FLASH 636980 636980 0 0.0
RAM 53428 53428 0 0.0
window-covering tlsr9118bdk40d FLASH 523156 523156 0 0.0
RAM 97268 97268 0 0.0

@bzbarsky-apple
Copy link
Contributor Author

Fast-tracking platform-specific fix with platform owner review.

@mergify mergify bot merged commit add0bf1 into project-chip:master Sep 17, 2024
69 checks passed
@bzbarsky-apple bzbarsky-apple deleted the better-controller-logging branch September 17, 2024 16:05
yyzhong-g pushed a commit to yyzhong-g/connectedhomeip that referenced this pull request Dec 12, 2024
More things should include context about which controller is involved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants