Actions: Add generic implementation for the actions cluster. #35568
+1,030
−470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kiel-apple
jadhavrohit924
force-pushed
the
actions
branch
from
10cabe7 to
960c59c
Compare
|
PR #35568: Size comparison from 0ac52eb to 960c59c Increases above 0.2%:
Full report (64 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
jadhavrohit924
force-pushed
the
actions
branch
from
960c59c to
cf78047
Compare
|
PR #35568: Size comparison from 3314bc3 to cf78047 Increases above 0.2%:
Full report (19 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
jadhavrohit924
force-pushed
the
actions
branch
from
cf78047 to
0326445
Compare
|
PR #35568: Size comparison from 3314bc3 to 0326445 Increases above 0.2%:
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
shubhamdp
reviewed
Dec 19, 2024
|
PR #35568: Size comparison from 3314bc3 to bf77a1b Increases above 0.2%:
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
shubhamdp
approved these changes
Dec 19, 2024
examples/all-clusters-app/all-clusters-common/src/bridged-actions-stub.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
OK, so how does the ASR bridge-app implement actions cluster now?
There was a problem hiding this comment.
What handles this now for this example app?
| @@ -128,6 +128,7 @@ | |||
| 'src/app/clusters/application-launcher-server/application-launcher-server.cpp': {'string'}, | |||
| 'src/app/clusters/application-launcher-server/application-launcher-delegate.h': {'list'}, | |||
| 'src/app/clusters/audio-output-server/audio-output-delegate.h': {'list'}, | |||
| 'src/app/clusters/actions-server/actions-server.h': {'vector'}, | |||
There was a problem hiding this comment.
Please document why this is ok.
|
|
||
| EndpointListStorage(const EndpointListStorage & epList) : mEpListName(mBuffer, sizeof(mBuffer)) { *this = epList; } | ||
|
|
||
| EndpointListStorage & operator=(const EndpointListStorage & epList) |
There was a problem hiding this comment.
Again, please add test and make sure setting to a longer name is supported.
| endpointListID = epListId; | ||
| type = epListType; | ||
|
|
||
| for (uint8_t index = 0; index < std::min(endpointList.size(), kEndpointListMaxSize); index++) |
There was a problem hiding this comment.
Please add unit tests for assignment operator, because it looks to me like the mEpList handling is broken if you assign more than once.
Comment on lines
+102
to
+103
| mEpListSpan = Span(mEpList.data(), mEpList.size()); | ||
| endpoints = DataModel::List<const EndpointId>(mEpListSpan); |
There was a problem hiding this comment.
Why do you need mEpListSpan at all as a member?
| private: | ||
| char mBuffer[kEndpointListNameMaxSize]; | ||
| MutableCharSpan mEpListName; | ||
| std::vector<EndpointId> mEpList; |
There was a problem hiding this comment.
OK, so why are we ok with a max-sized static buffer for mBuffer (which should be mNameBuffer anyway), but not for the endpoint list? At the very least that needs to be documented.
|
|
||
| for (uint8_t index = 0; index < std::min(endpointList.size(), kEndpointListMaxSize); index++) | ||
| { | ||
| mEpList.push_back(endpointList[index]); |
There was a problem hiding this comment.
This has terrible realloc behavior. If we know the size, why are we not reserving it?
Also, this will crash on allocation failure the way this is written right now, as far as I can tell. Is that intended?
…ong with name buffer and added events
…of MatterActionsPluginServerInitCallback in example
jadhavrohit924
force-pushed
the
actions
branch
from
e7ccfb0 to
a5ef39b
Compare
|
PR #35568: Size comparison from c1afc02 to a5ef39b Increases above 0.2%:
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Changes:
Testing: