TC-CC-3.2: Change timing so range tolerance doesn't span wrap #35525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us omit the manual step. Manual steps in the middle of a timed test will never work. Also fix the tolerance calculation.
|
Review changes with SemanticDiff. |
github-actions
bot
added
app
tests
matter-1.4-te2-script-change
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248 and
hicklin
pullapprove
bot
requested review from
sharadb-amazon,
younghak-hwang,
tcarmelveilleux,
yufengwangca,
tecimovic,
yunhanw-google,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic and
woody-apple
|
PR #35525: Size comparison from bd6ae09 to 2fd97a2 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
leorozendaal
approved these changes
Sep 10, 2024
bzbarsky-apple
approved these changes
Sep 10, 2024
Co-authored-by: Leo Rozendaal <[email protected]>
|
PR #35525: Size comparison from bd6ae09 to 289c445 Increases above 0.2%:
Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Sep 30, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…t-chip#35525) * TC-CC-3.2: Change timing so range tolerance doesn't span wrap This lets us omit the manual step. Manual steps in the middle of a timed test will never work. Also fix the tolerance calculation. * Update src/app/tests/suites/certification/Test_TC_CC_3_2.yaml Co-authored-by: Leo Rozendaal <[email protected]> --------- Co-authored-by: Leo Rozendaal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us omit the manual step. Manual steps in the middle of a timed test will never work.
Also fix the tolerance calculation.
test plan: https://github.com/CHIP-Specifications/chip-test-plans/pull/4662