Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mentions of client-side global attributes in the ZAP XML. #35449

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Remove mentions of client-side global attributes in the ZAP XML. #35449

merged 1 commit into from
Sep 6, 2024

Conversation

bzbarsky-apple
Copy link
Contributor

Client-side attributes do not exist in Matter.

@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@github-actions github-actions bot added the app label Sep 6, 2024
@bzbarsky-apple bzbarsky-apple force-pushed the remove-client-attributes branch from 65d38d6 to 057da15 Compare September 6, 2024 17:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024 •
edited
Loading

PR #35449: Size comparison from e96ddd9 to 057da15

Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section e96ddd9 057da15 change % change
bl602 lighting-app bl602 FLASH 1279600 1279600 0 0.0
RAM 95904 95904 0 0.0
bl602+mfd FLASH 1293710 1293710 0 0.0
RAM 96048 96048 0 0.0
bl602+rpc FLASH 1318564 1318564 0 0.0
RAM 104328 104328 0 0.0
bl702 lighting-app bl702 FLASH 944934 944934 0 0.0
RAM 15209 15209 0 0.0
bl702+mfd FLASH 947334 947334 0 0.0
RAM 15353 15353 0 0.0
bl702+rpc FLASH 1040246 1040246 0 0.0
RAM 24221 24221 0 0.0
bl706-eth FLASH 648006 648006 0 0.0
RAM 25305 25305 0 0.0
bl706-wifi FLASH 895420 895420 0 0.0
RAM 14525 14525 0 0.0
bl702l lighting-app bl702l FLASH 961594 961594 0 0.0
RAM 16868 16868 0 0.0
bl702l+mfd FLASH 964216 964216 0 0.0
RAM 17012 17012 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678265 678265 0 0.0
RAM 78556 78556 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 698117 698117 0 0.0
RAM 81188 81188 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 698117 698117 0 0.0
RAM 81188 81188 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 655053 655053 0 0.0
RAM 73624 73624 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614601 614601 0 0.0
RAM 71524 71524 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634237 634237 0 0.0
RAM 74076 74076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634237 634237 0 0.0
RAM 74076 74076 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 632625 632625 0 0.0
RAM 74540 74540 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 652341 652341 0 0.0
RAM 77092 77092 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 652341 652341 0 0.0
RAM 77092 77092 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 606917 606917 0 0.0
RAM 68580 68580 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 626769 626769 0 0.0
RAM 71212 71212 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 626769 626769 0 0.0
RAM 71212 71212 0 0.0
efr32 lighting-app BRD4187C FLASH 933684 933684 0 0.0
RAM 135120 135120 0 0.0
lock-app BRD4338a FLASH 740804 740804 0 0.0
RAM 197184 197184 0 0.0
window-app BRD4187C FLASH 1017480 1017472 -8 -0.0
RAM 127060 127060 0 0.0
esp32 all-clusters-app c3devkit DRAM 94136 94136 0 0.0
FLASH 1538430 1538430 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115072 115072 0 0.0
FLASH 1548862 1548862 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2768253 2768253 0 0.0
RAM 128808 128808 0 0.0
all-clusters-app debug unknown 5456 5456 0 0.0
FLASH 6079122 6079122 0 0.0
RAM 510840 510840 0 0.0
all-clusters-minimal-app debug unknown 5352 5352 0 0.0
FLASH 5403236 5403236 0 0.0
RAM 240648 240648 0 0.0
bridge-app debug unknown 5336 5336 0 0.0
FLASH 4737058 4737058 0 0.0
RAM 217640 217640 0 0.0
chip-tool debug unknown 5888 5888 0 0.0
FLASH 12653086 12653086 0 0.0
RAM 558570 558570 0 0.0
chip-tool-ipv6only arm64 unknown 20368 20368 0 0.0
FLASH 11325156 11325156 0 0.0
RAM 608672 608672 0 0.0
fabric-admin debug unknown 5720 5720 0 0.0
FLASH 10960469 10960469 0 0.0
RAM 557562 557562 0 0.0
fabric-bridge-app debug unknown 4568 4568 0 0.0
FLASH 4559860 4559860 0 0.0
RAM 204288 204288 0 0.0
lighting-app debug+rpc+ui unknown 5984 5984 0 0.0
FLASH 5684561 5684561 0 0.0
RAM 228456 228456 0 0.0
lock-app debug unknown 5272 5272 0 0.0
FLASH 4791694 4791694 0 0.0
RAM 204040 204040 0 0.0
ota-provider-app debug unknown 4648 4648 0 0.0
FLASH 4431200 4431200 0 0.0
RAM 198024 198024 0 0.0
ota-requestor-app debug unknown 4584 4584 0 0.0
FLASH 4569776 4569776 0 0.0
RAM 202560 202560 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3105469 3105469 0 0.0
RAM 159520 159520 0 0.0
thermostat-no-ble arm64 unknown 9320 9320 0 0.0
FLASH 4330692 4330692 0 0.0
RAM 242240 242240 0 0.0
tv-app debug unknown 5552 5552 0 0.0
FLASH 6018149 6018149 0 0.0
RAM 583512 583512 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 10859293 10859293 0 0.0
RAM 646200 646200 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914064 914064 0 0.0
RAM 142252 142252 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 885732 885732 0 0.0
RAM 140391 140391 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 845456 845456 0 0.0
RAM 141070 141070 0 0.0
nxp contact k32w0+release FLASH 579500 579500 0 0.0
RAM 70676 70676 0 0.0
k32w1+release FLASH 593328 593328 0 0.0
RAM 62712 62712 0 0.0
light k32w0+release FLASH 615128 615128 0 0.0
RAM 70140 70140 0 0.0
k32w1+release FLASH 676952 676952 0 0.0
RAM 47848 47848 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1645964 1645964 0 0.0
RAM 210944 210944 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1549596 1549596 0 0.0
RAM 207656 207656 0 0.0
light cy8ckit_062s2_43012 FLASH 1468388 1468388 0 0.0
RAM 200752 200752 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463660 1463660 0 0.0
RAM 225064 225064 0 0.0
qpg lighting-app qpg6105+debug FLASH 657804 657804 0 0.0
RAM 105192 105192 0 0.0
lock-app qpg6105+debug FLASH 615960 615960 0 0.0
RAM 99660 99660 0 0.0
stm32 light STM32WB5MM-DK FLASH 481608 481608 0 0.0
RAM 144740 144740 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620810 620810 0 0.0
RAM 50940 50940 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 686304 686304 0 0.0
RAM 149584 149584 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 778744 778744 0 0.0
RAM 110744 110744 0 0.0
bridge-app tlsr9258a FLASH 679804 679804 0 0.0
RAM 91596 91596 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622402 622402 0 0.0
RAM 50980 50980 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708414 708414 0 0.0
RAM 74320 74320 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 624604 624604 0 0.0
RAM 145564 145564 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 810734 810734 0 0.0
RAM 99488 99488 0 0.0
lock-app-dfu tlsr9528a FLASH 655386 655386 0 0.0
RAM 67016 67016 0 0.0
ota-requestor-app tlsr9258a FLASH 697670 697670 0 0.0
RAM 91280 91280 0 0.0
pump-app-usb tlsr9518adk80d FLASH 632112 632112 0 0.0
RAM 55760 55760 0 0.0
pump-controller-app tlsr9518adk80d FLASH 609360 609360 0 0.0
RAM 53004 53004 0 0.0
shell tlsr9518adk80d FLASH 467196 467196 0 0.0
RAM 68668 68668 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 629188 629188 0 0.0
RAM 52700 52700 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 653342 653342 0 0.0
RAM 56640 56640 0 0.0
thermostat tlsr9518adk80d FLASH 636092 636092 0 0.0
RAM 53408 53408 0 0.0
window-covering tlsr9118bdk40d FLASH 523346 523346 0 0.0
RAM 98540 98540 0 0.0
tizen all-clusters-app arm unknown 4840 4840 0 0.0
FLASH 1722416 1722416 0 0.0
RAM 89548 89548 0 0.0
chip-tool-ubsan arm unknown 10272 10272 0 0.0
FLASH 17499570 17499570 0 0.0
RAM 7596248 7596248 0 0.0

@bzbarsky-apple
Remove mentions of client-side global attributes in the ZAP XML.
b235afe 
Client-side attributes do not exist in Matter.
@bzbarsky-apple bzbarsky-apple force-pushed the remove-client-attributes branch from 057da15 to b235afe Compare September 6, 2024 19:23
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024 •
edited
Loading

PR #35449: Size comparison from 96e687b to b235afe

Full report (63 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 96e687b b235afe change % change
bl602 lighting-app bl602 FLASH 1279600 1279600 0 0.0
RAM 95904 95904 0 0.0
bl602+mfd FLASH 1293710 1293710 0 0.0
RAM 96048 96048 0 0.0
bl602+rpc FLASH 1318564 1318564 0 0.0
RAM 104328 104328 0 0.0
bl702 lighting-app bl702 FLASH 944934 944934 0 0.0
RAM 15209 15209 0 0.0
bl702+mfd FLASH 947334 947334 0 0.0
RAM 15353 15353 0 0.0
bl702+rpc FLASH 1040246 1040246 0 0.0
RAM 24221 24221 0 0.0
bl706-eth FLASH 648006 648006 0 0.0
RAM 25305 25305 0 0.0
bl706-wifi FLASH 895420 895420 0 0.0
RAM 14525 14525 0 0.0
bl702l lighting-app bl702l FLASH 961594 961594 0 0.0
RAM 16868 16868 0 0.0
bl702l+mfd FLASH 964216 964216 0 0.0
RAM 17012 17012 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678265 678265 0 0.0
RAM 78556 78556 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 698117 698117 0 0.0
RAM 81188 81188 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 698117 698117 0 0.0
RAM 81188 81188 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 655053 655053 0 0.0
RAM 73624 73624 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614601 614601 0 0.0
RAM 71524 71524 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634237 634237 0 0.0
RAM 74076 74076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634237 634237 0 0.0
RAM 74076 74076 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 632625 632625 0 0.0
RAM 74540 74540 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 652341 652341 0 0.0
RAM 77092 77092 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 652341 652341 0 0.0
RAM 77092 77092 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 606917 606917 0 0.0
RAM 68580 68580 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 626769 626769 0 0.0
RAM 71212 71212 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 626769 626769 0 0.0
RAM 71212 71212 0 0.0
efr32 lighting-app BRD4187C FLASH 933684 933684 0 0.0
RAM 135120 135120 0 0.0
lock-app BRD4338a FLASH 740804 740804 0 0.0
RAM 197184 197184 0 0.0
window-app BRD4187C FLASH 1017480 1017472 -8 -0.0
RAM 127060 127060 0 0.0
esp32 all-clusters-app c3devkit DRAM 94136 94136 0 0.0
FLASH 1538430 1538430 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115072 115072 0 0.0
FLASH 1548862 1548862 0 0.0
IRAM 117039 117039 0 0.0
linux chip-tool-ipv6only arm64 unknown 20368 20368 0 0.0
FLASH 11325156 11325156 0 0.0
RAM 608672 608672 0 0.0
thermostat-no-ble arm64 unknown 9320 9320 0 0.0
FLASH 4330692 4330692 0 0.0
RAM 242240 242240 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914064 914064 0 0.0
RAM 142252 142252 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 885732 885732 0 0.0
RAM 140391 140391 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 845456 845456 0 0.0
RAM 141070 141070 0 0.0
nxp contact k32w0+release FLASH 579500 579500 0 0.0
RAM 70676 70676 0 0.0
k32w1+release FLASH 593328 593328 0 0.0
RAM 62712 62712 0 0.0
light k32w0+release FLASH 615128 615128 0 0.0
RAM 70140 70140 0 0.0
k32w1+release FLASH 676952 676952 0 0.0
RAM 47848 47848 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1645964 1645964 0 0.0
RAM 210944 210944 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1549596 1549596 0 0.0
RAM 207656 207656 0 0.0
light cy8ckit_062s2_43012 FLASH 1468388 1468388 0 0.0
RAM 200752 200752 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463660 1463660 0 0.0
RAM 225064 225064 0 0.0
qpg lighting-app qpg6105+debug FLASH 657804 657804 0 0.0
RAM 105192 105192 0 0.0
lock-app qpg6105+debug FLASH 615960 615960 0 0.0
RAM 99660 99660 0 0.0
stm32 light STM32WB5MM-DK FLASH 481608 481608 0 0.0
RAM 144740 144740 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620810 620810 0 0.0
RAM 50940 50940 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 686304 686304 0 0.0
RAM 149584 149584 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 778744 778744 0 0.0
RAM 110744 110744 0 0.0
bridge-app tlsr9258a FLASH 679804 679804 0 0.0
RAM 91596 91596 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622402 622402 0 0.0
RAM 50980 50980 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708414 708414 0 0.0
RAM 74320 74320 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 624604 624604 0 0.0
RAM 145564 145564 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 810734 810734 0 0.0
RAM 99488 99488 0 0.0
lock-app-dfu tlsr9528a FLASH 655386 655386 0 0.0
RAM 67016 67016 0 0.0
ota-requestor-app tlsr9258a FLASH 697670 697670 0 0.0
RAM 91280 91280 0 0.0
pump-app-usb tlsr9518adk80d FLASH 632112 632112 0 0.0
RAM 55760 55760 0 0.0
pump-controller-app tlsr9518adk80d FLASH 609360 609360 0 0.0
RAM 53004 53004 0 0.0
shell tlsr9518adk80d FLASH 467196 467196 0 0.0
RAM 68668 68668 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 629188 629188 0 0.0
RAM 52700 52700 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 653342 653342 0 0.0
RAM 56640 56640 0 0.0
thermostat tlsr9518adk80d FLASH 636092 636092 0 0.0
RAM 53408 53408 0 0.0
window-covering tlsr9118bdk40d FLASH 523346 523346 0 0.0
RAM 98540 98540 0 0.0
tizen all-clusters-app arm unknown 4840 4840 0 0.0
FLASH 1722416 1722416 0 0.0
RAM 89548 89548 0 0.0
chip-tool-ubsan arm unknown 10272 10272 0 0.0
FLASH 17499570 17499570 0 0.0
RAM 7596248 7596248 0 0.0

@mergify mergify bot merged commit 6f1663f into project-chip:master Sep 6, 2024
67 checks passed
@bzbarsky-apple bzbarsky-apple deleted the remove-client-attributes branch September 6, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiel-apple kiel-apple kiel-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@axelnxp axelnxp Awaiting requested review from axelnxp

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chapongatien chapongatien Awaiting requested review from chapongatien

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@doru91 doru91 Awaiting requested review from doru91

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @andy31415 @kiel-apple