Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ICD] refreshKey needs to be set with length #35379

Merged
merged 2 commits into from
Sep 3, 2024
Merged

[ICD] refreshKey needs to be set with length #35379

merged 2 commits into from
Sep 3, 2024

Conversation

yunhanw-google
Copy link
Contributor

@yunhanw-google yunhanw-google commented Sep 3, 2024 •
edited
Loading

We need setLength after putting data inside SensitiveDataBuffer, otherwise, the key is 0 bytes
verified locally and confirm refreshKey works
fixes #35347

@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@github-actions github-actions bot added app icd Intermittently Connected Devices labels Sep 3, 2024
@yunhanw-google yunhanw-google force-pushed the feature/fix_refresh_key branch from 77efee5 to d6d2f51 Compare September 3, 2024 19:28
@yunhanw-google yunhanw-google enabled auto-merge (squash) September 3, 2024 19:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024 •
edited
Loading

PR #35379: Size comparison from 5dd517c to cc54d2d

Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 5dd517c cc54d2d4 change % change
bl602 lighting-app bl602 FLASH 1279092 1279092 0 0.0
RAM 95880 95880 0 0.0
bl602+mfd FLASH 1293202 1293202 0 0.0
RAM 96024 96024 0 0.0
bl602+rpc FLASH 1318056 1318056 0 0.0
RAM 104304 104304 0 0.0
bl702 lighting-app bl702 FLASH 944678 944678 0 0.0
RAM 15209 15209 0 0.0
bl702+mfd FLASH 947078 947078 0 0.0
RAM 15353 15353 0 0.0
bl702+rpc FLASH 1039734 1039734 0 0.0
RAM 24221 24221 0 0.0
bl706-eth FLASH 647494 647494 0 0.0
RAM 25305 25305 0 0.0
bl706-wifi FLASH 894908 894908 0 0.0
RAM 14525 14525 0 0.0
bl702l lighting-app bl702l FLASH 961082 961082 0 0.0
RAM 16868 16868 0 0.0
bl702l+mfd FLASH 963704 963704 0 0.0
RAM 17012 17012 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 676809 676809 0 0.0
RAM 78300 78300 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 696669 696669 0 0.0
RAM 80932 80932 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 696669 696669 0 0.0
RAM 80932 80932 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 653597 653597 0 0.0
RAM 73368 73368 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611193 611193 0 0.0
RAM 71292 71292 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 630821 630821 0 0.0
RAM 73844 73844 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 630821 630821 0 0.0
RAM 73844 73844 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 629233 629233 0 0.0
RAM 74308 74308 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 648941 648941 0 0.0
RAM 76860 76860 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 648941 648941 0 0.0
RAM 76860 76860 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 603501 603501 0 0.0
RAM 68348 68348 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 623361 623361 0 0.0
RAM 70980 70980 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 623361 623361 0 0.0
RAM 70980 70980 0 0.0
efr32 lighting-app BRD4187C FLASH 934836 934836 0 0.0
RAM 135096 135096 0 0.0
lock-app BRD4338a FLASH 740764 740764 0 0.0
RAM 197184 197184 0 0.0
window-app BRD4187C FLASH 1015856 1015856 0 0.0
RAM 127036 127036 0 0.0
esp32 all-clusters-app c3devkit DRAM 94200 94200 0 0.0
FLASH 1539894 1539894 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115136 115136 0 0.0
FLASH 1550502 1550502 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4624 4624 0 0.0
FLASH 2763665 2763665 0 0.0
RAM 128536 128536 0 0.0
all-clusters-app debug unknown 5408 5408 0 0.0
FLASH 6076348 6076348 0 0.0
RAM 510408 510408 0 0.0
all-clusters-minimal-app debug unknown 5304 5304 0 0.0
FLASH 5401164 5401164 0 0.0
RAM 240248 240248 0 0.0
bridge-app debug unknown 5288 5288 0 0.0
FLASH 4732250 4732250 0 0.0
RAM 217368 217368 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12650916 12651022 106 0.0
RAM 558354 558354 0 0.0
chip-tool-ipv6only arm64 unknown 20352 20352 0 0.0
FLASH 11322796 11322876 80 0.0
RAM 608424 608424 0 0.0
fabric-admin debug unknown 5664 5664 0 0.0
FLASH 10949697 10949835 138 0.0
RAM 557066 557066 0 0.0
fabric-bridge-app debug unknown 4520 4520 0 0.0
FLASH 4555270 4555270 0 0.0
RAM 204016 204016 0 0.0
lighting-app debug+rpc+ui unknown 5936 5936 0 0.0
FLASH 5682561 5682561 0 0.0
RAM 228056 228056 0 0.0
lock-app debug unknown 5224 5224 0 0.0
FLASH 4787074 4787074 0 0.0
RAM 203768 203768 0 0.0
ota-provider-app debug unknown 4600 4600 0 0.0
FLASH 4426612 4426612 0 0.0
RAM 197752 197752 0 0.0
ota-requestor-app debug unknown 4536 4536 0 0.0
FLASH 4565198 4565198 0 0.0
RAM 202288 202288 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3103469 3103469 0 0.0
RAM 159040 159040 0 0.0
thermostat-no-ble arm64 unknown 9296 9296 0 0.0
FLASH 4325900 4325900 0 0.0
RAM 241896 241896 0 0.0
tv-app debug unknown 5504 5504 0 0.0
FLASH 6011589 6011589 0 0.0
RAM 583192 583192 0 0.0
tv-casting-app debug unknown 5168 5168 0 0.0
FLASH 10854957 10854957 0 0.0
RAM 645768 645768 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 915096 915096 0 0.0
RAM 142219 142219 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 886400 886400 0 0.0
RAM 140358 140358 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846364 846364 0 0.0
RAM 141038 141038 0 0.0
nxp contact k32w0+release FLASH 577796 577796 0 0.0
RAM 70444 70444 0 0.0
k32w1+release FLASH 593248 593248 0 0.0
RAM 62712 62712 0 0.0
light k32w0+release FLASH 613224 613224 0 0.0
RAM 69908 69908 0 0.0
k32w1+release FLASH 676680 676680 0 0.0
RAM 47848 47848 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1647340 1647340 0 0.0
RAM 210920 210920 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1551156 1551156 0 0.0
RAM 207632 207632 0 0.0
light cy8ckit_062s2_43012 FLASH 1469948 1469948 0 0.0
RAM 200728 200728 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463636 1463636 0 0.0
RAM 225064 225064 0 0.0
qpg lighting-app qpg6105+debug FLASH 656348 656348 0 0.0
RAM 105128 105128 0 0.0
lock-app qpg6105+debug FLASH 614208 614208 0 0.0
RAM 99612 99612 0 0.0
stm32 light STM32WB5MM-DK FLASH 482744 482744 0 0.0
RAM 144716 144716 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620504 620504 0 0.0
RAM 50932 50932 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 687022 687022 0 0.0
RAM 149552 149552 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 779332 779332 0 0.0
RAM 110712 110712 0 0.0
bridge-app tlsr9258a FLASH 679234 679234 0 0.0
RAM 91588 91588 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622096 622096 0 0.0
RAM 50972 50972 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708106 708106 0 0.0
RAM 74312 74312 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625166 625166 0 0.0
RAM 145532 145532 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811298 811298 0 0.0
RAM 99456 99456 0 0.0
lock-app-dfu tlsr9528a FLASH 655078 655078 0 0.0
RAM 67008 67008 0 0.0
ota-requestor-app tlsr9258a FLASH 697362 697362 0 0.0
RAM 91272 91272 0 0.0
pump-app-usb tlsr9518adk80d FLASH 631542 631542 0 0.0
RAM 55752 55752 0 0.0
pump-controller-app tlsr9518adk80d FLASH 609052 609052 0 0.0
RAM 52996 52996 0 0.0
shell tlsr9518adk80d FLASH 466890 466890 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628882 628882 0 0.0
RAM 52692 52692 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 653034 653034 0 0.0
RAM 56632 56632 0 0.0
thermostat tlsr9518adk80d FLASH 635784 635784 0 0.0
RAM 53400 53400 0 0.0
window-covering tlsr9118bdk40d FLASH 523038 523038 0 0.0
RAM 98532 98532 0 0.0
tizen all-clusters-app arm unknown 4848 4848 0 0.0
FLASH 1723564 1723564 0 0.0
RAM 89380 89380 0 0.0
chip-tool-ubsan arm unknown 10272 10272 0 0.0
FLASH 17511094 17511166 72 0.0
RAM 7601308 7601324 16 0.0

@yunhanw-google yunhanw-google merged commit 3de6f04 into project-chip:master Sep 3, 2024
65 of 67 checks passed
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Sep 10, 2024
@yunhanw-google @shgutte
[ICD] refreshKey needs to be set with length (project-chip#35379)
3686844 
* refreshKey needs to be set with length

* address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@axelnxp axelnxp Awaiting requested review from axelnxp

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chapongatien chapongatien Awaiting requested review from chapongatien

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@doru91 doru91 Awaiting requested review from doru91

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

Assignees
No one assigned
Labels
app icd Intermittently Connected Devices review - approved
Projects
None yet
Milestone
No milestone
4 participants
@yunhanw-google @yufengwangca @bzbarsky-apple @jmartinez-silabs