Fixed the crash due to packet buffers running out of space in CommandHandlerImpl. #35279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kiel-apple
pullapprove
bot
requested review from
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
@tehampson , can you please review. |
|
PR #35279: Size comparison from 9bbf5b9 to ea62667 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tehampson
reviewed
Aug 29, 2024
shripad621git
force-pushed
the
fix/command_handler
branch
from
fde2cc2 to
2a605c9
Compare
|
PR #35279: Size comparison from 8f9e8f1 to 2a605c9 Full report (12 builds for nrfconnect, nxp, qpg, stm32, tizen)
|
tehampson
approved these changes
Aug 29, 2024
tehampson
reviewed
Aug 29, 2024
Co-authored-by: Terence Hampson <[email protected]>
shripad621git
force-pushed
the
fix/command_handler
branch
from
2a605c9 to
28c95ce
Compare
Damian-Nordic
approved these changes
Aug 29, 2024
|
PR #35279: Size comparison from 8f9e8f1 to 28c95ce Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Sep 10, 2024
…HandlerImpl. (project-chip#35279) * Fixed the crash due to packet buffers running out of space in CommandHandlerImpl * Update src/app/CommandHandlerImpl.h Co-authored-by: Terence Hampson <[email protected]> --------- Co-authored-by: Terence Hampson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
due to the below mentioned reason:
CHIP_ERROR_INCORRECT_STATEleading to failure of the condition mentioned above leading to a crash.mRollbackBackupValid is not set since the function CreateBackupForResonseCallback did not get executed which executes after AllocateBuffer() function in PrepareStatus() function.i,e due to packet buffer full the allocate buffer returned early.
Change Overview:
CHIP_ERROR_NO_MEMORYdue to running out of packet buffers.