NetworkCommissioning: Disconnect previous network when trying a new #35256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
PR #35256: Size comparison from e4502c3 to 10ee668 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
DejinChen
changed the title
…ew connection on other endpoint
DejinChen
force-pushed
the
disconnect_previous_network_when_trying_a_new
branch
2 times, most recently
from
7979f6a to
395d62a
Compare
DejinChen
force-pushed
the
disconnect_previous_network_when_trying_a_new
branch
from
395d62a to
4749898
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve and
harimau-qirex
DejinChen
force-pushed
the
disconnect_previous_network_when_trying_a_new
branch
from
0fefbc1 to
6182de7
Compare
|
PR #35256: Size comparison from 2cf028b to 6182de7 Full report (12 builds for nrfconnect, nxp, qpg, stm32, tizen)
|
DejinChen
force-pushed
the
disconnect_previous_network_when_trying_a_new
branch
from
6182de7 to
eb7d7bc
Compare
|
PR #35256: Size comparison from 2cf028b to eb7d7bc Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
DejinChen
force-pushed
the
disconnect_previous_network_when_trying_a_new
branch
2 times, most recently
from
607df8a to
a059abb
Compare
|
PR #35256: Size comparison from 36f0c50 to a059abb Full report (39 builds for bl602, bl702, bl702l, cyw30739, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
DejinChen
force-pushed
the
disconnect_previous_network_when_trying_a_new
branch
from
a059abb to
e4b0637
Compare
|
PR #35256: Size comparison from 9b58d4c to e4b0637 Full report (22 builds for bl602, bl702, bl702l, nrfconnect, nxp, qpg, stm32, tizen)
|
DejinChen
force-pushed
the
disconnect_previous_network_when_trying_a_new
branch
from
e4b0637 to
2283ae5
Compare
|
PR #35256: Size comparison from 9b58d4c to 2283ae5 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
DejinChen
force-pushed
the
disconnect_previous_network_when_trying_a_new
branch
from
2283ae5 to
460a7d1
Compare
|
PR #35256: Size comparison from 513f241 to 460a7d1 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
DejinChen
force-pushed
the
disconnect_previous_network_when_trying_a_new
branch
from
460a7d1 to
dd0391d
Compare
|
PR #35256: Size comparison from f89d5b9 to dd0391d Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35256: Size comparison from 0b696d8 to b6819ca Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35256: Size comparison from 7249c56 to 7496cfb Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
DejinChen
force-pushed
the
disconnect_previous_network_when_trying_a_new
branch
from
7496cfb to
ff24375
Compare
|
PR #35256: Size comparison from 7249c56 to ff24375 Full report (46 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
DejinChen
force-pushed
the
disconnect_previous_network_when_trying_a_new
branch
from
ff24375 to
36fd1cc
Compare
|
PR #35256: Size comparison from 7249c56 to 36fd1cc Full report (60 builds for bl602, bl702, bl702l, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
DejinChen
force-pushed
the
disconnect_previous_network_when_trying_a_new
branch
from
36fd1cc to
75df75b
Compare
|
PR #35256: Size comparison from 607a4a8 to 75df75b Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35256: Size comparison from 01632c4 to 9118cab Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…roject-chip#35256) * NetworkCommissioning: disconnect previous network when attepmting a new connection on other endpoint * use linked list and disconnect driver when no connected network config * Add DisconnectFromNetwork for OpenThread and ESP32 platform * Update src/app/clusters/network-commissioning/network-commissioning.cpp Co-authored-by: Karsten Sperling <[email protected]> * resolve comments * Use IntrusiveList and other minor tweaks * fix CI --------- Co-authored-by: Karsten Sperling <[email protected]> Co-authored-by: Karsten Sperling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref to https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/10335.
Change overview