[Fix] Replace automatable PICS in TSTAT test modules #35238
+26
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
j-ororke
commented
Aug 28, 2024
j-ororke
commented
- Replaced automatable PICS in TC_TSTAT_4_2 test module with values gathered from attributes and features from the endpoint
- Replaced automatable PICS in TC_TSTAT_4_2 test module with values gathered from attributes and features from the endpoint
|
Review changes with |
github-actions
bot
added
tests
matter-1.4-te2-script-change
|
PR #35238: Size comparison from 0944982 to 54c7cd9 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Updated to include changes for checking AtomicRequest command is a supported command on endpoint
|
PR #35238: Size comparison from 3d69583 to e5086a6 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91 and
fessehaeve
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
cecille
removed
the
matter-1.4-te2-script-change
cecille
reviewed
Oct 29, 2024
| @@ -267,7 +276,7 @@ async def test_TC_TSTAT_4_2(self): | |||
| coolSetpoint = minCoolSetpointLimit + ((maxCoolSetpointLimit - minCoolSetpointLimit) / 2) | |||
|
|
|||
| self.step("2") | |||
| if self.pics_guard(self.check_pics("TSTAT.S.F08") and self.check_pics("TSTAT.S.A0050")): | |||
| if supports_presets and presets_attr_id in attribute_list: | |||
There was a problem hiding this comment.
As in the other tests, this is going to remove the skip markers. I think let's wait until 34290 goes in and just update to use the attribute guard. It might make sense to add something similar for features (and commands) to get it working with this PR too.
github-actions
bot
added
the
matter-1.4-te2-script-change
|
PR #35238: Size comparison from a3a443a to fd8340d Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35238: Size comparison from 38ad07d to 2f52b9b Full report (25 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink, tizen)
|
- Updated Test step 6 to match with original test step PICS args to pass CI checks
|
PR #35238: Size comparison from 38ad07d to 322a75d Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35238: Size comparison from 2c6c421 to 2835ae7 Full report (3 builds for cc32xx, stm32)
|
|
PR #35238: Size comparison from 1c92162 to ddabe10 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.