Update Quiet reporting conditions for LVL and CC remaining time attribute #35224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple and
kkasperczyk-no
pullapprove
bot
requested review from
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #35224: Size comparison from d185778 to b033dc2 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
force-pushed
the
Q_quality/lvl_and_cc_update
branch
from
b033dc2 to
07308d7
Compare
jmartinez-silabs
force-pushed
the
Q_quality/lvl_and_cc_update
branch
from
07308d7 to
d1ac726
Compare
|
PR #35224: Size comparison from 4d4fcb3 to d1ac726 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
I was testing this change while updating the script to match the latest test plan and I had an issue with RemainingTime when after it has transitioned to use MoveToColorTemperature command, after a bit of digging, it seems like we have missed a SetQuietReportRemainingTime in the moveToColorTemp command, @jmartinez-silabs thoughts? |
@ReneJosefsen it should be called in the timed event callback that updates the colortempmired attributes. Maybe it is missing. I'll confirm tomorrow/fix it if need be in this pr that I need to update anyway |
From what I could see it is called in the callback, but it "misses" when the new command is received so it does not mark the change in RemaningTime as reportable even though it changes quite a lot due to a MoveToColorTemp command, hence why I assumed we needed to have the SetQuietReportRemainingTime call in the command "handler" as well, like the other commands to indicate it is caused by a new command. |
…Add remainingTime Report condition on command invoke. Fix clang-tidy
Co-authored-by: Boris Zbarsky <[email protected]>
tcarmelveilleux
approved these changes
Sep 3, 2024
bzbarsky-apple
approved these changes
Sep 3, 2024
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Sep 10, 2024
…bute (project-chip#35224) * Update Quiet reporting conditions for LVL and CC remaining time attribute * Restyled by clang-format * Fix/cleaup of startUpColorTempCommand * Add missing SetQuietReportRemainingTime for moveToColorTemp command. Add remainingTime Report condition on command invoke. Fix clang-tidy * Update src/app/clusters/color-control-server/color-control-server.cpp Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec pr 10231 modifies the quiet reporting of the Remaining time attribute of the Level and Color control clusters.
The conditions on which the attribute must be reported are :
It also adds the Quiet report quality to the ColorTemperatureMireds attribute.
Report conditions are:
This PR reflect those changes in the SDK.
Tested on Silabs lighting-app with cert tests TC_CC_2_2.py and TC_LVL_2_3.py