Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed check in step 5 of TC-SEAR-1.2 #35221

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Fixed check in step 5 of TC-SEAR-1.2 #35221

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
652ebb0
Fixed check in step 5 of TC-SEAR-1.2
hicklin Aug 27, 2024
794fe63
Fixed check for EstimatedEndTime being not null in step 6.
hicklin Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/python_testing/TC_SEAR_1_2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,10 @@ async def read_and_validate_current_area(self, step):
endpoint=self.endpoint, attribute=Clusters.ServiceArea.Attributes.CurrentArea)
logging.info(f"CurrentArea {current_area}")

asserts.assert_true((len(self.selareaid_list) == 0 and current_area is NullValue)
or
current_area in self.selareaid_list,
f"CurrentArea {current_area} is invalid. SelectedAreas is {self.selareaid_list}.")
if current_area is not NullValue:
plauric marked this conversation as resolved.
Show resolved Hide resolved
asserts.assert_true(current_area in self.areaid_list,
f"CurrentArea {current_area} is not in SupportedAreas: {self.areaid_list}.")

# save so other methods can use this if needed
self.current_area = current_area

Expand All @@ -158,7 +158,8 @@ async def read_and_validate_estimated_end_time(self, step):
if self.current_area is NullValue:
asserts.assert_true(estimated_end_time is NullValue,
"EstimatedEndTime should be null if CurrentArea is null.")
else:

if estimated_end_time is not NullValue:
# allow for some clock skew
asserts.assert_true(estimated_end_time >= read_time - 3*60,
f"EstimatedEndTime({estimated_end_time}) should be greater than the time when it was read({read_time})")
Expand Down
Loading