Create memory delegate #35176
Merged
Create memory delegate #35176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Delegate and the Instance.
…e and the Instance.
|
Review changes with SemanticDiff. |
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi and
doru91
|
PR #35176: Size comparison from fe34e81 to 1c29585 Full report (10 builds for nrfconnect, nxp, qpg, stm32, tizen)
|
|
PR #35176: Size comparison from fe34e81 to 0039d95 Full report (41 builds for bl602, bl702, bl702l, cyw30739, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
|
PR #35176: Size comparison from fe34e81 to f5e73d7 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
plauric
approved these changes
Aug 26, 2024
bzbarsky-apple
approved these changes
Aug 30, 2024
…o avoid memory leaks
|
PR #35176: Size comparison from e60e81a to 7fed454 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Aug 30, 2024
Co-authored-by: Boris Zbarsky <[email protected]>
|
PR #35176: Size comparison from e60e81a to 1df6ba4 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
kiel-apple
approved these changes
Aug 30, 2024
|
PR #35176: Size comparison from 7085588 to 7e67ed5 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Sep 10, 2024
* Created a memory delegate in service area cluster server. * Added supported areas and supported maps Remove methods to the MemoryDelegate and the Instance. * Added selected areas and progress Remove methods to the MemoryDelegate and the Instance. * Moved the `HandleSupportedAreasUpdated` into the server. * Updated the RVC example app according to the latest changes. * Added the suffix Raw to unsanitary methods in the MemoryDelegate. * Restyled by whitespace * Restyled by clang-format * Restyled by gn * Removed unused variables * Restyled by clang-format * Added a readme for the service area cluster. * Restyled by prettier-markdown * Renamed MemoryDelegate to StorageDelegate. * Added documentation noting how to handle MutableCharSpan out params to avoid memory leaks * Restyled by clang-format * Restyled by prettier-markdown * restarting restyler. * Added missed untraced files. * Restyled by clang-format * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34539.
This PR refactors the service area cluster. The aim is to prohibit SDK consumers from using unsanitary methods when implementing business logic methods in the
Delegate. This is achieved by creating a newStorageDelegateclass that is responsible for managing attribute storage without validation.The following has been done.
Delegateto theStorageDelegate.Instanceclass has been modified to additionally take aStorageDelegate.StorageDelegatehave been added to theInstanceclass.Instancemethods have been updated accordingly.StorageDelegateand theInstanceclass.HandleSupportedAreasUpdatedmethod into theInstanceclass as private.StorageDelegate, have been renamed with theRawsuffix.Fixes #35250. See this commit.