[Darwin] more MTRDevice/MTRDeviceController ivar/property raises
#35062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
PR #35062: Size comparison from b823a29 to 3a1ef4c Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
kiel-apple
force-pushed
the
darwin-more-property-raises
branch
from
3a1ef4c to
432146a
Compare
|
PR #35062: Size comparison from b7b6738 to 432146a Full report (12 builds for nrfconnect, nxp, qpg, stm32, tizen)
|
for subclass accessibility
|
PR #35062: Size comparison from b7b6738 to 48685a5 Full report (10 builds for nrfconnect, nxp, qpg, stm32, tizen)
|
|
PR #35062: Size comparison from b7b6738 to 1098a50 Full report (5 builds for nxp, stm32, tizen)
|
through `MTRDevice_Internal.h`
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille and
chapongatien
pullapprove
bot
requested review from
nivi-apple,
p0fi,
plauric,
rcasallas-silabs,
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
|
PR #35062: Size comparison from b7b6738 to e16836e Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
kiel-apple
commented
Aug 20, 2024
| @@ -82,6 +82,35 @@ | |||
|
|
|||
| @implementation MTRDevice_XPC | |||
|
|
|||
| #pragma mark - Behavior Overrides | |||
|
|
|||
| - (void)_addDelegate:(id<MTRDeviceDelegate>)delegate queue:(dispatch_queue_t)queue interestedPathsForAttributes:(NSArray * _Nullable)interestedPathsForAttributes interestedPathsForEvents:(NSArray * _Nullable)interestedPathsForEvents | |||
There was a problem hiding this comment.
obsoleted by #35084
|
ongoing work here, by and large the sentiment here has been fulfilled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
raise various properties and ivars in
MTRDeviceandMTRDeviceControllerfor use from subclasses.NOTE: tests currently not passing locally or in CI