[ICD] Implement storing of persistent keys in PSA for ICD server #34925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
github-actions
bot
added
crypto
app
test driver
icd
|
PR #34925: Size comparison from 3b90fed to 0c8a91e Full report (5 builds for cc32xx, stm32, tizen)
|
maciejbaczmanski
force-pushed
the
matter_icd_psa
branch
from
0c8a91e to
0eeae75
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin and
jepenven-silabs
maciejbaczmanski
force-pushed
the
matter_icd_psa
branch
from
d97f8fa to
1616225
Compare
|
PR #34925: Size comparison from c552dda to 1616225 Full report (88 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
maciejbaczmanski
force-pushed
the
matter_icd_psa
branch
2 times, most recently
from
e3687d9 to
85eae56
Compare
|
PR #34925: Size comparison from 30cff8e to 85eae56 Full report (88 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Damian-Nordic
approved these changes
Sep 10, 2024
maciejbaczmanski
force-pushed
the
matter_icd_psa
branch
from
e88a54a to
1baec8b
Compare
|
PR #34925: Size comparison from 22db90a to 1baec8b Full report (44 builds for bl602, bl702, bl702l, nrfconnect, stm32, telink, tizen)
|
Implement `keyAttributesBase` and add persistent lifetime functionality.
If entry is not found its key handle field must not be filled with last checked entry when using PSA as it will cause key slot to be cleared by accident.
maciejbaczmanski
force-pushed
the
matter_icd_psa
branch
from
1baec8b to
cb16562
Compare
|
PR #34925: Size comparison from 0adae42 to cb16562 Full report (90 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Sep 16, 2024
maciejbaczmanski
force-pushed
the
matter_icd_psa
branch
from
cb16562 to
d991fb5
Compare
Modify implementation of `PersistICDKey` not to depend on type of ICD key handle (AES, HMAC)
maciejbaczmanski
force-pushed
the
matter_icd_psa
branch
from
d991fb5 to
cc7a642
Compare
|
PR #34925: Size comparison from ba9faf2 to cc7a642 Full report (93 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…ject-chip#34925) * Refactor Key Attributes classes Implement `keyAttributesBase` and add persistent lifetime functionality. * Implement `FindFreeKeySlotInRange` for PSA key slots * Fix ICD CIP related build dependencies * Remake `ICDMonitoringTable::Find()` not to overwrite all entry fields If entry is not found its key handle field must not be filled with last checked entry when using PSA as it will cause key slot to be cleared by accident. * Add ICD CIP and DAC key slots for PSA * Implement `PersistICDKey` API * Implement setting key persitence for ICD server * Address PR comments Modify implementation of `PersistICDKey` not to depend on type of ICD key handle (AES, HMAC)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously keys for ICD server were store as volatile keys in PSA, causing failures in Check-In Protocol after device reboot. This PR implements storing of persistent keys in PSA for ICD server.
keyAttributesBaseand add persistent lifetime functionality.FindFreeKeySlotInRangefor PSA key slotsTesting
Tested on nRF52840 DK with PSA Crypto API enabled