[platform] Add empty platform_base source set #34883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When cross-compiling on Windows, bootstrap would fail because of some targets that are depending on platform_base source set, which is not defined for chip_device_platform None. Signed-off-by: marius-alex-tache <[email protected]>
|
Review changes with SemanticDiff. |
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
pullapprove
bot
requested review from
pidarped,
plauric,
rcasallas-silabs,
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
andy31415
approved these changes
Aug 8, 2024
|
PR #34883: Size comparison from ed59857 to 0f844f5 Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
doru91
approved these changes
Aug 9, 2024
GabrielCouturier
pushed a commit
to NXP/matter
that referenced
this pull request
Aug 9, 2024
…-chip#34883) * [platform] Add empty platform_base source set When cross-compiling on Windows, bootstrap would fail because of some targets that are depending on platform_base source set, which is not defined for chip_device_platform None. Signed-off-by: marius-alex-tache <[email protected]> * Restyled by gn --------- Signed-off-by: marius-alex-tache <[email protected]> Co-authored-by: Restyled.io <[email protected]> (cherry picked from commit 304df86)
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Aug 12, 2024
* [platform] Add empty platform_base source set When cross-compiling on Windows, bootstrap would fail because of some targets that are depending on platform_base source set, which is not defined for chip_device_platform None. Signed-off-by: marius-alex-tache <[email protected]> * Restyled by gn --------- Signed-off-by: marius-alex-tache <[email protected]> Co-authored-by: Restyled.io <[email protected]>
chapongatien
pushed a commit
to NXP/matter
that referenced
this pull request
Sep 16, 2024
…roject-chip#34883)" This reverts commit 9406830. Signed-off-by: marius-alex-tache <[email protected]>
marius-alex-tache
deleted the
add-empty-platform-base-for-platform-none
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cross-compiling on Windows, bootstrap would fail because of some targets that are depending on
platform_basesource set, which is not defined forchip_device_platformNone.Reference PR: https://github.com/project-chip/connectedhomeip/pull/34830/files