-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python: Add direct attribute paths to Read #34833
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supports one particular use case: read one or all endpoints, all clusters, specific (global) attribute. See spec 8.9.2.4. This is an allowed wildcard construct that is not currently expressable in the API. Test: Used on wildcard read for matter_testing_support. This is therefore tested on any test using that decorator - switch and timesync.
Review changes with SemanticDiff. Analyzed 2 of 2 files. Overall, the semantic diff is 34% smaller than the GitHub diff.
|
github-actions
bot
added
controller
tests
matter-1.4-te2-script-change
Script changes before end of Matter 1.4 TE2
labels
Aug 7, 2024
PR #34833: Size comparison from 212d6ab to a60ad8b Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #34833: Size comparison from 212d6ab to 3c4280b Increases above 0.2%:
Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248 and
hicklin
August 8, 2024 00:34
pullapprove
bot
requested review from
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
August 8, 2024 00:34
woody-apple
approved these changes
Aug 8, 2024
Fast tracking testing tools, given where we are. |
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Aug 12, 2024
* python: Add direct attribute paths to Read Supports one particular use case: read one or all endpoints, all clusters, specific (global) attribute. See spec 8.9.2.4. This is an allowed wildcard construct that is not currently expressable in the API. Test: Used on wildcard read for matter_testing_support. This is therefore tested on any test using that decorator - switch and timesync. * Restyled by isort --------- Co-authored-by: Restyled.io <[email protected]>
agners
added a commit
to home-assistant-libs/chip-wheels
that referenced
this pull request
Sep 17, 2024
This adds Attribute cache update improvements and some other minor fixes from the master branch to our 1.3 branch. Specifically, this integrates changes from the following PRs - project-chip/connectedhomeip#35380 - project-chip/connectedhomeip#34833 - project-chip/connectedhomeip#35557
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
controller
fast track
matter-1.4-te2-script-change
Script changes before end of Matter 1.4 TE2
review - pending
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports one particular use case: read one or all endpoints, all clusters, specific (global) attribute. See spec 8.9.2.4. This is an allowed wildcard construct that is not currently expressible in the API.
Test: Used on wildcard read for matter_testing_support. This is
therefore tested on any test using that decorator - switch
and timesync.