-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Add ICDM 5.1 Automated Test Script #34817
[ICD] Add ICDM 5.1 Automated Test Script #34817
Conversation
Review changes with SemanticDiff. Analyzed 2 of 4 files. Overall, the semantic diff is 28% smaller than the GitHub diff.
|
PR #34817: Size comparison from 068da61 to efaefec Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #34817: Size comparison from 3de6f04 to eadb9c9 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes:
- naming updates
- do not use
.value
for enums as that is harder to debug when things fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made the changes manually since I understand Mathieu is OOO currently.
Description
Adds the ICDM 5.1 Test Case automated script.
Test Plan PR: https://github.com/CHIP-Specifications/chip-test-plans/pull/4432
Tests
CI