Remove StatusIB::InitFromChipError. #34712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
PR #34712: Size comparison from 6f84526 to 83a17cd Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Aug 1, 2024
woody-apple
approved these changes
Aug 1, 2024
bzbarsky-apple
force-pushed
the
remove-InitFromChipError
branch
from
83a17cd to
5ef4120
Compare
pullapprove
bot
requested review from
arkq,
axelnxp,
bauerschwan,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
pullapprove
bot
requested review from
kkasperczyk-no,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley,
mkardous-silabs,
p0fi,
plauric,
rcasallas-silabs,
ReneJosefsen,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tima-q,
tobiasgraf,
wiba-nordic and
younghak-hwang
tcarmelveilleux
approved these changes
Aug 1, 2024
|
PR #34712: Size comparison from 5f6f3f1 to 5ef4120 Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
The constructor is a better fit for being able to convert CHIP_ERROR to ClusterStatusCode and then to StatusIB.
bzbarsky-apple
force-pushed
the
remove-InitFromChipError
branch
from
5ef4120 to
56fa941
Compare
|
PR #34712: Size comparison from 7dd6b4b to 56fa941 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
w8floosh
pushed a commit
to w8floosh/chip-fuzzing
that referenced
this pull request
Aug 4, 2024
The constructor is a better fit for being able to convert CHIP_ERROR to ClusterStatusCode and then to StatusIB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor is a better fit for being able to convert CHIP_ERROR to ClusterStatusCode and then to StatusIB.