Add TC feature definitions to General Commissioning Cluster XML files #34604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the "Terms and Conditions" (TC) feature definitions to the General Commissioning Cluster XML data model files. The changes include new attributes, commands, and commissioning errors related to the TC feature. Changes include: - Added TC feature definition with bitmask. - Introduced new commissioning errors related to TC: - RequiredTCNotAccepted - TCAcknowledgementsNotReceived - TCMinVersionNotMet - Added new attributes for TC: - TCAcceptedVersion - TCMinRequiredVersion - TCAcknowledgements - TCAcknowledgementsRequired - Added new commands for TC acknowledgements: - SetTCAcknowledgements - SetTCAcknowledgementsResponse These changes only modify the XML files. A follow-up commit will regenerate the necessary files.
|
Review changes with SemanticDiff. Analyzed 6 of 121 files. Overall, the semantic diff is 1% smaller than the GitHub diff. File Information
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
pullapprove
bot
requested review from
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
Question: How do I resolve these warnings that are thrown when I try to zap regen? |
|
PR #34604: Size comparison from b6cfeac to e175d46 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jul 29, 2024
|
@swan-amazon Note that this will fail CI until codegen is run. |
* Auto-update ZAP files. ```bash python3 ./scripts/tools/zap_regen_all.py ```
|
PR #34604: Size comparison from b6cfeac to 783f268 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
reviewed
Jul 30, 2024
|
PR #34604: Size comparison from 268e7ca to a504ee6 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
src/app/zap-templates/zcl/data-model/chip/general-commissioning-cluster.xml
Show resolved
Hide resolved
tcarmelveilleux
approved these changes
Jul 30, 2024
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
…project-chip#34604) * Add TC feature definitions to General Commissioning Cluster XML files This commit introduces the "Terms and Conditions" (TC) feature definitions to the General Commissioning Cluster XML data model files. The changes include new attributes, commands, and commissioning errors related to the TC feature. Changes include: - Added TC feature definition with bitmask. - Introduced new commissioning errors related to TC: - RequiredTCNotAccepted - TCAcknowledgementsNotReceived - TCMinVersionNotMet - Added new attributes for TC: - TCAcceptedVersion - TCMinRequiredVersion - TCAcknowledgements - TCAcknowledgementsRequired - Added new commands for TC acknowledgements: - SetTCAcknowledgements - SetTCAcknowledgementsResponse These changes only modify the XML files. A follow-up commit will regenerate the necessary files. * Zap regen for Enhanced Setup Flow, Terms and Conditions (TC) * Auto-update ZAP files. ```bash python3 ./scripts/tools/zap_regen_all.py ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the "Terms and Conditions" (TC) feature definitions to the General Commissioning Cluster XML data model files. The changes include new attributes, commands, and commissioning errors related to the TC feature.
Changes include:
These changes only modify the XML files. A follow-up commit will regenerate the necessary files.