Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TCP Keepalive for the received connection on the Server. #34602

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

pidarped
Copy link
Contributor

The TCP KeepAlive was enabled on the client side.
Enable TCP Keepalive from the server side as well.

The TCP KeepAlive was enabled on the client side.
Enable TCP Keepalive from the server side as well.
Copy link

Review changes with SemanticDiff.

Copy link

github-actions bot commented Jul 29, 2024

PR #34602: Size comparison from 275c8c9 to 4ffee5c

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 275c8c9 4ffee5c change % change
bl602 lighting-app bl602 FLASH 1276462 1276462 0 0.0
RAM 95576 95576 0 0.0
bl602+mfd FLASH 1290720 1290720 0 0.0
RAM 95728 95728 0 0.0
bl602+rpc FLASH 1315430 1315430 0 0.0
RAM 104000 104000 0 0.0
bl702 lighting-app bl702 FLASH 1097356 1097356 0 0.0
RAM 15257 15257 0 0.0
bl702+mfd FLASH 1108050 1108050 0 0.0
RAM 15401 15401 0 0.0
bl702+rpc FLASH 1187422 1187422 0 0.0
RAM 24253 24253 0 0.0
bl706-eth FLASH 880656 880656 0 0.0
RAM 27360 27360 0 0.0
bl706-wifi FLASH 1133608 1133608 0 0.0
RAM 14693 14693 0 0.0
bl702l lighting-app bl702l FLASH 1084254 1084254 0 0.0
RAM 21812 21812 0 0.0
bl702l+mfd FLASH 1095516 1095516 0 0.0
RAM 21964 21964 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 801924 801936 12 0.0
RAM 109428 109428 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 816684 816696 12 0.0
RAM 117028 117028 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 808652 808664 12 0.0
RAM 111308 111308 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 762416 762428 12 0.0
RAM 105448 105448 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747068 747080 12 0.0
RAM 105640 105640 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 606674 606682 8 0.0
RAM 204580 204580 0 0.0
lock CC3235SF_LAUNCHXL FLASH 652210 652218 8 0.0
RAM 204852 204852 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 671001 671001 0 0.0
RAM 77892 77892 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 690861 690861 0 0.0
RAM 80524 80524 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 690861 690861 0 0.0
RAM 80524 80524 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 647797 647797 0 0.0
RAM 72960 72960 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609713 609713 0 0.0
RAM 70884 70884 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629341 629341 0 0.0
RAM 73436 73436 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629341 629341 0 0.0
RAM 73436 73436 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 625409 625409 0 0.0
RAM 73900 73900 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 645117 645117 0 0.0
RAM 76452 76452 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 645117 645117 0 0.0
RAM 76452 76452 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 593637 593637 0 0.0
RAM 67860 67860 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 613489 613489 0 0.0
RAM 70492 70492 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 613489 613489 0 0.0
RAM 70492 70492 0 0.0
efr32 lighting-app BRD4187C FLASH 929000 928992 -8 -0.0
RAM 134700 134700 0 0.0
lock-app BRD4338a FLASH 734716 734716 0 0.0
RAM 207988 207988 0 0.0
window-app BRD4187C FLASH 1014780 1014772 -8 -0.0
RAM 126636 126636 0 0.0
esp32 all-clusters-app c3devkit DRAM 91236 91236 0 0.0
FLASH 1484588 1484588 0 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 117724 117724 0 0.0
FLASH 1553559 1553559 0 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4632 4632 0 0.0
FLASH 2710605 2710671 66 0.0
RAM 125200 125200 0 0.0
all-clusters-app debug unknown 5416 5416 0 0.0
FLASH 5913546 5913612 66 0.0
RAM 501016 501016 0 0.0
all-clusters-minimal-app debug unknown 5312 5312 0 0.0
FLASH 5315394 5315460 66 0.0
RAM 236592 236592 0 0.0
bridge-app debug unknown 5296 5296 0 0.0
FLASH 4707196 4707262 66 0.0
RAM 214048 214048 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12347182 12347248 66 0.0
RAM 553626 553626 0 0.0
chip-tool-ipv6only arm64 unknown 20208 20208 0 0.0
FLASH 11044732 11044780 48 0.0
RAM 603384 603384 0 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11343357 11343423 66 0.0
RAM 550394 550394 0 0.0
fabric-bridge-app debug unknown 4568 4568 0 0.0
FLASH 4463232 4463298 66 0.0
RAM 199248 199248 0 0.0
lighting-app debug+rpc+ui unknown 5968 5968 0 0.0
FLASH 5640753 5640817 64 0.0
RAM 225136 225136 0 0.0
lock-app debug unknown 5232 5232 0 0.0
FLASH 4757986 4758052 66 0.0
RAM 200704 200704 0 0.0
ota-provider-app debug unknown 4608 4608 0 0.0
FLASH 4402452 4402518 66 0.0
RAM 194880 194880 0 0.0
ota-requestor-app debug unknown 4544 4544 0 0.0
FLASH 4540598 4540664 66 0.0
RAM 199416 199416 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3000717 3000781 64 0.0
RAM 155304 155304 0 0.0
thermostat-no-ble arm64 unknown 9208 9208 0 0.0
FLASH 4259860 4259908 48 0.0
RAM 236368 236368 0 0.0
tv-app debug unknown 5504 5504 0 0.0
FLASH 5983549 5983613 64 0.0
RAM 578176 578176 0 0.0
tv-casting-app debug unknown 5168 5168 0 0.0
FLASH 10550253 10550317 64 0.0
RAM 638984 638984 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1503444 1503444 0 0.0
RAM 226728 226728 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 899288 899288 0 0.0
RAM 141787 141787 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 964860 964860 0 0.0
RAM 140891 140891 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 834276 834276 0 0.0
RAM 140612 140612 0 0.0
nxp contact k32w0+release FLASH 576084 576084 0 0.0
RAM 70112 70112 0 0.0
k32w1+release FLASH 591784 591784 0 0.0
RAM 74152 74152 0 0.0
light k32w0+release FLASH 611696 611696 0 0.0
RAM 69616 69616 0 0.0
k32w1+release FLASH 676528 676528 0 0.0
RAM 82928 82928 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1625364 1625364 0 0.0
RAM 210000 210000 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1535284 1535300 16 0.0
RAM 206728 206728 0 0.0
light cy8ckit_062s2_43012 FLASH 1462532 1462532 0 0.0
RAM 200000 200000 0 0.0
lock cy8ckit_062s2_43012 FLASH 1459668 1459684 16 0.0
RAM 224344 224344 0 0.0
qpg lighting-app qpg6105+debug FLASH 654812 654812 0 0.0
RAM 104844 104844 0 0.0
lock-app qpg6105+debug FLASH 612264 612264 0 0.0
RAM 99328 99328 0 0.0
stm32 light STM32WB5MM-DK FLASH 477112 477112 0 0.0
RAM 144452 144452 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 619000 619000 0 0.0
RAM 50664 50664 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 671198 671198 0 0.0
RAM 149120 149120 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 767122 767122 0 0.0
RAM 110284 110284 0 0.0
bridge-app tlsr9258a FLASH 677616 677616 0 0.0
RAM 91320 91320 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620592 620592 0 0.0
RAM 50708 50708 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 706436 706436 0 0.0
RAM 74036 74036 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 619276 619276 0 0.0
RAM 145276 145276 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 805362 805362 0 0.0
RAM 99200 99200 0 0.0
lock-app-dfu tlsr9528a FLASH 652370 652370 0 0.0
RAM 66740 66740 0 0.0
ota-requestor-app tlsr9258a FLASH 695652 695652 0 0.0
RAM 91004 91004 0 0.0
pump-app-usb tlsr9518adk80d FLASH 629946 629946 0 0.0
RAM 55484 55484 0 0.0
pump-controller-app tlsr9518adk80d FLASH 607548 607548 0 0.0
RAM 52728 52728 0 0.0
shell tlsr9518adk80d FLASH 466654 466654 0 0.0
RAM 68412 68412 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 627334 627334 0 0.0
RAM 52344 52344 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 651370 651370 0 0.0
RAM 56364 56364 0 0.0
thermostat tlsr9518adk80d FLASH 626256 626256 0 0.0
RAM 53052 53052 0 0.0
window-covering tlsr9118bdk40d FLASH 521510 521510 0 0.0
RAM 98264 98264 0 0.0
tizen all-clusters-app arm unknown 1588 1588 0 0.0
FLASH 1674432 1674456 24 0.0
RAM 49700 49700 0 0.0
chip-tool-ubsan arm unknown 2404 2404 0 0.0
FLASH 16397530 16397798 268 0.0
RAM 7197224 7197360 136 0.0

@mergify mergify bot merged commit d573916 into project-chip:master Jul 30, 2024
69 checks passed
j-ororke pushed a commit to j-ororke/connectedhomeip that referenced this pull request Jul 31, 2024
…ect-chip#34602)

The TCP KeepAlive was enabled on the client side.
Enable TCP Keepalive from the server side as well.
rochaferraz pushed a commit to rochaferraz/connectedhomeip that referenced this pull request Jul 31, 2024
…ect-chip#34602)

The TCP KeepAlive was enabled on the client side.
Enable TCP Keepalive from the server side as well.
@pidarped pidarped deleted the TCPKeepAliveOnServer branch November 12, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants