Fix: drop poll timer to avoid crash after TransferFacilitator object destruction #34538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kiel-apple
j0tunn
force-pushed
the
fix/bdx.sender.crash
branch
from
4f2e903 to
fe4c7fc
Compare
|
PR #34538: Size comparison from 95bf668 to fe4c7fc Full report (11 builds for cc32xx, mbed, nrfconnect, qpg, stm32, tizen)
|
j0tunn
force-pushed
the
fix/bdx.sender.crash
branch
from
fe4c7fc to
78d0bcf
Compare
|
PR #34538: Size comparison from 95bf668 to 78d0bcf Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Jul 29, 2024
In fact ResetTransfer does shut off the polling... But it does it in graceful manner: set the What I do here is more like forced reset. For the scenario where we use bdx sender object for the single session and than throw it away. For the multiple parallel ota sessions. |
Not in a way that's useful for "this object is going away" purposes. The fact that it polls again after you tell it to stop everything is so broken.... |
j0tunn
force-pushed
the
fix/bdx.sender.crash
branch
from
9347117 to
b2ebced
Compare
|
PR #34538: Size comparison from c7f5f65 to b2ebced Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Take a look now. I've replaced all logic based on |
j0tunn
force-pushed
the
fix/bdx.sender.crash
branch
2 times, most recently
from
e51a663 to
6768d39
Compare
j0tunn
force-pushed
the
fix/bdx.sender.crash
branch
from
6768d39 to
693dd38
Compare
|
PR #34538: Size comparison from ed59857 to 693dd38 Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
nivi-apple
reviewed
Aug 30, 2024
This patch is in our application about two months. And it was tested by our QA team. But honestly we are using BdxOtaSender object only once. And for each update session we create new one. So we can support parallel OTA sessions. The bug you are talking about just would be impossible after this change. This bug occurs because of the state ( |
nivi-apple
approved these changes
Sep 11, 2024
espressif-bot
pushed a commit
to espressif/esp-matter
that referenced
this pull request
Nov 19, 2024
- components/esp_matter_ota_provider: remove undefined mStopPolling member variable This is inspired from project-chip/connectedhomeip#34538 - examples/zap_light: remove the unused occupancy sensor dir from SRC_DIRS - Remove the esp_diag_data_store dependency from components/esp-matter
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should drop timer on destruction or process will crash trying to access mTransfer property of destroyed object.