Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API renames: chip::app::InteractionModel::* becomes chip::app::DataModel and renamed DataModel to Provider #34520

Merged
merged 13 commits into from
Jul 31, 2024
Merged

API renames: chip::app::InteractionModel::* becomes chip::app::DataModel and renamed DataModel to Provider #34520

merged 13 commits into from
Jul 31, 2024

Conversation

andy31415
Copy link
Contributor

the usage of InteractionModel felt off in code reviews and clashed with things like Protocols::InteractionModel.

Renamed the namespace to DataModel (which already exists) and renamed the DataModel class (and related) to Provider.

This change was mostly renames + sed + restyle. No functionality or logic changes should exist.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

PR #34520: Size comparison from ba949bf to 8cc9a0c

Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section ba949bf 8cc9a0c change % change
bl602 lighting-app bl602 FLASH 1274146 1274146 0 0.0
RAM 95424 95424 0 0.0
bl602+mfd FLASH 1288404 1288404 0 0.0
RAM 95568 95568 0 0.0
bl602+rpc FLASH 1313114 1313114 0 0.0
RAM 103848 103848 0 0.0
bl702 lighting-app bl702 FLASH 1095040 1095040 0 0.0
RAM 15245 15245 0 0.0
bl702+mfd FLASH 1105734 1105734 0 0.0
RAM 15397 15397 0 0.0
bl702+rpc FLASH 1185106 1185106 0 0.0
RAM 24245 24245 0 0.0
bl706-eth FLASH 878084 878084 0 0.0
RAM 27348 27348 0 0.0
bl706-wifi FLASH 1130780 1130780 0 0.0
RAM 14681 14681 0 0.0
bl702l lighting-app bl702l FLASH 1081938 1081938 0 0.0
RAM 21800 21800 0 0.0
bl702l+mfd FLASH 1093200 1093200 0 0.0
RAM 21960 21960 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 800260 800260 0 0.0
RAM 109276 109276 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 816684 816684 0 0.0
RAM 117020 117020 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 808652 808652 0 0.0
RAM 111308 111308 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 762416 762416 0 0.0
RAM 105448 105448 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747068 747068 0 0.0
RAM 105632 105632 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 606670 606670 0 0.0
RAM 204564 204564 0 0.0
lock CC3235SF_LAUNCHXL FLASH 652210 652210 0 0.0
RAM 204836 204836 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 669329 669329 0 0.0
RAM 77740 77740 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 689189 689189 0 0.0
RAM 80380 80380 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 689189 689189 0 0.0
RAM 80380 80380 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 646125 646125 0 0.0
RAM 72808 72808 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609737 609737 0 0.0
RAM 70884 70884 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629365 629365 0 0.0
RAM 73428 73428 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629365 629365 0 0.0
RAM 73428 73428 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 625433 625433 0 0.0
RAM 73900 73900 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 645141 645141 0 0.0
RAM 76444 76444 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 645141 645141 0 0.0
RAM 76444 76444 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 593661 593661 0 0.0
RAM 67852 67852 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 613513 613513 0 0.0
RAM 70492 70492 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 613513 613513 0 0.0
RAM 70492 70492 0 0.0
esp32 all-clusters-app c3devkit DRAM 90988 90988 0 0.0
FLASH 1472594 1472594 0 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 117468 117468 0 0.0
FLASH 1541975 1541975 0 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4632 4632 0 0.0
FLASH 2710565 2710629 64 0.0
RAM 125200 125200 0 0.0
all-clusters-app debug unknown 5416 5416 0 0.0
FLASH 5858050 5858146 96 0.0
RAM 494784 494784 0 0.0
all-clusters-minimal-app debug unknown 5312 5312 0 0.0
FLASH 5306984 5307080 96 0.0
RAM 235920 235920 0 0.0
bridge-app debug unknown 5296 5296 0 0.0
FLASH 4707482 4707578 96 0.0
RAM 213664 213664 0 0.0
chip-tool debug unknown 5784 5784 0 0.0
FLASH 12279672 12279736 64 0.0
RAM 548050 548050 0 0.0
chip-tool-ipv6only arm64 unknown 20128 20128 0 0.0
FLASH 10987228 10987292 64 0.0
RAM 597680 597680 0 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11300231 11300295 64 0.0
RAM 544890 544890 0 0.0
fabric-bridge-app debug unknown 4568 4568 0 0.0
FLASH 4453750 4453814 64 0.0
RAM 199024 199024 0 0.0
lighting-app debug+rpc+ui unknown 5968 5968 0 0.0
FLASH 5631569 5631665 96 0.0
RAM 224464 224464 0 0.0
lock-app debug unknown 5232 5232 0 0.0
FLASH 4757948 4758044 96 0.0
RAM 200704 200704 0 0.0
ota-provider-app debug unknown 4608 4608 0 0.0
FLASH 4402410 4402474 64 0.0
RAM 194880 194880 0 0.0
ota-requestor-app debug unknown 4544 4544 0 0.0
FLASH 4540558 4540654 96 0.0
RAM 199416 199416 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 2991629 2991725 96 0.0
RAM 153896 153896 0 0.0
thermostat-no-ble arm64 unknown 9208 9208 0 0.0
FLASH 4259812 4259876 64 0.0
RAM 236360 236360 0 0.0
tv-app debug unknown 5504 5504 0 0.0
FLASH 5983085 5983149 64 0.0
RAM 573856 573856 0 0.0
tv-casting-app debug unknown 5168 5168 0 0.0
FLASH 10491197 10491293 96 0.0
RAM 633352 633352 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1503444 1503444 0 0.0
RAM 226720 226720 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 889076 889076 0 0.0
RAM 141596 141596 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 957296 957296 0 0.0
RAM 140700 140700 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 832696 832696 0 0.0
RAM 140464 140464 0 0.0
nxp contact k32w0+release FLASH 576100 576100 0 0.0
RAM 70104 70104 0 0.0
k32w1+release FLASH 591808 591808 0 0.0
RAM 74144 74144 0 0.0
light k32w0+release FLASH 611696 611696 0 0.0
RAM 69608 69608 0 0.0
k32w1+release FLASH 676528 676528 0 0.0
RAM 82912 82912 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1613124 1613124 0 0.0
RAM 209768 209768 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1533476 1533476 0 0.0
RAM 206584 206584 0 0.0
light cy8ckit_062s2_43012 FLASH 1460500 1460500 0 0.0
RAM 199848 199848 0 0.0
lock cy8ckit_062s2_43012 FLASH 1459668 1459668 0 0.0
RAM 224328 224328 0 0.0
qpg lighting-app qpg6105+debug FLASH 653084 653084 0 0.0
RAM 104680 104680 0 0.0
lock-app qpg6105+debug FLASH 612288 612288 0 0.0
RAM 99320 99320 0 0.0
stm32 light STM32WB5MM-DK FLASH 475456 475456 0 0.0
RAM 144300 144300 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 633182 633182 0 0.0
RAM 50576 50576 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 660244 660244 0 0.0
RAM 148520 148520 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 780470 780470 0 0.0
RAM 113300 113300 0 0.0
bridge-app tlsr9258a FLASH 677462 677462 0 0.0
RAM 95384 95384 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 634766 634766 0 0.0
RAM 50620 50620 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 720638 720638 0 0.0
RAM 77196 77196 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 615524 615524 0 0.0
RAM 144724 144724 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 803328 803328 0 0.0
RAM 103128 103128 0 0.0
lock-app-dfu tlsr9528a FLASH 666594 666594 0 0.0
RAM 69900 69900 0 0.0
ota-requestor-app tlsr9258a FLASH 695498 695498 0 0.0
RAM 95068 95068 0 0.0
pump-app tlsr9518adk80d FLASH 618410 618410 0 0.0
RAM 57040 57040 0 0.0
pump-controller-app tlsr9518adk80d FLASH 607440 607440 0 0.0
RAM 56800 56800 0 0.0
shell tlsr9518adk80d FLASH 466520 466520 0 0.0
RAM 72488 72488 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 641384 641384 0 0.0
RAM 52248 52248 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 651262 651262 0 0.0
RAM 60436 60436 0 0.0
thermostat tlsr9518adk80d FLASH 626148 626148 0 0.0
RAM 57124 57124 0 0.0
window-covering tlsr9118bdk40d FLASH 519532 519532 0 0.0
RAM 97856 97856 0 0.0
tizen all-clusters-app arm unknown 1588 1588 0 0.0
FLASH 1645992 1645992 0 0.0
RAM 48908 48908 0 0.0
chip-tool-ubsan arm unknown 2388 2388 0 0.0
FLASH 16291606 16291686 80 0.0
RAM 7153512 7153504 -8 -0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

PR #34520: Size comparison from f6454bc to 5483f94

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section f6454bc 5483f94 change % change
bl602 lighting-app bl602 FLASH 1277116 1277116 0 0.0
RAM 95888 95888 0 0.0
bl602+mfd FLASH 1291374 1291374 0 0.0
RAM 96040 96040 0 0.0
bl602+rpc FLASH 1316084 1316084 0 0.0
RAM 104312 104312 0 0.0
bl702 lighting-app bl702 FLASH 1098268 1098268 0 0.0
RAM 15241 15241 0 0.0
bl702+mfd FLASH 1108962 1108962 0 0.0
RAM 15385 15385 0 0.0
bl702+rpc FLASH 1188334 1188334 0 0.0
RAM 24237 24237 0 0.0
bl706-eth FLASH 881302 881302 0 0.0
RAM 27344 27344 0 0.0
bl706-wifi FLASH 1134400 1134400 0 0.0
RAM 14677 14677 0 0.0
bl702l lighting-app bl702l FLASH 1085422 1085422 0 0.0
RAM 21796 21796 0 0.0
bl702l+mfd FLASH 1096428 1096428 0 0.0
RAM 21948 21948 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 802336 802336 0 0.0
RAM 109844 109844 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 817028 817028 0 0.0
RAM 117444 117444 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 809008 809008 0 0.0
RAM 111724 111724 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 762772 762772 0 0.0
RAM 105864 105864 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 747424 747424 0 0.0
RAM 106056 106056 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 610150 610150 0 0.0
RAM 205380 205380 0 0.0
lock CC3235SF_LAUNCHXL FLASH 652630 652630 0 0.0
RAM 205620 205620 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 671393 671393 0 0.0
RAM 78348 78348 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 691245 691245 0 0.0
RAM 80980 80980 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 691245 691245 0 0.0
RAM 80980 80980 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 648181 648181 0 0.0
RAM 73416 73416 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 610033 610033 0 0.0
RAM 71340 71340 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629669 629669 0 0.0
RAM 73892 73892 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629669 629669 0 0.0
RAM 73892 73892 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 625745 625745 0 0.0
RAM 74356 74356 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 645453 645453 0 0.0
RAM 76908 76908 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 645453 645453 0 0.0
RAM 76908 76908 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 599461 599461 0 0.0
RAM 68364 68364 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 619321 619321 0 0.0
RAM 70996 70996 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 619321 619321 0 0.0
RAM 70996 70996 0 0.0
efr32 lighting-app BRD4187C FLASH 929424 929424 0 0.0
RAM 135148 135148 0 0.0
lock-app BRD4338a FLASH 735092 735092 0 0.0
RAM 208436 208436 0 0.0
window-app BRD4187C FLASH 1015188 1015188 0 0.0
RAM 127084 127084 0 0.0
esp32 all-clusters-app c3devkit DRAM 91564 91564 0 0.0
FLASH 1488774 1488774 0 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 118052 118052 0 0.0
FLASH 1557623 1557623 0 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4632 4632 0 0.0
FLASH 2729707 2729803 96 0.0
RAM 128272 128272 0 0.0
all-clusters-app debug unknown 5416 5416 0 0.0
FLASH 5969488 5969552 64 0.0
RAM 505944 505944 0 0.0
all-clusters-minimal-app debug unknown 5312 5312 0 0.0
FLASH 5333072 5333136 64 0.0
RAM 239632 239632 0 0.0
bridge-app debug unknown 5296 5296 0 0.0
FLASH 4710520 4710584 64 0.0
RAM 216960 216960 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12396418 12396514 96 0.0
RAM 555418 555418 0 0.0
chip-tool-ipv6only arm64 unknown 20256 20256 0 0.0
FLASH 11084684 11084748 64 0.0
RAM 605296 605296 0 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 11377277 11377373 96 0.0
RAM 552154 552154 0 0.0
fabric-bridge-app debug unknown 4568 4568 0 0.0
FLASH 4466508 4466604 96 0.0
RAM 202128 202128 0 0.0
lighting-app debug+rpc+ui unknown 5968 5968 0 0.0
FLASH 5644433 5644497 64 0.0
RAM 228048 228048 0 0.0
lock-app debug unknown 5232 5232 0 0.0
FLASH 4761306 4761370 64 0.0
RAM 203616 203616 0 0.0
ota-provider-app debug unknown 4608 4608 0 0.0
FLASH 4405696 4405792 96 0.0
RAM 197760 197760 0 0.0
ota-requestor-app debug unknown 4544 4544 0 0.0
FLASH 4543842 4543906 64 0.0
RAM 202296 202296 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3019005 3019069 64 0.0
RAM 158472 158472 0 0.0
thermostat-no-ble arm64 unknown 9344 9344 0 0.0
FLASH 4343564 4343644 80 0.0
RAM 242112 242112 0 0.0
tv-app debug unknown 5504 5504 0 0.0
FLASH 5987333 5987429 96 0.0
RAM 582208 582208 0 0.0
tv-casting-app debug unknown 5168 5168 0 0.0
FLASH 10599981 10600045 64 0.0
RAM 642200 642200 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1503716 1503716 0 0.0
RAM 227296 227296 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 901780 901780 0 0.0
RAM 142084 142084 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 967232 967232 0 0.0
RAM 141188 141188 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 836704 836704 0 0.0
RAM 140944 140944 0 0.0
nxp contact k32w0+release FLASH 576396 576396 0 0.0
RAM 70416 70416 0 0.0
k32w1+release FLASH 592104 592104 0 0.0
RAM 74456 74456 0 0.0
light k32w0+release FLASH 612024 612024 0 0.0
RAM 69920 69920 0 0.0
k32w1+release FLASH 676936 676936 0 0.0
RAM 83232 83232 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1628748 1628748 0 0.0
RAM 210760 210760 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1538468 1538468 0 0.0
RAM 207536 207536 0 0.0
light cy8ckit_062s2_43012 FLASH 1463124 1463124 0 0.0
RAM 200776 200776 0 0.0
lock cy8ckit_062s2_43012 FLASH 1460148 1460148 0 0.0
RAM 225120 225120 0 0.0
qpg lighting-app qpg6105+debug FLASH 655100 655100 0 0.0
RAM 105148 105148 0 0.0
lock-app qpg6105+debug FLASH 612536 612536 0 0.0
RAM 99632 99632 0 0.0
stm32 light STM32WB5MM-DK FLASH 477472 477472 0 0.0
RAM 144756 144756 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 619294 619294 0 0.0
RAM 50936 50936 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 673656 673656 0 0.0
RAM 149412 149412 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 769576 769576 0 0.0
RAM 110612 110612 0 0.0
bridge-app tlsr9258a FLASH 677908 677908 0 0.0
RAM 91624 91624 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620886 620886 0 0.0
RAM 50980 50980 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 706750 706750 0 0.0
RAM 74316 74316 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 619674 619674 0 0.0
RAM 145580 145580 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 805760 805760 0 0.0
RAM 99504 99504 0 0.0
lock-app-dfu tlsr9528a FLASH 652664 652664 0 0.0
RAM 67012 67012 0 0.0
ota-requestor-app tlsr9258a FLASH 695942 695942 0 0.0
RAM 91308 91308 0 0.0
pump-app-usb tlsr9518adk80d FLASH 630242 630242 0 0.0
RAM 55756 55756 0 0.0
pump-controller-app tlsr9518adk80d FLASH 607842 607842 0 0.0
RAM 53000 53000 0 0.0
shell tlsr9518adk80d FLASH 466794 466794 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 627650 627650 0 0.0
RAM 52696 52696 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 651664 651664 0 0.0
RAM 56636 56636 0 0.0
thermostat tlsr9518adk80d FLASH 631430 631430 0 0.0
RAM 53376 53376 0 0.0
window-covering tlsr9118bdk40d FLASH 521804 521804 0 0.0
RAM 98536 98536 0 0.0
tizen all-clusters-app arm unknown 1588 1588 0 0.0
FLASH 1682740 1682740 0 0.0
RAM 51668 51668 0 0.0
chip-tool-ubsan arm unknown 2404 2404 0 0.0
FLASH 16453282 16453362 80 0.0
RAM 7226264 7226256 -8 -0.0

@mergify mergify bot merged commit 7b2adc6 into project-chip:master Jul 31, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@axelnxp axelnxp Awaiting requested review from axelnxp

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chapongatien chapongatien Awaiting requested review from chapongatien

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@doru91 doru91 Awaiting requested review from doru91

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller github review - approved tests workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andy31415 @tcarmelveilleux @bzbarsky-apple @andreilitvin