[logging] Add chip_device_platform == "none" to default target assert #34471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, chip_device_platform is set to none during bootstrap. This assert would fail, consequently bootstrap would fail, without adding this check. Signed-off-by: marius-alex-tache <[email protected]>
ksperling-apple
approved these changes
Jul 24, 2024
pullapprove
bot
requested review from
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kiel-apple
pullapprove
bot
requested review from
plauric,
rcasallas-silabs,
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #34471: Size comparison from 8306353 to 0719205 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, qpg, stm32, telink, tizen)
|
arkq
approved these changes
Jul 24, 2024
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
…project-chip#34471) On Windows, chip_device_platform is set to none during bootstrap. This assert would fail, consequently bootstrap would fail, without adding this check. Signed-off-by: marius-alex-tache <[email protected]>
GabrielCouturier
pushed a commit
to NXP/matter
that referenced
this pull request
Aug 2, 2024
…t target assert (project-chip#34471) On Windows, chip_device_platform is set to none during bootstrap. This assert would fail, consequently bootstrap would fail, without adding this check. Signed-off-by: marius-alex-tache <[email protected]> (cherry picked from commit 1306309)
GabrielCouturier
pushed a commit
to NXP/matter
that referenced
this pull request
Aug 9, 2024
…o default target assert (project-chip#34471)" This reverts commit f519686. Signed-off-by: Martin Girardot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, chip_device_platform is set to none during bootstrap. This assert would fail, consequently bootstrap would fail, without adding this check.