Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ICD] Update ICDM XML to match latest spec #34446

Merged
merged 4 commits into from
Jul 23, 2024
Merged

[ICD] Update ICDM XML to match latest spec #34446

merged 4 commits into from
Jul 23, 2024

Conversation

mkardous-silabs
Copy link
Contributor

Description

PR updates the ICDM xml to match the latest spec.

  • Adds maximum check-in back attribute
  • Adds the Dynamic SIT / LIT feature map
  • Updates the cluster revision

Spec PR yet to be merged : https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/10085

Tests

CI

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2024 •
edited
Loading

PR #34446: Size comparison from 27a653c to 1a13979

Full report (6 builds for cc32xx, mbed, stm32, tizen)
platform target config section 27a653c 1a13979 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 606630 606630 0 0.0
RAM 204572 204572 0 0.0
lock CC3235SF_LAUNCHXL FLASH 651970 651970 0 0.0
RAM 204844 204844 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1503276 1503276 0 0.0
RAM 226728 226728 0 0.0
stm32 light STM32WB5MM-DK FLASH 474064 474064 0 0.0
RAM 144268 144268 0 0.0
tizen all-clusters-app arm unknown 1584 1584 0 0.0
FLASH 1641256 1641256 0 0.0
RAM 48708 48708 0 0.0
chip-tool-ubsan arm unknown 2384 2384 0 0.0
FLASH 16310718 16324590 13872 0.1
RAM 7168520 7168744 224 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 22, 2024 •
edited
Loading

PR #34446: Size comparison from 27a653c to d59ed0d

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 27a653c d59ed0d change % change
bl602 lighting-app bl602 FLASH 1272020 1272020 0 0.0
RAM 95392 95392 0 0.0
bl602+mfd FLASH 1286278 1286278 0 0.0
RAM 95536 95536 0 0.0
bl602+rpc FLASH 1310988 1310988 0 0.0
RAM 103816 103816 0 0.0
bl702 lighting-app bl702 FLASH 1092926 1092926 0 0.0
RAM 15229 15229 0 0.0
bl702+mfd FLASH 1103876 1103876 0 0.0
RAM 15381 15381 0 0.0
bl702+rpc FLASH 1182992 1182992 0 0.0
RAM 24245 24245 0 0.0
bl706-eth FLASH 876226 876226 0 0.0
RAM 27348 27348 0 0.0
bl706-wifi FLASH 1128408 1128408 0 0.0
RAM 14681 14681 0 0.0
bl702l lighting-app bl702l FLASH 1080068 1080068 0 0.0
RAM 21800 21800 0 0.0
bl702l+mfd FLASH 1091074 1091074 0 0.0
RAM 21960 21960 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 798884 798884 0 0.0
RAM 109236 109236 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 816636 816636 0 0.0
RAM 117028 117028 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 808492 808492 0 0.0
RAM 111308 111308 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 761092 761092 0 0.0
RAM 105400 105400 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 746876 746876 0 0.0
RAM 105632 105632 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 606630 606630 0 0.0
RAM 204572 204572 0 0.0
lock CC3235SF_LAUNCHXL FLASH 651970 651970 0 0.0
RAM 204844 204844 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 668025 668025 0 0.0
RAM 77700 77700 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 687877 687877 0 0.0
RAM 80340 80340 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 687877 687877 0 0.0
RAM 80340 80340 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 644813 644813 0 0.0
RAM 72768 72768 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609561 609561 0 0.0
RAM 70876 70876 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629197 629197 0 0.0
RAM 73420 73420 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629197 629197 0 0.0
RAM 73420 73420 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 625273 625273 0 0.0
RAM 73892 73892 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 644981 644981 0 0.0
RAM 76436 76436 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 644981 644981 0 0.0
RAM 76436 76436 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 593637 593637 0 0.0
RAM 67844 67844 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 613489 613489 0 0.0
RAM 70484 70484 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 613489 613489 0 0.0
RAM 70484 70484 0 0.0
efr32 lighting-app BRD4187C FLASH 926112 926112 0 0.0
RAM 134532 134532 0 0.0
lock-app BRD4338a FLASH 734524 734516 -8 -0.0
RAM 208000 208000 0 0.0
window-app BRD4187C FLASH 1014604 1014604 0 0.0
RAM 126644 126644 0 0.0
esp32 all-clusters-app c3devkit DRAM 90932 90932 0 0.0
FLASH 1471314 1471314 0 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 117404 117404 0 0.0
FLASH 1540315 1540311 -4 -0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4624 4624 0 0.0
FLASH 2706913 2706913 0 0.0
RAM 125200 125200 0 0.0
all-clusters-app debug unknown 5392 5392 0 0.0
FLASH 5835478 5835510 32 0.0
RAM 494688 494752 64 0.0
all-clusters-minimal-app debug unknown 5304 5304 0 0.0
FLASH 5295130 5295130 0 0.0
RAM 235696 235696 0 0.0
bridge-app debug unknown 5288 5288 0 0.0
FLASH 4694462 4694462 0 0.0
RAM 212960 212960 0 0.0
chip-tool debug unknown 5776 5776 0 0.0
FLASH 12296496 12297074 578 0.0
RAM 548818 548882 64 0.0
chip-tool-ipv6only arm64 unknown 20168 20168 0 0.0
FLASH 11002556 11003036 480 0.0
RAM 598464 598528 64 0.0
fabric-admin debug unknown 5672 5672 0 0.0
FLASH 1131456 11315007 442 0.0
RAM 545658 545722 64 0.0
fabric-bridge-app debug unknown 4560 4560 0 0.0
FLASH 4448640 4448640 0 0.0
RAM 198992 198992 0 0.0
lighting-app debug+rpc+ui unknown 5968 5968 0 0.0
FLASH 5618529 5618529 0 0.0
RAM 224240 224240 0 0.0
lock-app debug unknown 5224 5224 0 0.0
FLASH 4752912 4752912 0 0.0
RAM 200672 200672 0 0.0
ota-provider-app debug unknown 4600 4600 0 0.0
FLASH 4397300 4397300 0 0.0
RAM 194848 194848 0 0.0
ota-requestor-app debug unknown 4536 4536 0 0.0
FLASH 4535114 4535114 0 0.0
RAM 199384 199384 0 0.0
shell debug unknown 4168 4168 0 0.0
FLASH 2979645 2979645 0 0.0
RAM 153736 153736 0 0.0
thermostat-no-ble arm64 unknown 9208 9208 0 0.0
FLASH 4256884 4256884 0 0.0
RAM 236336 236336 0 0.0
tv-app debug unknown 5496 5496 0 0.0
FLASH 5893615 5893615 0 0.0
RAM 342080 342080 0 0.0
tv-casting-app debug unknown 5160 5160 0 0.0
FLASH 10431405 10431949 544 0.0
RAM 403080 403080 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1503276 1503276 0 0.0
RAM 226728 226728 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 883308 883308 0 0.0
RAM 142311 142311 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 953548 953548 0 0.0
RAM 140739 140739 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 828160 828160 0 0.0
RAM 141179 141179 0 0.0
nxp contact k32w0+release FLASH 576100 576100 0 0.0
RAM 70096 70096 0 0.0
k32w1+release FLASH 591664 591664 0 0.0
RAM 74144 74144 0 0.0
light k32w0+release FLASH 610416 610416 0 0.0
RAM 69564 69564 0 0.0
k32w1+release FLASH 675192 675192 0 0.0
RAM 82880 82880 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1611636 1611636 0 0.0
RAM 209736 209736 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1531956 1531956 0 0.0
RAM 206544 206544 0 0.0
light cy8ckit_062s2_43012 FLASH 1458812 1458812 0 0.0
RAM 199808 199808 0 0.0
lock cy8ckit_062s2_43012 FLASH 1459468 1459468 0 0.0
RAM 224336 224336 0 0.0
qpg lighting-app qpg6105+debug FLASH 651740 651740 0 0.0
RAM 104644 104644 0 0.0
lock-app qpg6105+debug FLASH 612144 612144 0 0.0
RAM 99312 99312 0 0.0
stm32 light STM32WB5MM-DK FLASH 474064 474064 0 0.0
RAM 144268 144268 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 633102 633102 0 0.0
RAM 50576 50576 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 659054 659054 0 0.0
RAM 148488 148488 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 779246 779246 0 0.0
RAM 113260 113260 0 0.0
bridge-app tlsr9258a FLASH 676078 676078 0 0.0
RAM 95352 95352 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 634686 634686 0 0.0
RAM 50620 50620 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 720554 720554 0 0.0
RAM 77196 77196 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 614130 614130 0 0.0
RAM 144684 144684 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 801934 801934 0 0.0
RAM 103088 103088 0 0.0
lock-app-dfu tlsr9528a FLASH 666510 666510 0 0.0
RAM 69900 69900 0 0.0
ota-requestor-app tlsr9258a FLASH 695436 695436 0 0.0
RAM 95076 95076 0 0.0
pump-app tlsr9518adk80d FLASH 616942 616942 0 0.0
RAM 57000 57000 0 0.0
pump-controller-app tlsr9518adk80d FLASH 607352 607352 0 0.0
RAM 56800 56800 0 0.0
shell tlsr9518adk80d FLASH 466520 466520 0 0.0
RAM 72488 72488 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 641304 641304 0 0.0
RAM 52248 52248 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 651178 651178 0 0.0
RAM 60436 60436 0 0.0
thermostat tlsr9518adk80d FLASH 626242 626242 0 0.0
RAM 57132 57132 0 0.0
window-covering tlsr9118bdk40d FLASH 519448 519448 0 0.0
RAM 97848 97848 0 0.0
tizen all-clusters-app arm unknown 1584 1584 0 0.0
FLASH 1641256 1641256 0 0.0
RAM 48708 48708 0 0.0
chip-tool-ubsan arm unknown 2384 2384 0 0.0
FLASH 16310718 16324590 13872 0.1
RAM 7168520 7168744 224 0.0

@mergify mergify bot merged commit cc7672e into project-chip:master Jul 23, 2024
73 checks passed
@mkardous-silabs mkardous-silabs deleted the feature/update_icdm_cluster branch July 23, 2024 12:21
j-ororke pushed a commit to j-ororke/connectedhomeip that referenced this pull request Jul 31, 2024
@mkardous-silabs @j-ororke
[ICD] Update ICDM XML to match latest spec (project-chip#34446)
d5ac9d5 
* Update ICDM xml

* Generated files

* Update Cert Tests

* Fix zap generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cecille cecille cecille approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@axelnxp axelnxp Awaiting requested review from axelnxp

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chapongatien chapongatien Awaiting requested review from chapongatien

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@doru91 doru91 Awaiting requested review from doru91

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller darwin examples review - approved tests
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkardous-silabs @cecille @jmartinez-silabs