Fixing nil crashes #34362
Merged
Fixing nil crashes #34362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
|
PR #34362: Size comparison from 0840ca6 to fc8df7c Full report (20 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, nxp, qpg, stm32, tizen)
|
woody-apple
commented
Jul 17, 2024
anush-apple
approved these changes
Jul 17, 2024
|
PR #34362: Size comparison from 0840ca6 to 36ed49a Full report (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
woody-apple
commented
Jul 17, 2024
woody-apple
commented
Jul 17, 2024
woody-apple
commented
Jul 17, 2024
woody-apple
force-pushed
the
fix/nil-crash
branch
from
4966f5f to
0f0a975
Compare
woody-apple
commented
Jul 17, 2024
woody-apple
commented
Jul 17, 2024
|
PR #34362: Size comparison from 0840ca6 to 0f0a975 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
commented
Jul 17, 2024
woody-apple
force-pushed
the
fix/nil-crash
branch
from
0f0a975 to
5d49f82
Compare
|
PR #34362: Size comparison from a30dd12 to 5d49f82 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
The fix here is to fix a crasher, where our comparators compare nil, which crashes. When seeing this, I fixed this same anti-pattern in files that use it. I'm also cleaning up imports, since the files did not import the utilities function, so builds failed. I moved our includes to be imports, as is correct in the files affected. I mentioned I'll have a followup to fix all of these.
I don't think commit messages require review, as this is a squashed commit anyway from my attempts to fix builds as I discovered import breakage (well, lack of imports). |
andy31415
approved these changes
Jul 17, 2024
|
PR #34362: Size comparison from a30dd12 to 3bc1f09 Full report (54 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
woody-apple
force-pushed
the
fix/nil-crash
branch
from
3bc1f09 to
37c54cd
Compare
bzbarsky-apple
approved these changes
Jul 18, 2024
|
PR #34362: Size comparison from e73be38 to 37c54cd Full report (80 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
* Fixing imports in these files... needs a followup with proper xc-config * Moving to internal * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported nil crashes affecting customers, fixing patterns across Matter.framework.