Stop importing operator* and operator-> into Nullable. #34353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are serious footguns because:
1. They don't do checks that there is actually a value, and will silently
produce garbage.
2. They are really easy to accidentally use without a IsNull() check
(especially operator->).
I've now reviewed several PRs where people were misusing these and helped a few
other people who were misusing them and then not getting expected behavior, so
it would be better if we just didn't have these at all. Nullable is not a
pointer and people shouldn't treat it like one.
|
PR #34353: Size comparison from 4ed9b7e to 4d7dbd3 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bauerschwan
approved these changes
Jul 16, 2024
tcarmelveilleux
approved these changes
Jul 16, 2024
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
carol-apple,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no and
ksperling-apple
pullapprove
bot
requested review from
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley,
mkardous-silabs,
nivi-apple,
p0fi,
plauric,
rcasallas-silabs,
ReneJosefsen,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple and
younghak-hwang
tehampson
approved these changes
Jul 16, 2024
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
…34353) These are serious footguns because: 1. They don't do checks that there is actually a value, and will silently produce garbage. 2. They are really easy to accidentally use without a IsNull() check (especially operator->). I've now reviewed several PRs where people were misusing these and helped a few other people who were misusing them and then not getting expected behavior, so it would be better if we just didn't have these at all. Nullable is not a pointer and people shouldn't treat it like one.
erwinpan1
pushed a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Nov 11, 2024
…34353) These are serious footguns because: 1. They don't do checks that there is actually a value, and will silently produce garbage. 2. They are really easy to accidentally use without a IsNull() check (especially operator->). I've now reviewed several PRs where people were misusing these and helped a few other people who were misusing them and then not getting expected behavior, so it would be better if we just didn't have these at all. Nullable is not a pointer and people shouldn't treat it like one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are serious footguns because:
I've now reviewed several PRs where people were misusing these and helped a few other people who were misusing them and then not getting expected behavior, so it would be better if we just didn't have these at all. Nullable is not a pointer and people shouldn't treat it like one.