Darwin: Prohibit static initializers in Matter.framework #34168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksperling-apple
force-pushed
the
darwin-no-inits
branch
from
8eee709 to
b5ef358
Compare
Globals should either be "constinit" (i.e. use a constrexpr constructor) and trivially destructible, or use the Global<> / AtomicGlobal<> helpers.
ksperling-apple
force-pushed
the
darwin-no-inits
branch
from
b5ef358 to
5b18d13
Compare
|
PR #34168: Size comparison from 4ef104b to 5b18d13 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jul 3, 2024
|
PR #34168: Size comparison from 4ef104b to b759ffe Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Jul 3, 2024
pullapprove
bot
requested review from
andy31415,
arkq,
axelnxp,
bauerschwan,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91 and
fessehaeve
pullapprove
bot
requested review from
kkasperczyk-no,
kpschoedel,
lazarkov,
LuDuda,
mhazley,
mspang,
p0fi,
pidarped,
plauric,
ReneJosefsen,
robszewczyk,
saurabhst,
sharadb-amazon,
tcarmelveilleux,
tima-q,
tobiasgraf,
turon,
wiba-nordic,
younghak-hwang,
yufengwangca and
yunhanw-google
ASAN and TSAN both use initializers, so enabling it for Debug builds breaks those in CI. Ideally we could just turn it off for builds that actually use *SAN but that probably requires migrating the project to use xcconfig files.
|
PR #34168: Size comparison from 4ef104b to 8333a53 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Jul 10, 2024
…p#34168) * Darwin: Prohibit static initializers in Matter.framework Globals should either be "constinit" (i.e. use a constrexpr constructor) and trivially destructible, or use the Global<> / AtomicGlobal<> helpers. * Update src/messaging/ReliableMessageProtocolConfig.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Use correct value in ReliableMessageProtocolConfig unit test override * Enable -no_inits for release builds only ASAN and TSAN both use initializers, so enabling it for Debug builds breaks those in CI. Ideally we could just turn it off for builds that actually use *SAN but that probably requires migrating the project to use xcconfig files. --------- Co-authored-by: Boris Zbarsky <[email protected]>
woody-apple
added a commit
that referenced
this pull request
Jul 10, 2024
)" This reverts commit f199ba4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Globals should either be "constinit" (i.e. use a constrexpr constructor) and trivially destructible, or use the
Global<>/AtomicGlobal<>helpers.