Disentangle data model tests by moving fixtures into their own file #34154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The data model tests all had linker dependencies on each other, which meant
that running any of Test{Read,Write,Commands} would run the tests from all of
them, because the global fixture function from that test was required.
This change moves all those fixture functions into DataModelFixtures.cpp.
Also disambiguate the enum types and control variable names involved.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no and
kpschoedel
pullapprove
bot
requested review from
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #34154: Size comparison from 247f05d to c7741ba Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jul 2, 2024
andy31415
reviewed
Jul 2, 2024
andy31415
reviewed
Jul 2, 2024
bzbarsky-apple
approved these changes
Jul 2, 2024
- Add more comments to DataModelFixtures.h - Use ScopedChangeOnly for the fixture control variables - Extend ScopedChange to allow assignments within the scope
andy31415
approved these changes
Jul 2, 2024
|
PR #34154: Size comparison from 247f05d to 9a9ced3 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Jul 10, 2024
…roject-chip#34154) * Disentangle data model tests by moving fixtures into their own file The data model tests all had linker dependencies on each other, which meant that running any of Test{Read,Write,Commands} would run the tests from all of them, because the global fixture function from that test was required. This change moves all those fixture functions into DataModelFixtures.cpp. Also disambiguate the enum types and control variable names involved. * Address review comments - Add more comments to DataModelFixtures.h - Use ScopedChangeOnly for the fixture control variables - Extend ScopedChange to allow assignments within the scope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data model tests all had linker dependencies on each other, which meant that running any of Test{Read,Write,Commands} would run the tests from all of them, because the global fixture function from that test was required.
This change moves all those fixture functions into DataModelFixtures.cpp. Also disambiguate the enum types and control variable names involved.