Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ESP32] Fixing NULL MAC Address Issue for Thread devices in ESP32. #34046

Merged
merged 1 commit into from
Jun 24, 2024
Merged

[ESP32] Fixing NULL MAC Address Issue for Thread devices in ESP32. #34046

merged 1 commit into from
Jun 24, 2024

Conversation

shripad621git
Copy link
Contributor

Problem

  • The mac address read using read network-interfaces of the general-commissioning cluster using chip-tool returned NULL value in case of thread.

Change Overview:

  • Fixed the issue by providing an api in case of thread devices to retrieve the mac address.

Testing

  • Tested the lighting-app esp32 with esp32h2 and esp32c6-thread with and without the changes.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 24, 2024 •
edited
Loading

PR #34046: Size comparison from 07ac2f1 to 820d1a4

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 07ac2f1 820d1a4 change % change
bl602 lighting-app bl602 FLASH 1270550 1270550 0 0.0
RAM 95328 95328 0 0.0
bl602+mfd FLASH 1284828 1284828 0 0.0
RAM 95480 95480 0 0.0
bl602+rpc FLASH 1309750 1309750 0 0.0
RAM 103760 103760 0 0.0
bl702 lighting-app bl702 FLASH 1091446 1091446 0 0.0
RAM 14897 14897 0 0.0
bl702+mfd FLASH 1102140 1102140 0 0.0
RAM 15049 15049 0 0.0
bl702+rpc FLASH 1181256 1181256 0 0.0
RAM 23925 23925 0 0.0
bl706-eth FLASH 874790 874790 0 0.0
RAM 27016 27016 0 0.0
bl706-wifi FLASH 1127090 1127090 0 0.0
RAM 14349 14349 0 0.0
bl702l lighting-app bl702l FLASH 1078332 1078332 0 0.0
RAM 21468 21468 0 0.0
bl702l+mfd FLASH 1089594 1089594 0 0.0
RAM 21628 21628 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 798004 798004 0 0.0
RAM 103088 103088 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 813768 813768 0 0.0
RAM 113568 113568 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 803292 803292 0 0.0
RAM 107688 107688 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 756068 756068 0 0.0
RAM 101788 101788 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 741732 741732 0 0.0
RAM 102036 102036 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 605766 605766 0 0.0
RAM 204512 204512 0 0.0
lock CC3235SF_LAUNCHXL FLASH 650786 650786 0 0.0
RAM 204772 204772 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 665785 665785 0 0.0
RAM 75100 75100 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 685645 685645 0 0.0
RAM 77732 77732 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 685645 685645 0 0.0
RAM 77732 77732 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 642573 642573 0 0.0
RAM 70168 70168 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 608345 608345 0 0.0
RAM 70804 70804 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 627973 627973 0 0.0
RAM 73356 73356 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 627973 627973 0 0.0
RAM 73356 73356 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 623833 623833 0 0.0
RAM 73820 73820 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 643541 643541 0 0.0
RAM 76372 76372 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 643541 643541 0 0.0
RAM 76372 76372 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 592397 592397 0 0.0
RAM 67788 67788 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 612249 612249 0 0.0
RAM 70420 70420 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 612249 612249 0 0.0
RAM 70420 70420 0 0.0
efr32 lighting-app BRD4187C FLASH 888136 888128 -8 -0.0
RAM 183424 183424 0 0.0
lock-app BRD4338a FLASH 699864 699864 0 0.0
RAM 242228 242228 0 0.0
window-app BRD4187C FLASH 969748 969748 0 0.0
RAM 167856 167856 0 0.0
esp32 all-clusters-app c3devkit DRAM 88324 88324 0 0.0
FLASH 1468846 1468846 0 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 114796 114796 0 0.0
FLASH 1537971 1537971 0 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4592 4592 0 0.0
FLASH 2528240 2528240 0 0.0
RAM 125072 125072 0 0.0
all-clusters-app debug unknown 5368 5368 0 0.0
FLASH 5577966 5577966 0 0.0
RAM 479304 479304 0 0.0
all-clusters-minimal-app debug unknown 5288 5288 0 0.0
FLASH 5050424 5050424 0 0.0
RAM 232856 232856 0 0.0
bridge-app debug unknown 5256 5256 0 0.0
FLASH 4476456 4476456 0 0.0
RAM 212768 212768 0 0.0
chip-tool debug unknown 5728 5728 0 0.0
FLASH 11548279 11548279 0 0.0
RAM 531386 531386 0 0.0
chip-tool-ipv6only arm64 unknown 19816 19816 0 0.0
FLASH 10680468 10680468 0 0.0
RAM 580120 580120 0 0.0
fabric-admin debug unknown 5584 5584 0 0.0
FLASH 10547175 10547175 0 0.0
RAM 525466 525466 0 0.0
fabric-bridge-app debug unknown 5264 5264 0 0.0
FLASH 4346984 4346984 0 0.0
RAM 204896 204896 0 0.0
lighting-app debug+rpc+ui unknown 5904 5904 0 0.0
FLASH 5372466 5372466 0 0.0
RAM 221672 221672 0 0.0
lock-app debug unknown 5192 5192 0 0.0
FLASH 4540056 4540056 0 0.0
RAM 200192 200192 0 0.0
ota-provider-app debug unknown 4576 4576 0 0.0
FLASH 4195816 4195816 0 0.0
RAM 194432 194432 0 0.0
ota-requestor-app debug unknown 4512 4512 0 0.0
FLASH 4321304 4321304 0 0.0
RAM 199088 199088 0 0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2793693 2793693 0 0.0
RAM 150416 150416 0 0.0
thermostat-no-ble arm64 unknown 9184 9184 0 0.0
FLASH 4167108 4167108 0 0.0
RAM 235784 235784 0 0.0
tv-app debug unknown 5472 5472 0 0.0
FLASH 5593704 5593704 0 0.0
RAM 341672 341672 0 0.0
tv-casting-app debug unknown 5096 5096 0 0.0
FLASH 9595958 9595958 0 0.0
RAM 348848 348848 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1502084 1502084 0 0.0
RAM 226672 226672 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 880800 880800 0 0.0
RAM 139693 139693 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 951612 951612 0 0.0
RAM 138121 138121 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 826356 826356 0 0.0
RAM 138591 138591 0 0.0
nxp contact k32w0+release FLASH 575620 575620 0 0.0
RAM 70024 70024 0 0.0
k32w1+release FLASH 590744 590744 0 0.0
RAM 74056 74056 0 0.0
light k32w0+release FLASH 609696 609696 0 0.0
RAM 69500 69500 0 0.0
k32w1+release FLASH 674240 674240 0 0.0
RAM 82808 82808 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1613348 1613348 0 0.0
RAM 207132 207132 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1534116 1534116 0 0.0
RAM 204036 204036 0 0.0
light cy8ckit_062s2_43012 FLASH 1460996 1460996 0 0.0
RAM 197316 197316 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462860 1462860 0 0.0
RAM 224380 224380 0 0.0
qpg lighting-app qpg6105+debug FLASH 650608 650608 0 0.0
RAM 104556 104556 0 0.0
lock-app qpg6105+debug FLASH 610708 610708 0 0.0
RAM 99232 99232 0 0.0
stm32 light STM32WB5MM-DK FLASH 472048 472048 0 0.0
RAM 141652 141652 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 632146 632146 0 0.0
RAM 50528 50528 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 657038 657038 0 0.0
RAM 145872 145872 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 777102 777102 0 0.0
RAM 110684 110684 0 0.0
bridge-app tlsr9258a FLASH 675130 675130 0 0.0
RAM 95304 95304 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 633730 633730 0 0.0
RAM 50572 50572 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 719508 719508 0 0.0
RAM 77148 77148 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 612180 612180 0 0.0
RAM 142104 142104 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 799734 799734 0 0.0
RAM 100508 100508 0 0.0
lock-app-dfu tlsr9528a FLASH 665294 665294 0 0.0
RAM 69860 69860 0 0.0
ota-requestor-app tlsr9258a FLASH 694460 694460 0 0.0
RAM 95028 95028 0 0.0
pump-app tlsr9518adk80d FLASH 615994 615994 0 0.0
RAM 56952 56952 0 0.0
pump-controller-app tlsr9518adk80d FLASH 606378 606378 0 0.0
RAM 56752 56752 0 0.0
shell tlsr9518adk80d FLASH 466170 466170 0 0.0
RAM 72484 72484 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 640090 640090 0 0.0
RAM 52200 52200 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 650204 650204 0 0.0
RAM 60388 60388 0 0.0
thermostat tlsr9518adk80d FLASH 625268 625268 0 0.0
RAM 57084 57084 0 0.0
window-covering tlsr9118bdk40d FLASH 518726 518726 0 0.0
RAM 97800 97800 0 0.0
tizen all-clusters-app arm unknown 1560 1560 0 0.0
FLASH 1633100 1633100 0 0.0
RAM 46020 46020 0 0.0
chip-tool-ubsan arm unknown 2364 2364 0 0.0
FLASH 15882050 15882050 0 0.0
RAM 6972112 6972112 0 0.0

@mergify mergify bot merged commit 504608b into project-chip:master Jun 24, 2024
68 checks passed
andy31415 pushed a commit to andy31415/connectedhomeip that referenced this pull request Jun 24, 2024
@andreilitvin
Revert "Fixed the hardware macaddress isssue for thread interfaces (p…
cf75fbf 
…roject-chip#34046)"

This reverts commit 504608b.
andy31415 added a commit that referenced this pull request Jun 24, 2024
@andy31415 @andreilitvin
Revert "Fixed the hardware macaddress isssue for thread interfaces (#…
6e9053b 
…34046)" (#34062)

This reverts commit 504608b.

Co-authored-by: Andrei Litvin <[email protected]>
austina-csa pushed a commit to austina-csa/connectedhomeip that referenced this pull request Jul 10, 2024
@shripad621git @austina-csa
Fixed the hardware macaddress isssue for thread interfaces (project-c…
0abb6ea 
…hip#34046)
austina-csa pushed a commit to austina-csa/connectedhomeip that referenced this pull request Jul 10, 2024
@andy31415 @andreilitvin @austina-csa
Revert "Fixed the hardware macaddress isssue for thread interfaces (p…
87217c6 
…roject-chip#34046)" (project-chip#34062)

This reverts commit 504608b.

Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
esp32 fast track platform review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shripad621git @andy31415