[Python] Fix DeviceProxyWrapper __del__ #34011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During tests the following unrelated Exception was raised:
```
Exception ignored in: <function DeviceProxyWrapper.__del__ at 0x7f12177b7a60>
Traceback (most recent call last):
File "/__w/connectedhomeip/connectedhomeip/out/venv/lib/python3.9/site-packages/chip/ChipDeviceCtrl.py", line 306, in __del__
if (self._proxyType == self.DeviceProxyType.OPERATIONAL and self.self._dmLib is not None and hasattr(builtins, 'chipStack') and builtins.chipStack is not None):
AttributeError: 'DeviceProxyWrapper' object has no attribute 'self'
Exception ignored in: <function DeviceProxyWrapper.__del__ at 0x7f12177b7a60>
Traceback (most recent call last):
File "/__w/connectedhomeip/connectedhomeip/out/venv/lib/python3.9/site-packages/chip/ChipDeviceCtrl.py", line 306, in __del__
if (self._proxyType == self.DeviceProxyType.OPERATIONAL and self.self._dmLib is not None and hasattr(builtins, 'chipStack') and builtins.chipStack is not None):
AttributeError: 'DeviceProxyWrapper' object has no attribute 'self'
```
This fixes the issue by removing the extra `self` in the condition.
|
PR #34011: Size comparison from f6ac926 to f8c72ae Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
arkq
approved these changes
Jun 19, 2024
andy31415
approved these changes
Jun 19, 2024
diogopintodsr
pushed a commit
to diogopintodsr/connectedhomeip
that referenced
this pull request
Jun 20, 2024
During tests the following unrelated Exception was raised:
```
Exception ignored in: <function DeviceProxyWrapper.__del__ at 0x7f12177b7a60>
Traceback (most recent call last):
File "/__w/connectedhomeip/connectedhomeip/out/venv/lib/python3.9/site-packages/chip/ChipDeviceCtrl.py", line 306, in __del__
if (self._proxyType == self.DeviceProxyType.OPERATIONAL and self.self._dmLib is not None and hasattr(builtins, 'chipStack') and builtins.chipStack is not None):
AttributeError: 'DeviceProxyWrapper' object has no attribute 'self'
Exception ignored in: <function DeviceProxyWrapper.__del__ at 0x7f12177b7a60>
Traceback (most recent call last):
File "/__w/connectedhomeip/connectedhomeip/out/venv/lib/python3.9/site-packages/chip/ChipDeviceCtrl.py", line 306, in __del__
if (self._proxyType == self.DeviceProxyType.OPERATIONAL and self.self._dmLib is not None and hasattr(builtins, 'chipStack') and builtins.chipStack is not None):
AttributeError: 'DeviceProxyWrapper' object has no attribute 'self'
```
This fixes the issue by removing the extra `self` in the condition.
agners
added a commit
to agners/chip-wheels
that referenced
this pull request
Jun 20, 2024
This adds commissioning API updates from the master branch to our 1.3 based branch. This makes the commissioning API more Pythonic and allows to call them from the asyncio event loop directly. Specifically, this integrates changes from the following PRs - project-chip/connectedhomeip#33954 - project-chip/connectedhomeip#33905 - project-chip/connectedhomeip#34011 - project-chip/connectedhomeip#34001 - project-chip/connectedhomeip#33989
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Jul 10, 2024
During tests the following unrelated Exception was raised:
```
Exception ignored in: <function DeviceProxyWrapper.__del__ at 0x7f12177b7a60>
Traceback (most recent call last):
File "/__w/connectedhomeip/connectedhomeip/out/venv/lib/python3.9/site-packages/chip/ChipDeviceCtrl.py", line 306, in __del__
if (self._proxyType == self.DeviceProxyType.OPERATIONAL and self.self._dmLib is not None and hasattr(builtins, 'chipStack') and builtins.chipStack is not None):
AttributeError: 'DeviceProxyWrapper' object has no attribute 'self'
Exception ignored in: <function DeviceProxyWrapper.__del__ at 0x7f12177b7a60>
Traceback (most recent call last):
File "/__w/connectedhomeip/connectedhomeip/out/venv/lib/python3.9/site-packages/chip/ChipDeviceCtrl.py", line 306, in __del__
if (self._proxyType == self.DeviceProxyType.OPERATIONAL and self.self._dmLib is not None and hasattr(builtins, 'chipStack') and builtins.chipStack is not None):
AttributeError: 'DeviceProxyWrapper' object has no attribute 'self'
```
This fixes the issue by removing the extra `self` in the condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During some tests (e.g. TC_IDM_1_2) the following unrelated Exception is being raised:
This fixes the issue by removing the extra
selfin the condition.