-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a String Echo Request and Echo Response Command to the Unit testing cluster #34004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pidarped
force-pushed
the
UnitTestingEchoCommand
branch
from
June 19, 2024 00:54
8e03127
to
489c8b7
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple and
kkasperczyk-no
June 19, 2024 00:55
pullapprove
bot
requested review from
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
June 19, 2024 00:55
PR #34004: Size comparison from c30f32f to 489c8b7 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
approved these changes
Jun 19, 2024
If we can split the generate portion as a separate commit, it will help the review a lot. |
bzbarsky-apple
approved these changes
Jun 21, 2024
yunhanw-google
approved these changes
Jun 22, 2024
pidarped
force-pushed
the
UnitTestingEchoCommand
branch
from
June 25, 2024 00:59
489c8b7
to
f9b04f1
Compare
PR #34004: Size comparison from 66e0663 to f9b04f1 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pidarped
force-pushed
the
UnitTestingEchoCommand
branch
from
June 27, 2024 00:46
f9b04f1
to
c0fdd8f
Compare
PR #34004: Size comparison from 2908685 to c0fdd8f Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pidarped
force-pushed
the
UnitTestingEchoCommand
branch
from
July 1, 2024 16:39
c0fdd8f
to
d0c5d42
Compare
PR #34004: Size comparison from 4672e1a to d0c5d42 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…ng cluster The Command Request takes a string as argument that is echoed back in the Command response. The string can be large to enable Command testing for large payloads over a TCP-based session. Example ChipTool invocation: ./chip-tool unittesting string-echo-request "aaaaaaaaaaaaa" <node-id> <endpoint-id> ./chip-tool unittesting string-echo-request "aaaaaaa...aaaaaa" <node-id> <endpoint-id> --allow-large-payload true
pidarped
force-pushed
the
UnitTestingEchoCommand
branch
from
July 2, 2024 16:10
d0c5d42
to
49a3c9c
Compare
PR #34004: Size comparison from 005f1b4 to 49a3c9c Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Command Request takes a string as argument that is echoed back in the Command response.
The string can be large to enable Command testing for large payloads over a TCP-based session.
Example ChipTool invocation:
./chip-tool unittesting string-echo-request "aaaaaaaaaaaaa"
./chip-tool unittesting string-echo-request "aaaaaaa...aaaaaa" --allow-large-payload true