Add --wifipaf commission in chip-tool and apps of Linux platform #33977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
crlonxp
commented
Jun 18, 2024
•
crlonxp
commented
github-actions
bot
added
tools
examples
transport
setup payload
platform
linux
lib
controller
app
shell
labels
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs and
jmartinez-silabs
Co-authored-by: Boris Zbarsky <[email protected]>
* Add to end of the queue in OnDiscoveredDeviceOverWifiPAF() * Factor out the long expression into local Signed-off-by: Lo,Chin-Ran <[email protected]>
Signed-off-by: Lo,Chin-Ran <[email protected]>
…allback function Signed-off-by: Lo,Chin-Ran <[email protected]>
Signed-off-by: Lo,Chin-Ran <[email protected]>
…a_supplicant Signed-off-by: Lo,Chin-Ran <[email protected]>
* Add more tests in QRCode test Signed-off-by: Lo,Chin-Ran <[email protected]>
* Fix the problem to add tests in TestQRCode.cpp * Use a list to track the validation of the caller object. Signed-off-by: Lo,Chin-Ran <[email protected]>
Signed-off-by: Lo,Chin-Ran <[email protected]>
|
PR #33977: Size comparison from e8fb908 to 96e5c60 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
Fast tracking this, this was caught in limbo, I don't know why. It appears to not be NXP only, but the generic support needed. Rebasing to see if this builds. |
bzbarsky-apple
previously requested changes
Jul 29, 2024
|
Discussed with @bzbarsky-apple , this meets the current bar for FC, but agree this needs significant follow up work. |
|
Fast tracking, given this builds, and is ready for FC. |
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
…ject-chip#33977) * [NXP] Add --wifi-paf commission in chip-tool and apps of Linux platform * Need to enable the function by adding "chip_device_config_enable_wifipaf=true" * chip-tool: Add wifi-paf option for pairing. Example: $ chip-tool pairing wifi-paf 1 ap_ssid ap_pwd [setup-pin-code] [discriminator] * apps: Add --wifi-paf. Example: $ chip-all-clusters-app --wifi --wifi-paf Note: Need the usd functions of wpa_supplicant to run this option Signed-off-by: Lo,Chin-Ran <[email protected]> * Restyled by clang-format * Restyled by gn * * Add the missing compile macro * Restyled by clang-format * Update src/controller/CHIPDeviceController.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update src/include/platform/ConnectivityManager.h Co-authored-by: Boris Zbarsky <[email protected]> * Update examples/platform/linux/Options.cpp Co-authored-by: Karsten Sperling <[email protected]> * Change by following the review's comment: * Change the name of option to [pair_mode]-[network] * Remove redundant compile flags * Move to start the Wi-Fi Manager in initialization stage * Unconditional the defintion * Add the cancel-publish / cancel-subscribe dbus interface * Fix bugs: - Redundant callback function registration - Remove the incorrect StackLock Signed-off-by: Lo,Chin-Ran <[email protected]> * Restyled by clang-format * Change by following the review's comment: - Unconditional functions in SetUpCodePairer - Change the description of the comment Signed-off-by: Lo,Chin-Ran <[email protected]> * * Add the identifier to distinguish connections * Unconditional the SetupCode verification Signed-off-by: Lo,Chin-Ran <[email protected]> * Restyled by clang-format * Add RendezvousInformationFlag::kWiFiPAF to tests of TestQRCode Signed-off-by: Lo,Chin-Ran <[email protected]> * Restyled by clang-format * * Add code-wifi to do WiFiPAF by using code. example: - Linux DUT: sudo ./chip-all-clusters-app --wifi --wifipaf - Controller: sudo ./chip-tool pairing code-wifi 1 ap_ssid ap_pwd MT:-24J0SGJ10KA0648G00 Signed-off-by: Lo,Chin-Ran <[email protected]> * Restyled by clang-format * Update src/transport/raw/PeerAddress.h Co-authored-by: Boris Zbarsky <[email protected]> * Update examples/chip-tool/commands/payload/SetupPayloadParseCommand.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update src/include/platform/CHIPDeviceConfig.h Co-authored-by: Boris Zbarsky <[email protected]> * Change by following the review's comment: * Add to end of the queue in OnDiscoveredDeviceOverWifiPAF() * Factor out the long expression into local Signed-off-by: Lo,Chin-Ran <[email protected]> * Remove the redundant LogErrorOnFailure() Signed-off-by: Lo,Chin-Ran <[email protected]> * Restyled by clang-format * Use the smart pointer to detect if the caller is still valid in the callback function Signed-off-by: Lo,Chin-Ran <[email protected]> * Fix the building error after rebase to TOT of master branch Signed-off-by: Lo,Chin-Ran <[email protected]> * Change the dbus interface usage by following the new api update in wpa_supplicant Signed-off-by: Lo,Chin-Ran <[email protected]> * Restyled by clang-format * * Add freq_list option to support multiple channels * Add more tests in QRCode test Signed-off-by: Lo,Chin-Ran <[email protected]> * Restyled by clang-format * * Change to have the consistent naming of the new added variables * Fix the problem to add tests in TestQRCode.cpp * Use a list to track the validation of the caller object. Signed-off-by: Lo,Chin-Ran <[email protected]> * Restyled by clang-format * Cancel the subscription in destructor to avoid the use-after-free issue Signed-off-by: Lo,Chin-Ran <[email protected]> * Restyled by clang-format --------- Signed-off-by: Lo,Chin-Ran <[email protected]> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Karsten Sperling <[email protected]>
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Jul 31, 2024
…ject-chip#33977) * [NXP] Add --wifi-paf commission in chip-tool and apps of Linux platform * Need to enable the function by adding "chip_device_config_enable_wifipaf=true" * chip-tool: Add wifi-paf option for pairing. Example: $ chip-tool pairing wifi-paf 1 ap_ssid ap_pwd [setup-pin-code] [discriminator] * apps: Add --wifi-paf. Example: $ chip-all-clusters-app --wifi --wifi-paf Note: Need the usd functions of wpa_supplicant to run this option Signed-off-by: Lo,Chin-Ran <[email protected]> * Restyled by clang-format * Restyled by gn * * Add the missing compile macro * Restyled by clang-format * Update src/controller/CHIPDeviceController.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update src/include/platform/ConnectivityManager.h Co-authored-by: Boris Zbarsky <[email protected]> * Update examples/platform/linux/Options.cpp Co-authored-by: Karsten Sperling <[email protected]> * Change by following the review's comment: * Change the name of option to [pair_mode]-[network] * Remove redundant compile flags * Move to start the Wi-Fi Manager in initialization stage * Unconditional the defintion * Add the cancel-publish / cancel-subscribe dbus interface * Fix bugs: - Redundant callback function registration - Remove the incorrect StackLock Signed-off-by: Lo,Chin-Ran <[email protected]> * Restyled by clang-format * Change by following the review's comment: - Unconditional functions in SetUpCodePairer - Change the description of the comment Signed-off-by: Lo,Chin-Ran <[email protected]> * * Add the identifier to distinguish connections * Unconditional the SetupCode verification Signed-off-by: Lo,Chin-Ran <[email protected]> * Restyled by clang-format * Add RendezvousInformationFlag::kWiFiPAF to tests of TestQRCode Signed-off-by: Lo,Chin-Ran <[email protected]> * Restyled by clang-format * * Add code-wifi to do WiFiPAF by using code. example: - Linux DUT: sudo ./chip-all-clusters-app --wifi --wifipaf - Controller: sudo ./chip-tool pairing code-wifi 1 ap_ssid ap_pwd MT:-24J0SGJ10KA0648G00 Signed-off-by: Lo,Chin-Ran <[email protected]> * Restyled by clang-format * Update src/transport/raw/PeerAddress.h Co-authored-by: Boris Zbarsky <[email protected]> * Update examples/chip-tool/commands/payload/SetupPayloadParseCommand.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update src/include/platform/CHIPDeviceConfig.h Co-authored-by: Boris Zbarsky <[email protected]> * Change by following the review's comment: * Add to end of the queue in OnDiscoveredDeviceOverWifiPAF() * Factor out the long expression into local Signed-off-by: Lo,Chin-Ran <[email protected]> * Remove the redundant LogErrorOnFailure() Signed-off-by: Lo,Chin-Ran <[email protected]> * Restyled by clang-format * Use the smart pointer to detect if the caller is still valid in the callback function Signed-off-by: Lo,Chin-Ran <[email protected]> * Fix the building error after rebase to TOT of master branch Signed-off-by: Lo,Chin-Ran <[email protected]> * Change the dbus interface usage by following the new api update in wpa_supplicant Signed-off-by: Lo,Chin-Ran <[email protected]> * Restyled by clang-format * * Add freq_list option to support multiple channels * Add more tests in QRCode test Signed-off-by: Lo,Chin-Ran <[email protected]> * Restyled by clang-format * * Change to have the consistent naming of the new added variables * Fix the problem to add tests in TestQRCode.cpp * Use a list to track the validation of the caller object. Signed-off-by: Lo,Chin-Ran <[email protected]> * Restyled by clang-format * Cancel the subscription in destructor to avoid the use-after-free issue Signed-off-by: Lo,Chin-Ran <[email protected]> * Restyled by clang-format --------- Signed-off-by: Lo,Chin-Ran <[email protected]> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Karsten Sperling <[email protected]>
|
I modified the src/platform/device.gni file. I changed chip_device_config_enable_wifipaf = false to chip_device_config_enable_wifipaf = true, and then compiled the chip tool. During the compilation, I encountered an error. The error log is as follows: ERROR at //third_party/connectedhomeip/src/include/platform/ConnectivityManager.h:39:11: Include not allowed. Is there an issue with the way I made the modification? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.