Pass largepayload flag into CommandSender in IM test app. #33976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pidarped
force-pushed
the
IMTestCommandSender
branch
2 times, most recently
from
750dca9 to
b652d5c
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple and
kkasperczyk-no
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #33976: Size comparison from 4cdce52 to b652d5c Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jun 18, 2024
src/app/tests/suites/commands/interaction_model/InteractionModel.h
Outdated
Show resolved
Hide resolved
pidarped
force-pushed
the
IMTestCommandSender
branch
from
1a09845 to
f692f5f
Compare
src/app/tests/suites/commands/interaction_model/InteractionModel.h
Outdated
Show resolved
Hide resolved
|
PR #33976: Size comparison from acf823f to f692f5f Increases above 0.2%:
Full report (54 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
pidarped
force-pushed
the
IMTestCommandSender
branch
from
f692f5f to
544095d
Compare
Use the session information from DeviceProxy to construct CommandSender for large payload if session supports it. Co-authored-by: Andrei Litvin <[email protected]>
pidarped
force-pushed
the
IMTestCommandSender
branch
from
544095d to
9c5bdd0
Compare
|
PR #33976: Size comparison from eeac38f to 9c5bdd0 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
approved these changes
Jun 18, 2024
bzbarsky-apple
approved these changes
Jun 19, 2024
diogopintodsr
pushed a commit
to diogopintodsr/connectedhomeip
that referenced
this pull request
Jun 20, 2024
…ip#33976) Use the session information from DeviceProxy to construct CommandSender for large payload if session supports it. Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the session information from DeviceProxy to construct CommandSender for large payload if session supports it.