make sure test event trigger delegate is not null before using it #33949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
pullapprove
bot
requested review from
yunhanw-google,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
tcarmelveilleux
approved these changes
Jun 17, 2024
|
PR #33949: Size comparison from 4d5e2ee to e5ea8a0 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
I'm not sure i agree with this... Test Event Trigger is required by those apps. |
|
@mkardous-silabs It could be said that the smoke-co-alarm app could indeed need a test trigger but I don't see a reason not to give the user an option not to not have it. Test triggers are needed only for dev and cert, and not intended to have in shipping products, obviously. |
…pp is built without setting test event trigger delegate mTestEventTriggerDelegate
fessehaeve
force-pushed
the
pull-request/fix-unsafe-test-trigger-calls
branch
from
e5ea8a0 to
82f7cd9
Compare
|
PR #33949: Size comparison from 74768a8 to 82f7cd9 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bauerschwan
approved these changes
Jul 16, 2024
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
…oject-chip#33949) * - added null check to code which was leading to a fatal error if an app is built without setting test event trigger delegate mTestEventTriggerDelegate * Log warning message when mTestEventTriggerDelegate is null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an app is not setting the test event trigger delegate, while CHIP_CONFIG_ENABLE_ICD_SERVER is enabled, it would result in accessing a nonexistent memory.