[NXP][platform] Fixing RAM buffer alignment issue on NXP platforms #33895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple and
lazarkov
pullapprove
bot
requested review from
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #33895: Size comparison from bbd3419 to 1fe11c5 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Damian-Nordic
approved these changes
Jun 13, 2024
bzbarsky-apple
approved these changes
Jun 13, 2024
…ffer Issue could happen on NXP platforms supporting Matter with the RAM storage module + littlefs due to read buffer alignment issue. As mflash_drv_read mandates the alignment of dst read buffer to 4 bytes, make sure to always align read buffers to 4 bytes. Signed-off-by: Gatien Chapon <[email protected]>
chapongatien
force-pushed
the
bugfix/nxp-read-buffer-alignment-issue
branch
from
1fe11c5 to
1ffe6aa
Compare
|
PR #33895: Size comparison from 18903b3 to 1ffe6aa Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jun 14, 2024
diogopintodsr
pushed a commit
to diogopintodsr/connectedhomeip
that referenced
this pull request
Jun 20, 2024
…ffer (project-chip#33895) Issue could happen on NXP platforms supporting Matter with the RAM storage module + littlefs due to read buffer alignment issue. As mflash_drv_read mandates the alignment of dst read buffer to 4 bytes, make sure to always align read buffers to 4 bytes. Signed-off-by: Gatien Chapon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description:
An issue may happen on NXP platforms supporting Matter with the RAM storage module + littlefs due to a RAM buffer alignment issue preventing the device to load matter file system data in RAM.
Fix proposed:
As the NXP mflash_drv_read function mandates the alignment of dst read buffer to 4 bytes, make sure to always align read buffers to 4 bytes.